Re: RoyaleUnit testing - swf player version used for testing

2019-10-09 Thread Josh Tynjala
Yeah, I think it would make a lot of sense to update our build scripts to use this environment variable when launching RoyaleUnit tests. I'm pretty sure that it is already set on the CI server for Mustella tests, so we should have the build consistently use the same version for everything. As a bo

Re: RoyaleUnit testing - swf player version used for testing

2019-10-09 Thread Greg Dove
Thanks Josh, that definitely sounds like a better option. I will give that a try for that side of things locally. Maybe we can also use this on the CI server to specify the version that is used? On Thu, Oct 10, 2019 at 7:30 AM Josh Tynjala wrote: > The RoyaleUnit Ant task has a "command" para

Re: RoyaleUnit testing - swf player version used for testing

2019-10-09 Thread Josh Tynjala
The RoyaleUnit Ant task has a "command" parameter where we can pass in the path of a specific executable. I don't think the Ant task should try to read a magic environment variable. Instead, we can reference the environment variable inside the Ant script. Something like this should probably work:

RoyaleUnit testing - swf player version used for testing

2019-10-09 Thread Greg Dove
This is partly for general input, but also for Josh specifically in relation to RoyaleUnit Background I am continuing to add unit tests, mostly language level stuff. It is rare, but there can be some things to account for in terms of differences caused by the player being used for testing (and al