Re: Maven build broken

2017-10-19 Thread Alex Harui
I filed https://issues.apache.org/jira/browse/INFRA-15328. We don't know if that will fix the problem or not. It is just a guess given that the current gecko driver is old (0.13.0) and I'm running 0.16.0 and documentation implies that you need 0.18.0 for Firefox 54. -Alex On 10/19/17, 6:44 PM,

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Alex Harui
display:none is hooked up to the visible property. You can use states to change the visible property. IncludeIn/ExcludeFrom should operate on the DOM since there is no "property" that affects that. We could introduce an "includeInLayout" property that affects visibility:hidden, but I found that

Re: Maven build broken

2017-10-19 Thread Alex Harui
Piotr, Dave is referring to the builds@ mailing list. Where we can ask for help. And maybe get permission to make changes to the Windows machine if one of us wants to learn how Infra installs software. And then worry that we'll screw up any other project that was happy with that version of Geck

Re: Maven build broken

2017-10-19 Thread Piotr Zarzycki
Hi Dave, I'm sorry what is the "builds ML"? Maybe we can upgrade something on the Machines. Piotr On Fri, Oct 20, 2017, 00:21 Dave Fisher wrote: > Hi Alex, > > There is a builds ML and I suspect that you might be able to get some keys > to one if you ask nicely. You are a Member. > > Regards,

Re: Maven build broken

2017-10-19 Thread Dave Fisher
Hi Alex, There is a builds ML and I suspect that you might be able to get some keys to one if you ask nicely. You are a Member. Regards, Dave > On Oct 19, 2017, at 3:17 PM, Alex Harui wrote: > > Hi Piotr, > > The integration tests passed for me with an older Firefox and Selenium. > But this

Re: Maven build broken

2017-10-19 Thread Alex Harui
Hi Piotr, The integration tests passed for me with an older Firefox and Selenium. But this new Selenium may not be compatible with the version of GeckoDriver used on builds.a.o. This is a problem with using builds.a.o: we don't have full control over all of the pieces. This is why I pay for apac

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Piotr Zarzycki
Hi Olaf, Yes they are working and in my first simple tests they seems to be working nicely with MDL module. I would not change their behavior in case of removing. I would rather improve it using your suggestion. 1) If some element in state "X" wasn't display yet it should not exists in the DOM -

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Olaf Krueger
>States removes element from DOM I wonder why Royale states removes element from DOM instead of using the CSS properties visibility:hidden; (The element is hidden but still take up the same place) or display:none (The element is hidden and take up no space); Does somebody know what is the benefit

Re: Maven build broken

2017-10-19 Thread Piotr Zarzycki
Alex, I saw you push to the repo with selenium upgrade, now those tests failing in other place. I have to admit that I didn't have time to look into that. I hope to try setup selenium locally tomorrow, but if you have some idea earlier try it please. Thanks, Piotr 2017-10-19 10:01 GMT+02:00 Ale

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Piotr Zarzycki
States seems to be working nicely :) One question I accidentally assign to currentState wrong state and my content just disappear. What actually should happen in that case. In my opinion - Should be thrown an exception. Thanks, Piotr 2017-10-19 22:23 GMT+02:00 Piotr Zarzycki : > Ahh! It was pro

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Piotr Zarzycki
Ahh! It was problem on my sight. In Application need to be declared "SimpleStatesImpl" [1] [1] https://paste.apache.org/HEDa Piotr 2017-10-19 22:14 GMT+02:00 Piotr Zarzycki : > Harbs, > > States removes element from DOM, so this is very different than just > setting visible to false, but agree

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Piotr Zarzycki
Harbs, States removes element from DOM, so this is very different than just setting visible to false, but agree with you that the results for the user is the same. Thanks for sharing your thoughts! 2017-10-19 22:06 GMT+02:00 Harbs : > States cause elements to be added and removed. > > FWIW, I

Re: [Royale|FlexJS] Questions about states

2017-10-19 Thread Harbs
States cause elements to be added and removed. FWIW, I have found little reason to use States in Royale because setting visible to false causes elements to take up no space. Hence I’ve never really spent time looking into them. Harbs > On Oct 19, 2017, at 11:02 PM, Piotr Zarzycki > wrote: >

[Royale|FlexJS] Questions about states

2017-10-19 Thread Piotr Zarzycki
Hi Guys, I'm trying to understand how states are working. I have simple code which should actually work. I'm using latest FlexJS from develop - not Royale yet. [1] Am I doing something wrong ? Can someone shed some light how internally States are working ? I would like to debug things, but not su

Re: [Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Peter Ent
AH, I see what you did. Other examples compile now. Thanks. —peter On 10/19/17, 2:45 PM, "Peter Ent" wrote: >Thanks. That change worked. I forget to check config files for 'flex'. I >will carry that over to other examples as I build them. > >‹peter > >On 10/19/17, 2:42 PM, "Alex Harui" wrote: >

Re: [Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Peter Ent
Thanks. That change worked. I forget to check config files for 'flex'. I will carry that over to other examples as I build them. ‹peter On 10/19/17, 2:42 PM, "Alex Harui" wrote: >I just tried it and didn't even get as far as Peter did. I pushed a >change that got DataBindingExample to compile

Re: [Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Alex Harui
I just tried it and didn't even get as far as Peter did. I pushed a change that got DataBindingExample to compile and run. Hopefully Peter's problem is related (looking in an old flex-config.xml) -Alex On 10/19/17, 11:34 AM, "Harbs" wrote: >I have not tried today, but the last time I tried wi

Re: [Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Harbs
I have not tried today, but the last time I tried with ant, it worked as well. > On Oct 19, 2017, at 9:29 PM, Piotr Zarzycki wrote: > > Hi Peter, > > I just wanted to let you know that built of DataBindingExample by Maven is > running without the problem - JS and SWF version. (Windows) > > Pio

Re: [Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Piotr Zarzycki
Hi Peter, I just wanted to let you know that built of DataBindingExample by Maven is running without the problem - JS and SWF version. (Windows) Piotr 2017-10-19 20:20 GMT+02:00 Peter Ent : > Hi, > > After pulling the merge/changes on develop branches (royale-* repos), I > built -compiler and -

[Royale/Examples] Unable to Build DataBindingExample

2017-10-19 Thread Peter Ent
Hi, After pulling the merge/changes on develop branches (royale-* repos), I built -compiler and -asjs without errors. Now I'm trying to build (ant) DataBindingExample and get the error(s) below. Not sure if I missed something or don't have an ENV var set (using macOS Sierra): Thanks —peter

Re: Maven build broken

2017-10-19 Thread Alex Harui
I think Maven is supposed to bring down Selenium. I'm out of time for tonight, but if you have time, take a look at the tomcat server that is used for the Integration Tests. There might be a configuration where it is still looking for examples in a flexjs folder instead of a royale folder. Good

Re: Maven build broken

2017-10-19 Thread Piotr Zarzycki
Anyone has setup selenium locally ? Piotr 2017-10-19 9:21 GMT+02:00 Piotr Zarzycki : > Just build locally all examples by Maven and Royale Store looks perfectly > fine. > > Piotr > > 2017-10-19 9:20 GMT+02:00 Alex Harui : > >> I don't know for sure, I didn't create the tests. I believe they are

Re: Maven build broken

2017-10-19 Thread Piotr Zarzycki
Just build locally all examples by Maven and Royale Store looks perfectly fine. Piotr 2017-10-19 9:20 GMT+02:00 Alex Harui : > I don't know for sure, I didn't create the tests. I believe they are > looking for certain UI widgets in RoyaleStore. > > I'm still syncing up to build everything local

Re: Maven build broken

2017-10-19 Thread Alex Harui
I don't know for sure, I didn't create the tests. I believe they are looking for certain UI widgets in RoyaleStore. I'm still syncing up to build everything locally, but if you have time, it might be worth just running RoyaleStore to see if it runs properly. If the examples aren't generating a r

Re: Maven build broken

2017-10-19 Thread Piotr Zarzycki
Hi Alex, Just trying to understand what actually is doing that test. :) Piotr 2017-10-19 9:07 GMT+02:00 Alex Harui : > The node tests passed, it failed in IntegrationTests. See the list of > goals near the end of the output. > > -Alex > > On 10/18/17, 11:46 PM, "Harbs" wrote: > > >To me it lo

Re: Maven build broken

2017-10-19 Thread Alex Harui
The node tests passed, it failed in IntegrationTests. See the list of goals near the end of the output. -Alex On 10/18/17, 11:46 PM, "Harbs" wrote: >To me it looks like the “JSNode” target for the node test is not working. > >I’m a bit confused, because setting the config to “node” works for m