Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

What I'm wondering is how you would make it so it was as if that selector wasn't specified at all. I guess the default value for position is "static" so the user would specify position: static? -Alex On 6/4/18, 10:03 PM, "Harbs" wrote: Any other selector should disable that one because

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Any other selector should disable that one because that’s about as unspecific as you can get and the higher level of specificity always wins. > On Jun 5, 2018, at 8:00 AM, Alex Harui wrote: > > Ah, ok. How would a user disable that selector in case it did something > undesirable? > > -Alex

RE: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

This looks ok to me. As I understand it [1] the only difference between position: static (which is the default) and position: relative is that they don’t obey left, top, bottom, right rules. Since Royale won’t be injecting unintended offset values, the default behavior shouldn’t change. [1]

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Ah, ok. How would a user disable that selector in case it did something undesirable? -Alex On 6/4/18, 1:56 PM, "Harbs" wrote: Sorry I was a bit confused. The selector that works is: .Application * { position: relative; } > On Jun 4, 2018, at 11:32 PM, Harbs

Re: [royale-asjs] branch develop updated: Removed unselectable selector

I see. There probably isn't one right way, so some beads might apply styles in other ways. I was thinking it might be more discoverable for a version of DisabledBeads to also use Type Selectors. Otherwise, debugging collisions in the use of, say, opacity, by more than one bead will be a pain

Re: Incorrect descendent CSS output

Thanks. I just observed a new problem. I have not pulled in your changes, so I don’t know if it’s fixed, but it used to work correctly. Much of the following css is now being stripped out. CSS in the http://www.w3.org/1999/xhtml namespace should always be left

AR standard

Hi Royale Peeps, This standard looks interesting. It may be early, but what do you think? https://www-engadget-com.cdn.ampproject.org/c/s/www.engadget.com/amp/2018/06/04/apple-pixar-adobe-standardized-ar-file-format/ Regards, Dave Sent from my iPhone

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Sorry I was a bit confused. The selector that works is: .Application * { position: relative; } > On Jun 4, 2018, at 11:32 PM, Harbs wrote: > > Yes. But it cascades down. > > I manually made this change to the TreeExample project, and it fixed the bug. > >> On Jun 4, 2018, at 7:22 PM,

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

No. It’s one css selector in the CSS. No inline styles. > On Jun 4, 2018, at 11:38 PM, Piotr Zarzycki wrote: > > Doing that does this mean that we are getting back to the previous state, > where we have had position=relative everywhere ? > > pon., 4 cze 2018 o 22:32 Harbs napisał(a): > >>

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Doing that does this mean that we are getting back to the previous state, where we have had position=relative everywhere ? pon., 4 cze 2018 o 22:32 Harbs napisał(a): > Yes. But it cascades down. > > I manually made this change to the TreeExample project, and it fixed the > bug. > > > On Jun 4,

Re: [royale-asjs] branch develop updated: Removed unselectable selector

The closest example that we have is probably DisabledBead and DisabledAlphaBead. The DisabledAlphaBead applies styling (i.e. an alpha) when the DisabledBead disables a component. I was suggesting that there could be a UnselectableAppearance bead which gets applied together with the

Re: [Discussion] Package change names (was Re: 0.9.3 Release)

Hi Carlos, At this point, I think I've addressed all of the compiler issues that result in unnecessary output or processing. If Harbs is finished with the framework changes, then I think we can try building Jewel with and without Basic and see if there are still issues. I have to say that my

Re: [royale-asjs] branch develop updated: Added utility function to dynamically add CSS selectors

Ok! Thanks, don't know that we already was using that repo. Thanks! 2018-06-04 11:59 GMT+02:00 Harbs : > The Royale build pulls the externs from that repo. We have lots of changes > on top of Google externs that we need. We used to use patch files, but it > was cumbersome. Applying the changes

Re: Incorrect descendent CSS output

I pushed a change that should fix that. On 6/4/18, 1:40 AM, "Harbs" wrote: The following CSS: TitleBar CloseButton { width: 16px; height: 16px; margin: 0px; } is output as: .TitleBar CloseButton { margin: 0px;

Re: [royale-asjs] branch develop updated: Removed unselectable selector

I think it is too early Monday for me. I don't understand what you mean by "styling could also be a bead". How would folks discover the selector? Thanks, -Alex On 6/4/18, 9:16 AM, "Harbs" wrote: Fair enough. Of course the styling could also be a bead… > On Jun 4,

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

I'm still not understanding. Style.position is not inheriting so how would it cascade down? Isn't .Application only applied to the ? Thanks, -Alex On 6/4/18, 9:15 AM, "Harbs" wrote: I’m suggesting that we change defaults.css from: Application { padding: 0px;

Re: [royale-asjs] branch develop updated: Removed unselectable selector

Fair enough. Of course the styling could also be a bead… > On Jun 4, 2018, at 7:14 PM, Alex Harui wrote: > > IMO, it is easier for folks to know that there is a selector to override or > add styles to if it is in one of our .css files instead of buried in code. > > My 2 cents, > -Alex > >

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

I’m suggesting that we change defaults.css from: Application { padding: 0px; margin: 0px; } to: Application { padding: 0px; margin: 0px; position: relative; } I believe this will resolve this issue as the default would cascade down to all sub-elements.

Re: [royale-asjs] branch develop updated: Removed unselectable selector

IMO, it is easier for folks to know that there is a selector to override or add styles to if it is in one of our .css files instead of buried in code. My 2 cents, -Alex On 6/4/18, 9:11 AM, "Harbs" wrote: > I don't know why someone would want to override unselectable styles, but the

Re: [royale-asjs] branch develop updated: Removed unselectable selector

> I don't know why someone would want to override unselectable styles, but the > first idea that popped into my head was a different background color so folks > knew not to even bother to select text in the unselectable controls. Another > possibility is that there are other styles that may be

Re: [royale-asjs] branch develop updated: remove invalid "; utf8" in all inlined svg images

Hi Harbs, I think I tried that but not worked for inline SVG in CSS SVG inlined is a very fragile feature, and is not supported well cross browser. Maybe I'll give it a try again since I'm getting a blocking issue in IE11, I think is this [1] and can't get it working. IE11 does not process

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

I’m not sure exactly what change you are proposing, but UIBase used to set position=relative on all positioners. We took that away so that the "flex" and other display/layout styles would not have to deal with the excess clutter and overhead of having set position on so many elements in the

Re: [royale-asjs] branch develop updated: Removed unselectable selector

Feel free to change the name of the bead so that the Type Selector name looks "better". I think we agreed to drop the "Bead" portion of names going forward. If you are absolutely sure nobody will ever need to override what is in that selector, then I'm fine with injecting it with code and

Re: [royale-asjs] branch develop updated: Removed unselectable selector

That would probably work. I’m not totally happy with that selector name. I can switch the implementation if you think that’s better. I’m not sure why a user would override an “unelectable” style though. Harbs > On Jun 4, 2018, at 6:45 PM, Alex Harui wrote: > > Hi Harbs, > > My suggestion

Re: [royale-asjs] branch develop updated: Removed unselectable selector

Hi Harbs, My suggestion for adding the selector is to make the selector look like a Type/Element Selector with the name "UnselectableElementBead". If you do that, then wouldn't that selector be dropped out if nobody is using UnselectableElementBead? I would hope we could find a solution that

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

It just occurred to me that the problem is due to the default position being static. I just added position: relative; to the .Application css and that resolved the issue as well. I wonder if we could completely do away with the offsetParent logic in UIBase if we make the default position:

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Hi Yishay, IMO, the new fix is better. And you took the right approach by examining the code flow in the debugger. When layout fails for what appears to be a timing issue (in this case, offsetParent not set), we definitely want to take the time to carefully analyze why there is a timing

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Looking at it some more it has nothing to do with data binding. I pushed a different fix (799f1878250d8c69347f08442c2c333740efdb8d) that changes the layout itself. Here it's assumed the offsetParent is explicitly set before children's x and y are set. Should this be a general pattern? -- Sent

Re: Last class selectors

FYI, I just compiled a bare-bones app, and a Basic app with a View, VContainer and Label is 85KB uncompressed. 24KB gzipped. It looks like there’s no extra classes. The CSS is 546 bytes and 222 bytes gzipped. There’s no extra css either, although som empty selectors could use some cleanup.

Last class selectors

The only class selectors left in Basic defaults.css is: .Application *, .royale *, . royale *:before, . royale *:after { -moz-box-sizing: border-box; -webkit-box-sizing: border-box; box-sizing: border-box; } I’m not sure how to best get rid of this. Thoughts? Harbs

Re: [royale-asjs] branch develop updated: remove invalid "; utf8" in all inlined svg images

Looking at the Jewel themes, I thought of a possible suggestion for specifying SVG color: Instead of inlining fill='#{encodecolor($primary-color)}’, I’m wondering if it might be better to give the elements a class. Something like this: and elsewhere: .primary-fill{ fill: $primary-color;

Re: [royale-asjs] branch develop updated: Added utility function to dynamically add CSS selectors

The Royale build pulls the externs from that repo. We have lots of changes on top of Google externs that we need. We used to use patch files, but it was cumbersome. Applying the changes directly to a fork works better. I was just letting you know that if your build does not work, you might need

Re: [royale-asjs] branch develop updated: Added utility function to dynamically add CSS selectors

ok, but then don't understand that we have code that is not usable by our own. I think if that code can't be used, it should be as well in Royale-extras libs, so people wanting to use should grab both the modified closure compiler and the library with code that uses it make this sense? Thanks

Re: [royale-asjs] branch develop updated: Added utility function to dynamically add CSS selectors

FYI, this requires changes to the externs committed here: https://github.com/royale-extras/closure-compiler/commit/323c6b5f37973fac2bd611bfeb6f80359e3bbc98 > On Jun 4, 2018, at 12:04 PM, Carlos

Re: [royale-asjs] branch develop updated: Added utility function to dynamically add CSS selectors

Great! This seems to be very useful! thanks! :) 2018-06-04 10:22 GMT+02:00 : > This is an automated email from the ASF dual-hosted git repository. > > harbs pushed a commit to branch develop > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > > > The following commit(s) were

Incorrect descendent CSS output

The following CSS: TitleBar CloseButton { width: 16px; height: 16px; margin: 0px; } is output as: .TitleBar CloseButton { margin: 0px; width: 16px; height: 16px; } Instead of: .TitleBar .CloseButton { margin: 0px; width: 16px;

Re: [royale-asjs] branch develop updated: Removed unselectable selector

It does add the style to the class list. The only question is how to add the selector to the CSS. Thanks, Harbs > On Jun 4, 2018, at 10:24 AM, Carlos Rovira wrote: > > Hi, > > I think as Alex that better way for this is the bead add the css style to > classList. > > thanks > > 2018-06-04

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Carlos Rovira-2 wrote > this seems like a bug to be fixed at the core of the component, or the > layout system. It could be that data binding is messing it up, and that the data provider change triggers the layout before the rest of the components can probably size themselves. I need to look a

Re: [royale-asjs] branch develop updated: Removed unselectable selector

Hi, I think as Alex that better way for this is the bead add the css style to classList. thanks 2018-06-04 6:33 GMT+02:00 Alex Harui : > IMO, the better fix would be to just rename the selector in defaults.css > to be UnselectableElementBead and have UnselectableElementBead add >

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

Hi Yishay, this seems like a bug to be fixed at the core of the component, or the layout system. I was not aware about Layout Challenges page. But for me I'll prefer to discuss in mailing list, since GitHub pages seems more like a reference site, more than a discussion place. Said that this

Re: [Discussion] Package change names (was Re: 0.9.3 Release)

Hi Harbs, ok, I'll try to make a brief list of some of the classes involved so you and others can have a better understanding of how things can be restructured so we get best of both worlds. Hope to make this today. thanks Carlos 2018-06-02 21:36 GMT+02:00 Harbs : > Hi Carlos, > > I think our