Build failed in Jenkins: royale-compiler-integration-tests #415

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 129.90 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Build failed in Jenkins: TourDeFlexMigration #490

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 124.84 KB...] [mxmlc] Loading configuration: C:\jenkins\workspace\royale-asjs\frameworks\flex-config.xml [mxmlc]

Re: "has" vs "is": sharing code, swapping out subsystems, and more...

2020-01-15 Thread Alex Harui
You are welcome to try and see how many cache hits it gets. I think in renderers, we ask once per renderer. I'm not sure there is a faster way to do the first lookup of "is", but for "has" we could change the lookup and save time. On 1/15/20, 10:38 PM, "Greg Dove" wrote: For the

Re: "has" vs "is": sharing code, swapping out subsystems, and more...

2020-01-15 Thread Greg Dove
For the 'something is ISomeInterface' I had wondered in the past if these types of lookups could be incrementally cached on the 'is' target (after first lookup), that might make sense for interfaces, which are the deepest checks I think? caching result (could optionally create the Map)

Build failed in Jenkins: Royale_ASDoc_Example #491

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 41.26 KB...] [java] ^ [java] [java]

Re: MXML and warn-public vars

2020-01-15 Thread Alex Harui
We've been down this road before. I would rather warn folks to change their code so it will be as small and fast as possible. Others don't seem to care and would rather not change their code. The end-of-the-road for the "must mimic Flex" is that we will rarely read and write

Re: Fixing Maven Distribution

2020-01-15 Thread Piotr Zarzycki
Hi Carlos, I was talking about most common user scenario, where user open the project and hit Build. - Project is being build using SDK without Maven or Ant stuff. In order to test what I'm talking about: Open TourDeJewel (using asconfig.json which is part of the example - not your custom Maven

"has" vs "is": sharing code, swapping out subsystems, and more...

2020-01-15 Thread Alex Harui
Hi, Several different threads have brought up issues with sharing code between component sets. Other threads have offered different and clever ways to do various things like how MXML is applied to a component. Meanwhile, over in MX emulation, I was starting to copy some code from Basic to

Re: MXML and warn-public vars

2020-01-15 Thread Greg Dove
Am I misunderstanding or does this fix a usability issue with mxml and public vars? If it is fixing something that does not work, then presumably it only 'costs' for people who want that thing to work (public var assignments in mxml instances?) and not for others. That seems like the app-dev still

Build failed in Jenkins: royale-compiler-integration-tests #414

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 129.25 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Re: MXML and warn-public vars

2020-01-15 Thread Alex Harui
Clever idea, but I don't like it. We are trying to reduce function call overhead and reduce download size, not increase it. The reasons you are getting a public var warning is so that the app-dev has control over which members will have function call overhead. I don't think we should take

Re: empty class names

2020-01-15 Thread Alex Harui
On 1/15/20, 2:20 PM, "Carlos Rovira" wrote: We're already using UIBase APIs in HTML elements. Example is used in all screens in Tour De Jewel check this link [1], for an example with Pre tag. I understand that's how it is currently coded. I believe we are discussing whether that is

Re: How to keep trace() in release build?

2020-01-15 Thread Harbs
> Yeah, that's what I generally do as well. Ditto. > On Jan 16, 2020, at 1:27 AM, Greg Dove wrote: > > Yeah, that's what I generally do as well. > > Not sure if you are working across swf and js at the same time... if I am > comparing swf stuff with js, I like to have both in the js console,

Re: MXML and warn-public vars

2020-01-15 Thread Harbs
FWIW, all the functions in goog.reflect are worthy of a look. > On Jan 16, 2020, at 6:32 AM, Harbs wrote: > > Sounds good! > > https://github.com/google/closure-compiler/wiki/Type-Based-Property-Renaming > > > The

Re: MXML and warn-public vars

2020-01-15 Thread Harbs
Sounds good! https://github.com/google/closure-compiler/wiki/Type-Based-Property-Renaming The function seems to be goog.reflect.objectProperty() I’m not sure exactly how it works though. > On Jan 16, 2020, at 1:37

Build failed in Jenkins: Royale_ASDoc_Example #490

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 40.62 KB...] [java] ^ [java] [java]

Build failed in Jenkins: royale-compiler-integration-tests #413

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 130.78 KB...] [junit] [junit] Jan 16, 2020 1:34:34 AM

Build failed in Jenkins: Royale_ASDoc_Example #489

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 41.94 KB...] [java] ^ [java] [java]

Re: MXML and warn-public vars

2020-01-15 Thread Greg Dove
actually just as another fyi, Harbs pointed out some intriguing goog methods recently - I don't have an immediate reference to it sorry. One of those seemed to allow for access to renamed names by wrapping the original names in a 'magic' method that presumably GCC recognises (but presumably

Build failed in Jenkins: royale-compiler-integration-tests #412

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 130.67 KB...] [junit] SEVERE: goog/object/object.js:307: ERROR - This language feature is only

Re: MXML and warn-public vars

2020-01-15 Thread Greg Dove
reflection data has similar stuff to support release mode get/set for public vars. I did not look at MXML startup assignments like this, but it sounds good to me. I don't know if it makes sense, but considering this is just startup assignments, could one function combine all of the startup

Re: How to keep trace() in release build?

2020-01-15 Thread Greg Dove
Yeah, that's what I generally do as well. Not sure if you are working across swf and js at the same time... if I am comparing swf stuff with js, I like to have both in the js console, in which case I do something like this:

Re: How to keep trace() in release build?

2020-01-15 Thread Josh Tynjala
As a temporary workaround, I was able to use console.log() instead. -- Josh Tynjala Bowler Hat LLC On Wed, Jan 15, 2020 at 2:52 PM Josh Tynjala wrote: > I see that Language.trace() has a @royaledebug doc tag, which seems to > remove it from a release build. I just

MXML and warn-public vars

2020-01-15 Thread Josh Tynjala
According to the commit linked below, the -warn-public-vars compiler option was added because setting a public var in MXML does not currently work properly in a release build. https://github.com/apache/royale-compiler/commit/eed5882ba935870a98ba4fe8cbf499e5d8344f60 In other words, this MXML code

How to keep trace() in release build?

2020-01-15 Thread Josh Tynjala
I see that Language.trace() has a @royaledebug doc tag, which seems to remove it from a release build. I just spent half an hour trying to figure out why some event listeners weren't being called. Turns out that they were, in fact, being called. Instead, the compiler was silently removing some of

Fixing Maven Distribution

2020-01-15 Thread Carlos Rovira
Hi Piotr, Finally I get some time to get over this issue. I was trying to see what we need to fix maven distribution. I run mvn install -P option-with-swf,with-distribution I get royale-asjs/distribution/target/... and inside I have the Royale Maven SDK generated. Then I copied to my SDKs

Build failed in Jenkins: Royale_ASDoc_Example #488

2020-01-15 Thread apacheroyaleci
See Changes: [aharui] add binding metadata to Spark TextInput. Should fix #678 [joshtynjala] ElementWrapper: fix issue where missing @export would cause

Re: empty class names

2020-01-15 Thread Carlos Rovira
We're already using UIBase APIs in HTML elements. Example is used in all screens in Tour De Jewel check this link [1], for an example with Pre tag. [1]

Jenkins build is back to normal : royale-asjs #563

2020-01-15 Thread apacheroyaleci
See

Build failed in Jenkins: royale-asjs #562

2020-01-15 Thread apacheroyaleci
See Changes: [aharui] add binding metadata to Spark TextInput. Should fix #678 -- [...truncated 210.88 KB...] download-jar: [echo] basedir

Build failed in Jenkins: royale-compiler-integration-tests #411

2020-01-15 Thread apacheroyaleci
See Changes: [joshtynjala] PackageHeaderEmitter: fix issue where externs for package-level [joshtynjala] Fixed issue where Closure warned about externs in top-level

Build failed in Jenkins: TourDeFlexMigration #486

2020-01-15 Thread apacheroyaleci
See Changes: [carlosrovira] jewel-datagrid: avoid relayout when removing or adding an item [carlosrovira] tour-de-jewel: fix itemrenderers

Re: empty class names

2020-01-15 Thread Alex Harui
On 1/15/20, 11:42 AM, "Harbs" wrote: > What else from UIBase do they really need? - addElement and friends. - width/height/percent - x/y - Layout needs to work when acting as siblings for UIBase components (not sure what’s required for that) - measurement (probably

Re: empty class names

2020-01-15 Thread Harbs
> What else from UIBase do they really need? - addElement and friends. - width/height/percent - x/y - Layout needs to work when acting as siblings for UIBase components (not sure what’s required for that) - measurement (probably related to the above) - id - style - className - parent - alpha -

Build failed in Jenkins: Royale_ASDoc_Example #487

2020-01-15 Thread apacheroyaleci
See Changes: [carlosrovira] jewel-datagrid: avoid relayout when removing or adding an item [carlosrovira] tour-de-jewel: fix itemrenderers

Re: empty class names

2020-01-15 Thread Alex Harui
On 1/15/20, 10:47 AM, "Harbs" wrote: If that’s the case, the HTML element components need a new base class. Pretty much the entire HTML component set does not use beads and doesn’t require classes. Are you saying they shouldn’t be based on UIBase? Yes, that makes sense to put

Re: empty class names

2020-01-15 Thread Harbs
If that’s the case, the HTML element components need a new base class. Pretty much the entire HTML component set does not use beads and doesn’t require classes. Are you saying they shouldn’t be based on UIBase? > On Jan 15, 2020, at 7:17 PM, Alex Harui wrote: > > I would argue it is a bug for

Re: empty class names

2020-01-15 Thread Alex Harui
I would argue it is a bug for any subclass of UIBase to not have a class. "All" UIBase subclasses should be comprised of beads, and the beads should have defaults overridable in the CSS. So, IMO, if you want to add a debug-time check for no specified typenames, that's fine, but we shouldn't be

Re: Spectrum Components

2020-01-15 Thread Harbs
FYI, I just updated the project readme with a link to the demo and some markup to show what a full Royale app looks like: https://github.com/unhurdle/spectrum-royale > On Jan 13, 2020, at 1:30 AM, Harbs wrote: > > FYI, I’ve been working on filling out a demo the Spectrum Royale components: >

Build failed in Jenkins: royale-compiler-integration-tests #410

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 160.38 KB...] [junit] scanning for overrides: ApplicationBase [junit] scanning for overrides:

Re: [royale-asjs] branch develop updated: Reversed logic on number lookup in AllCSSValuesImpl

2020-01-15 Thread Carlos Rovira
Hi Harbs, can you elaborate more on defaultLenghtUnit. not sure I understand what is the purpose or how to use it. thanks El mar., 14 ene. 2020 a las 20:53, Harbs () escribió: > What prompted this change was the fact that I found that flex-shrink was > not working because it’s a number.

Re: empty class names

2020-01-15 Thread Carlos Rovira
I'm ok to do that, since I think having a clean DOM is very important and helps at a later time when trying to debug or fix issues. That came at a cost of a check, for sure others can argument about this is not PAYG, but my perception is that we should apply PAYG intelligently and not just 100% of

Build failed in Jenkins: TourDeFlexMigration #485

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 386.27 KB...] [mxmlc] scanning for overrides: UIButtonBase [mxmlc] scanning for overrides: CSSTextField

Build failed in Jenkins: Royale_ASDoc_Example #486

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 69.92 KB...] [java] ^ [java] [java]

Build failed in Jenkins: royale-compiler-integration-tests #409

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 159.24 KB...] [junit] scanning for overrides: ApplicationBase [junit] scanning for overrides:

Build failed in Jenkins: TourDeFlexMigration #484

2020-01-15 Thread apacheroyaleci
See Changes: [harbs] Fixes empty class names pending discussion -- [...truncated 385.25 KB...] [mxmlc] scanning for overrides:

Build failed in Jenkins: royale-compiler-integration-tests #408

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 156.57 KB...] [junit] [junit] Jan 15, 2020 10:31:07 AM

empty class names

2020-01-15 Thread Harbs
Currently when an element is added to a parent, the following is called: setClassName(computeFinalClassNames()); Because there’s no check there to determine if a class name was actually set, you can end up with elements with empty class names like so: , . While this has no visual effect, it

Build failed in Jenkins: TourDeFlexMigration #483

2020-01-15 Thread apacheroyaleci
See Changes: [tzivi] Added MultiSelectionTree [tzivi] TreeMultiSelect changes -- [...truncated 385.03 KB...] [mxmlc] scanning for

Build failed in Jenkins: Royale_ASDoc_Example #484

2020-01-15 Thread apacheroyaleci
See Changes: [tzivi] Added MultiSelectionTree [tzivi] TreeMultiSelect changes -- [...truncated 68.66 KB...] [java]

Build failed in Jenkins: royale-compiler-integration-tests #407

2020-01-15 Thread apacheroyaleci
See Changes: -- [...truncated 160.41 KB...] [junit] scanning for overrides: ApplicationBase [junit] scanning for overrides:

Build failed in Jenkins: TourDeFlexMigration #482

2020-01-15 Thread apacheroyaleci
See Changes: [aharui] fix virtual scrolling. Should fix #664 [aharui] handle scrollbars that are always visible. Should fix #679 --