Re: Refactoring Layouts

[Carlos Rovira]

Hi Harbs,

I think flexbox does not resolve all layout problems, so it seems Grid is a
need, so maybe we should go for Edge, taking into account that in a year or
so, Edge will pass IE11, or that is what it should be... I think this is a
huge issue to make this shift

2018-02-26 9:31 GMT+01:00 Harbs :

> Yes. Grid is better than Flexbox for most things, but going with grid
> really depends on what browsers we’re supporting.
>
> IE 10 and 11 do support grid, but their support for grid is based on an
> old spec. Edge got support for grid only recently.
>
> https://rachelandrew.co.uk/archives/2016/11/26/should-i-try-to-use-the-ie-
> implementation-of-css-grid-layout/  archives/2016/11/26/should-i-try-to-use-the-ie-implementation-of-css-grid-
> layout/>
> https://gridbyexample.com/browsers/ 
>
> > On Feb 26, 2018, at 9:43 AM, Carlos Rovira 
> wrote:
> >
> > Hi Alex,
> >
> > two things here:
> >
> > 1) while reading about css layouts seems Grid system is the most
> > sophisticated one and is better than flexbox, so I think we should change
> > to that since flex box does not support some layouts and Grid seems the
> > future and more like what we had in flex
> >
> > 2) yesterday making a simple blog example I put a vertical layout in a
> view
> > and a simple Js:button in SWF version button gets all the horizontal
> space
> > while in js is not affected. I think this differences must be removed
> since
> > if we post some example with both versions, both must be visuals equal
> (as
> > much as we can), but this difference is huge
> >
> >
> > 2018-02-26 6:39 GMT+01:00 Alex Harui :
> >
> >> Hi,
> >>
> >> Time for another refactoring of layout.  My goal for this round is to
> move
> >> the border/padding/margin calculations into the ValuesManager, and get
> the
> >> JS version to use getComputedStyle.  I think it will be cleaner to
> >> abstract the differences between SWF and JS in the ValuesManager and
> allow
> >> for different IValuesImpls to have different levels of sophistication
> for
> >> SWF.
> >>
> >> Right now, our "FlexibleChild" layouts are not factoring in margins
> >> correctly.
> >>
> >> Thoughts?
> >> -Alex
> >>
> >>
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
>
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Re: Refactoring Layouts

[Piotr Zarzycki]

Let's focus on things what Alex is proposing and eventually move all
discussion about Grid vs Flex Box to separate things. I believe the things
which he is going to do is also really important.

2018-02-26 9:36 GMT+01:00 Piotr Zarzycki :

> I would also not go with the assumption that Grid will/can replace Flex
> box. It's just different system for layouts. They can both work well
> together. IMO we didn't even get out all possibilities of Flex Box, so
> getting on board Grid is a lot of work. I was thinking during my work on
> website to create some set of layouts which utilize Flex Box, but it ends
> up that easier to me was just create css class.
>
> Thanks, Piotr
>
> 2018-02-26 9:31 GMT+01:00 Harbs :
>
>> Yes. Grid is better than Flexbox for most things, but going with grid
>> really depends on what browsers we’re supporting.
>>
>> IE 10 and 11 do support grid, but their support for grid is based on an
>> old spec. Edge got support for grid only recently.
>>
>> https://rachelandrew.co.uk/archives/2016/11/26/should-i-try-
>> to-use-the-ie-implementation-of-css-grid-layout/ <
>> https://rachelandrew.co.uk/archives/2016/11/26/should-i-try
>> -to-use-the-ie-implementation-of-css-grid-layout/>
>> https://gridbyexample.com/browsers/ 
>>
>> > On Feb 26, 2018, at 9:43 AM, Carlos Rovira 
>> wrote:
>> >
>> > Hi Alex,
>> >
>> > two things here:
>> >
>> > 1) while reading about css layouts seems Grid system is the most
>> > sophisticated one and is better than flexbox, so I think we should
>> change
>> > to that since flex box does not support some layouts and Grid seems the
>> > future and more like what we had in flex
>> >
>> > 2) yesterday making a simple blog example I put a vertical layout in a
>> view
>> > and a simple Js:button in SWF version button gets all the horizontal
>> space
>> > while in js is not affected. I think this differences must be removed
>> since
>> > if we post some example with both versions, both must be visuals equal
>> (as
>> > much as we can), but this difference is huge
>> >
>> >
>> > 2018-02-26 6:39 GMT+01:00 Alex Harui :
>> >
>> >> Hi,
>> >>
>> >> Time for another refactoring of layout.  My goal for this round is to
>> move
>> >> the border/padding/margin calculations into the ValuesManager, and get
>> the
>> >> JS version to use getComputedStyle.  I think it will be cleaner to
>> >> abstract the differences between SWF and JS in the ValuesManager and
>> allow
>> >> for different IValuesImpls to have different levels of sophistication
>> for
>> >> SWF.
>> >>
>> >> Right now, our "FlexibleChild" layouts are not factoring in margins
>> >> correctly.
>> >>
>> >> Thoughts?
>> >> -Alex
>> >>
>> >>
>> >
>> >
>> > --
>> > Carlos Rovira
>> > http://about.me/carlosrovira
>>
>>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: Refactoring Layouts

[Piotr Zarzycki]

I would also not go with the assumption that Grid will/can replace Flex
box. It's just different system for layouts. They can both work well
together. IMO we didn't even get out all possibilities of Flex Box, so
getting on board Grid is a lot of work. I was thinking during my work on
website to create some set of layouts which utilize Flex Box, but it ends
up that easier to me was just create css class.

Thanks, Piotr

2018-02-26 9:31 GMT+01:00 Harbs :

> Yes. Grid is better than Flexbox for most things, but going with grid
> really depends on what browsers we’re supporting.
>
> IE 10 and 11 do support grid, but their support for grid is based on an
> old spec. Edge got support for grid only recently.
>
> https://rachelandrew.co.uk/archives/2016/11/26/should-i-try-to-use-the-ie-
> implementation-of-css-grid-layout/  archives/2016/11/26/should-i-try-to-use-the-ie-implementation-of-css-grid-
> layout/>
> https://gridbyexample.com/browsers/ 
>
> > On Feb 26, 2018, at 9:43 AM, Carlos Rovira 
> wrote:
> >
> > Hi Alex,
> >
> > two things here:
> >
> > 1) while reading about css layouts seems Grid system is the most
> > sophisticated one and is better than flexbox, so I think we should change
> > to that since flex box does not support some layouts and Grid seems the
> > future and more like what we had in flex
> >
> > 2) yesterday making a simple blog example I put a vertical layout in a
> view
> > and a simple Js:button in SWF version button gets all the horizontal
> space
> > while in js is not affected. I think this differences must be removed
> since
> > if we post some example with both versions, both must be visuals equal
> (as
> > much as we can), but this difference is huge
> >
> >
> > 2018-02-26 6:39 GMT+01:00 Alex Harui :
> >
> >> Hi,
> >>
> >> Time for another refactoring of layout.  My goal for this round is to
> move
> >> the border/padding/margin calculations into the ValuesManager, and get
> the
> >> JS version to use getComputedStyle.  I think it will be cleaner to
> >> abstract the differences between SWF and JS in the ValuesManager and
> allow
> >> for different IValuesImpls to have different levels of sophistication
> for
> >> SWF.
> >>
> >> Right now, our "FlexibleChild" layouts are not factoring in margins
> >> correctly.
> >>
> >> Thoughts?
> >> -Alex
> >>
> >>
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: Refactoring Layouts

[Harbs]

Yes. Grid is better than Flexbox for most things, but going with grid really 
depends on what browsers we’re supporting.

IE 10 and 11 do support grid, but their support for grid is based on an old 
spec. Edge got support for grid only recently.

https://rachelandrew.co.uk/archives/2016/11/26/should-i-try-to-use-the-ie-implementation-of-css-grid-layout/
 

https://gridbyexample.com/browsers/ 

> On Feb 26, 2018, at 9:43 AM, Carlos Rovira  wrote:
> 
> Hi Alex,
> 
> two things here:
> 
> 1) while reading about css layouts seems Grid system is the most
> sophisticated one and is better than flexbox, so I think we should change
> to that since flex box does not support some layouts and Grid seems the
> future and more like what we had in flex
> 
> 2) yesterday making a simple blog example I put a vertical layout in a view
> and a simple Js:button in SWF version button gets all the horizontal space
> while in js is not affected. I think this differences must be removed since
> if we post some example with both versions, both must be visuals equal (as
> much as we can), but this difference is huge
> 
> 
> 2018-02-26 6:39 GMT+01:00 Alex Harui :
> 
>> Hi,
>> 
>> Time for another refactoring of layout.  My goal for this round is to move
>> the border/padding/margin calculations into the ValuesManager, and get the
>> JS version to use getComputedStyle.  I think it will be cleaner to
>> abstract the differences between SWF and JS in the ValuesManager and allow
>> for different IValuesImpls to have different levels of sophistication for
>> SWF.
>> 
>> Right now, our "FlexibleChild" layouts are not factoring in margins
>> correctly.
>> 
>> Thoughts?
>> -Alex
>> 
>> 
> 
> 
> -- 
> Carlos Rovira
> http://about.me/carlosrovira

Re: Refactoring Layouts

[Piotr Zarzycki]

Hi Alex,

How actually it will looks like. The getComputedStyle will return object
which contains all border, padding etc. ?

Thanks, Piotr

2018-02-26 6:39 GMT+01:00 Alex Harui :

> Hi,
>
> Time for another refactoring of layout.  My goal for this round is to move
> the border/padding/margin calculations into the ValuesManager, and get the
> JS version to use getComputedStyle.  I think it will be cleaner to
> abstract the differences between SWF and JS in the ValuesManager and allow
> for different IValuesImpls to have different levels of sophistication for
> SWF.
>
> Right now, our "FlexibleChild" layouts are not factoring in margins
> correctly.
>
> Thoughts?
> -Alex
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: Refactoring Layouts

[Alex Harui]

On 2/25/18, 11:43 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
 wrote:

>Hi Alex,
>
>two things here:
>
>1) while reading about css layouts seems Grid system is the most
>sophisticated one and is better than flexbox, so I think we should change
>to that since flex box does not support some layouts and Grid seems the
>future and more like what we had in flex

I attended an introduction to CSS Grid.  My takeaway wasn't that we would
replace Flexbox, but just offer Grid-based layouts as well.
>
>2) yesterday making a simple blog example I put a vertical layout in a
>view
>and a simple Js:button in SWF version button gets all the horizontal space
>while in js is not affected. I think this differences must be removed
>since
>if we post some example with both versions, both must be visuals equal (as
>much as we can), but this difference is huge

Yep, there are plenty of bugs on the SWF side that need fixing.  The first
priority is to get the bounding boxes as close to the same as we can, then
worry about the actually pixels.

Of course, I could be wrong...
-Alex
>
>
>2018-02-26 6:39 GMT+01:00 Alex Harui :
>
>> Hi,
>>
>> Time for another refactoring of layout.  My goal for this round is to
>>move
>> the border/padding/margin calculations into the ValuesManager, and get
>>the
>> JS version to use getComputedStyle.  I think it will be cleaner to
>> abstract the differences between SWF and JS in the ValuesManager and
>>allow
>> for different IValuesImpls to have different levels of sophistication
>>for
>> SWF.
>>
>> Right now, our "FlexibleChild" layouts are not factoring in margins
>> correctly.
>>
>> Thoughts?
>> -Alex
>>
>>
>
>
>-- 
>Carlos Rovira
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2
>Fcarlosrovira=02%7C01%7Caharui%40adobe.com%7C0d7bd37d902344f6ab0608d5
>7cecb787%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636552278487751536
>data=S7MDY5nSoKg1mwuGhKgxqMHY8MlsQfQf3HDYkyMK5JY%3D=0

Re: Refactoring Layouts

[Carlos Rovira]

Hi Alex,

two things here:

1) while reading about css layouts seems Grid system is the most
sophisticated one and is better than flexbox, so I think we should change
to that since flex box does not support some layouts and Grid seems the
future and more like what we had in flex

2) yesterday making a simple blog example I put a vertical layout in a view
and a simple Js:button in SWF version button gets all the horizontal space
while in js is not affected. I think this differences must be removed since
if we post some example with both versions, both must be visuals equal (as
much as we can), but this difference is huge


2018-02-26 6:39 GMT+01:00 Alex Harui :

> Hi,
>
> Time for another refactoring of layout.  My goal for this round is to move
> the border/padding/margin calculations into the ValuesManager, and get the
> JS version to use getComputedStyle.  I think it will be cleaner to
> abstract the differences between SWF and JS in the ValuesManager and allow
> for different IValuesImpls to have different levels of sophistication for
> SWF.
>
> Right now, our "FlexibleChild" layouts are not factoring in margins
> correctly.
>
> Thoughts?
> -Alex
>
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Refactoring Layouts

[Alex Harui]

Hi,

Time for another refactoring of layout.  My goal for this round is to move
the border/padding/margin calculations into the ValuesManager, and get the
JS version to use getComputedStyle.  I think it will be cleaner to
abstract the differences between SWF and JS in the ValuesManager and allow
for different IValuesImpls to have different levels of sophistication for
SWF.

Right now, our "FlexibleChild" layouts are not factoring in margins
correctly.

Thoughts?
-Alex