Hi all,
There have been some new featuresand critical bug fixes added to master since
0.13.0 release, which makes SamzaStandalone features more stable. It is now
good enough to warrant a new minorrelease. We will continue to test for
stability and performance in the next fewweeks.
Here are the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53297/#review155753
---
Ship it!
Ship It!
- Fred Ji
On Nov. 11, 2016, 12:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53326/#review154458
---
Ship it!
Ship It!
- Fred Ji
On Nov. 1, 2016, 6:40 a.m
326/#comment223863>
I would recommend keeping the checkstyle on and fixing the incompatibility
issue so that checkstyle plugin can caputre the style issue in the build
process. If we disable it, some of the style issues (although minor) may be
hidden and be merged into master.
- Fred Ji
/SamzaMonitorService.java
(line 71)
<https://reviews.apache.org/r/53002/#comment222498>
nit: this line of comment is not needed since log warn is very clear.
- Fred Ji
On Oct. 18, 2016, 10:53 p.m., Shanthoosh Venkataraman
ps://reviews.apache.org/r/50619/#review144968
-------
On July 29, 2016, 10:24 p.m., Fred Ji wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/#review144420
---
Ship it!
Ship It!
- Fred Ji
On Aug. 2, 2016, 12:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50527/#review144228
---
Ship it!
Ship It!
- Fred Ji
On July 29, 2016, 5:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50590/#review144226
---
Ship it!
Ship It!
- Fred Ji
On July 29, 2016, 12:34 a.m
614/#comment210226>
[Info] why not keep it as latest?
- Fred Ji
On July 29, 2016, 9:37 p.m., Navina Ramesh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
-0c45bf91bcaa__KeyValueStorageEngineMetricsFromJconsole.png
Thanks,
Fred Ji
follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified
the changes and links on localhost server.
Thanks,
Fred Ji
build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified
the changes and links on localhost server.
Thanks,
Fred Ji
l, with Navina's help. Thanks!
- Fred
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143173
---
On July 22, 2016, 11:06 p.m., Fred Ji wrote:
>
> -
checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified
the changes and links on localhost server.
Thanks,
Fred Ji
:
https://reviews.apache.org/r/50317/#review143165
---
On July 22, 2016, 12:26 a.m., Fred Ji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing (updated)
---
Basic unit tests and checkstyleTest passed.
1. Run unit tests:
./gradlew clean build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Thanks,
Fred Ji
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md
af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing
---
Thanks,
Fred Ji
Hi Ankita,
The command "./gradlew publishToMavenLocal" is to be run in Samza project,
not "hello-samza" project. In your case, you may just skip this command
since "bin/grid bootstrap" would already build a Samza package for you
(hello-samza/deploy/samza).
Thanks,
Fred
On Thu, Jul 21, 2016 at
ews.apache.org/r/49877/#comment207454>
Do we want to log if match is not found? This might help us to capture the
issue if the format is changed for the path somehow in the future.
- Fred Ji
On July 12, 2016, 12:17 a.m., Jagadish Venkatraman wrote:
>
>
> On July 12, 2016, 12:15 a.m., Fred Ji wrote:
> > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java,
> > line 92
> > <https://reviews.apache.org/r/48356/diff/7/?file=1441779#file1441779line92>
> >
> > Maybe if(!StringUtils.
> On July 12, 2016, 12:15 a.m., Fred Ji wrote:
> > samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java,
> > line 92
> > <https://reviews.apache.org/r/48356/diff/7/?file=1441779#file1441779line92>
> >
> > Maybe if(!StringUtils.
rg/r/48356/#comment207196>
I know it is from previous code, but do you mind explaining or putting a
comment regarding what -1L means here?
- Fred Ji
On July 12, 2016, midnight, Navina Ramesh wrote:
>
> ---
> This is an auto
23 matches
Mail list logo
