Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

s.apache.org/r/52168/#comment241407> rename this as getJobModle. In javadoc, make clear there is no side effect. - Xinyu Liu On Feb. 16, 2017, 6:26 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated

Re: [DISCUSS] SAMZA-1141 - Apache Samza Development Process Improvements

+1 on this proposal too. Could you actually put this proposal as the first SEP (like SEP-0), so it serves an example of how it will look like in practice? Xinyu On Tue, Mar 14, 2017 at 3:34 PM, Navina Ramesh wrote: > Just to clarify: The proposal for code and design process change is > attached

Re: Understanding metrics

Hi, Ankit, When running your job in multithreading, block-ns here actually includes the process_ns. This is because after your task.process() is submitted to the thread pool, the run loop thread will be blocked until the process() is complete for one of the task. It's interesting that block-ns (0.

Re: Review Request 56928: SAMZA-1099: Changes to hello-samza (latest branch) for the 0.12.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56928/#review166399 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 3:45 p.m

Re: Review Request 56909: SAMZA-1099: Changes to hello-samza (master branch) for the 0.12.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56909/#review166398 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 3:55 p.m

Re: Review Request 56913: SAMZA-1099: Documentation updates for Samza 0.12 release (for master branch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56913/#review166396 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 7:29 p.m

Re: Review Request 56911: SAMZA-1099: Documentation updates for Samza 0.12 release (for 0.12.0 branch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56911/#review166393 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 4:27 p.m

Re: [VOTE] Apache Samza 0.12.0 RC2

Ran build, checkAll and integration tests. All passed. +1 non-binding. Thanks, Xinyu On Wed, Feb 8, 2017 at 4:18 PM, Boris S wrote: > Cloned the release and ran build, test and checkAll.sh > All passed. > Verified MD5 and the signature. > Got warning - "this key is not certified with a trusted

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

lt;https://reviews.apache.org/r/52570/#comment234349> please link java doc to SingleFileHdfsReader, instead of putting the file name here. - Xinyu Liu On Jan. 24, 2017, 2:07 a.m., Hai Lu wrote: > > --- > This is an automat

Re: [DISCUSS] Samza 0.12.0 release

+1 on the new release. Thanks, Xinyu On Fri, Dec 23, 2016 at 2:50 PM, Yi Pan wrote: > Yep! Thanks for pointing it out! @Shanthoosh, can you update the list > accordingly? > > Thanks! > > On Fri, Dec 23, 2016 at 2:42 PM, Fred Ji wrote: > > > I think we also would like to put this one in the pot

Re: Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

d the link in versioned/index.html, something like "Reading from HDFS" before the link of "Writing to HDFS" - Xinyu Liu On Oct. 5, 2016, 8:54 p.m., Hai Lu wrote: > > --- > This is an automatically generated e-m

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

gradlew build Tested in the yarn hadoop cluster with different kinds of jobs. File Attachments hdfs performance https://reviews.apache.org/media/uploaded/files/2016/11/02/c05007fe-2fdd-4c8c-b5ef-b7862dea13b2__hdfs_perf.png Thanks, Xinyu Liu

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

does this. I think you can use it > > here. > > Xinyu Liu wrote: > I was thinking about using it at first. But the HighResolutionClock has > two functions, nanoTime() and sleep(). The second method does not fit here > for my usage. The other benefit of using a single method int

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

ink we should ever be creating a default new SerdeManager > > just for this class. Same for SystemConsumerMetrics (and other places where > > this pattern is used for objects). Constants are fine. > > Xinyu Liu wrote: > I think these are created as default for the t

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

3b2__hdfs_perf.png Thanks, Xinyu Liu

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

jobs. File Attachments hdfs performance https://reviews.apache.org/media/uploaded/files/2016/11/02/c05007fe-2fdd-4c8c-b5ef-b7862dea13b2__hdfs_perf.png Thanks, Xinyu Liu

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

I look for slowness in samza. String manupulation becomes performance problems when everything is under 1 microsecond. - Xinyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review15

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

/apache/samza/system/SystemConsumers.scala, > > line 108 > > <https://reviews.apache.org/r/53282/diff/1/?file=1548713#file1548713line108> > > > > Same here, not sure if we should use the default. Same as above. > On Nov. 2, 2016, 7:57 p.m., Prateek Maheshwari

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

enerated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review154611 ------- On Nov. 2, 2016, 5:56 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

che.org/media/uploaded/files/2016/11/02/c05007fe-2fdd-4c8c-b5ef-b7862dea13b2__hdfs_perf.png Thanks, Xinyu Liu

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

when the window is closed (early or late tigger?) or can late trigger happens before early trigger? Seems the early and late meanings are loosely defined without a reference. Happy to talk about this more. - Xinyu Liu On Oct. 4, 2016, 12:45 a.m., Yi Pan (Data Infrastructure) wrote: >

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

first. Please take a look at my comments after it. Thanks. - Xinyu Liu On Oct. 31, 2016, 11:27 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53326: SAMZA-1045 Move classes from samza-operator/api into samza-api.

mingSystemMessage is the one used in all operator tasks. - Xinyu Liu On Oct. 31, 2016, 11:27 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 53282: SAMZA-1043: Samza performance improvements

Factory.scala c975893a42689732c39c39600fecacee843bf9d6 Diff: https://reviews.apache.org/r/53282/diff/ Testing --- ./gradlew build Tested in the yarn hadoop cluster with different kinds of jobs. Thanks, Xinyu Liu

Re: Review Request 53027: SAMZA-1017 - Added disk quota based throttling to AsyncRunLoop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53027/#review153300 --- Ship it! Ship It! - Xinyu Liu On Oct. 19, 2016, 6:30 p.m

Review Request 53028: SAMZA-1040: Revert the ClassLoaderHelper change in SamzaContainer

Diff: https://reviews.apache.org/r/53028/diff/ Testing --- Tested by AsyncStreamTask jobs. Thanks, Xinyu Liu

Review Request 53004: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

snapshot build to mvn local and build hello-samza and runs fine. Thanks, Xinyu Liu

Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

hello-samza and runs fine. Thanks, Xinyu Liu

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

well? Thanks for the catch! - Xinyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52960/#review153000 --- On Oct

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

hanks, Xinyu Liu

Review Request 52962: SAMZA-1029: Prepare release candidate for 0.11.0

942329e968bb02886df44b680bea8f75a221a289 docs/startup/download/index.md 6a0c670bca01e01b9d8a73482af35cc144f1d524 docs/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2 Diff: https://reviews.apache.org/r/52962/diff/ Testing --- local website. Thanks, Xinyu

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

/startup/hello-samza/versioned/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2 gradle.properties f032b745a7ceae319996314f22c16fe0b664e705 Diff: https://reviews.apache.org/r/52960/diff/ Testing --- Local website Thanks, Xinyu Liu

Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

/index.md 8baacd390d41c5c87a426d63eec9ce5028de0cc2 gradle.properties f032b745a7ceae319996314f22c16fe0b664e705 Diff: https://reviews.apache.org/r/52960/diff/ Testing --- Local website Thanks, Xinyu Liu

Re: Java code examples for deploying samza job into YARN

Hi, nimit, You can use this tutorial as an example of deploying Samza job in a multi-node yarn cluster. Please note the run-job.sh script needs to be run in the resource manager (RM) node of the Yarn cluster. In this exampl

[RESULT][VOTE] Apache Samza 0.11.0 RC2

The vote of 0.11.0 RC2 has been more than 72 hours and we got +1 (binding) x 3 and +1 (non-binding) x 3. Samza 0.11.0 officially passed the VOTE! Thanks everyone! Thanks! Xinyu

Re: [VOTE] Apache Samza 0.11.0 RC2

nd the signature. > > Boris. > > On Mon, Oct 10, 2016 at 4:07 PM, xinyu liu wrote: > > > Hey all, > > > > This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to > > everyone who has contributed to this release. We are very glad to see > some &g

[CANCEL] [VOTE] Apache Samza 0.11.0 RC1

An issue was found in (SAMZA-1005 ) which broke the newly added AsyncStreamTask support. Cancel this vote. Thanks, Xinyu

[CANCEL] [VOTE] Apache Samza 0.11.0 RC0

Samza version issue in the integration tests was reported during the vote, so cancel this release candidate vote. Thanks, Xinyu

[VOTE] Apache Samza 0.11.0 RC2

Hey all, This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to everyone who has contributed to this release. We are very glad to see some new contributors in this release. Note: this release candidate reverted the changes that caused the AsyncStreamTask to break in 0.11.0 RC1.

[VOTE] Apache Samza 0.11.0 RC1

Hey all, This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to everyone who has contributed to this release. We are very glad to see some new contributors in this release. Note: this release candidate fixed the version issue in integration test previously found in 0.11.0 RC0. T

Re: RecordTooLargeException recovery

Hi, David, For your questions: 1) In this case Samza recovered but the changelog message was lost. In 0.10.1 KafkaSystemProducer has a race condition: there is small chance the later send success might override the previous failure. The bug is fixed in the upcoming 0.11.0 release (SAMZA-1019). Th

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

Subject correction: [VOTE] Apache Samza 0.11.0 RC0. Thanks, Xinyu On Fri, Sep 30, 2016 at 12:00 PM, xinyu liu wrote: > Hey all, > > This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to > everyone who has contributed to this release. We are very glad to se

[DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

and then please vote: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) +1 from my side for the release. Cheers! Xinyu Liu

Re: Review Request 52436: SAMZA-1016: Fix support for joint compilation of scala and java sources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52436/#review151060 --- Ship it! Good catch! Thanks for fixing this! - Xinyu Liu On

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

- Xinyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150948 ------- On Sept. 29, 2016, 9:23 p.m., Xinyu Liu wrote: > > --

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

in jobs deployed in Yarn cluster. Thanks, Xinyu Liu

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

ously saved exception instead of > > no-oping the flush? Is the user expected to handle this? If so, should > > document why & how. > > Prateek Maheshwari wrote: > Nvm this, I think the intention is to throw in the next operation after a > send error callback. I added th

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

iews.apache.org/r/52403/#review150907 --- On Sept. 29, 2016, 9 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

/diff/ Testing --- Tested in jobs deployed in Yarn cluster. Thanks, Xinyu Liu

Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a Diff: https://reviews.apache.org/r/52403/diff/ Testing --- Tested in jobs deployed in Yarn cluster. Thanks, Xinyu Liu

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

d0e59918fc4f9303097d334a49ad1394196b6789 docs/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 Diff: https://reviews.apache.org/r/52401/diff/ Testing --- Thanks, Xinyu Liu

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

) --- Thanks, Xinyu Liu

Review Request 52402: SAMZA-1020: Remove some deprecated interfaces from 0.10 version

ea10cae82f2900c185c8c814f48dc02bbcb45621 samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 Diff: https://reviews.apache.org/r/52402/diff/ Testing --- ./gradlew build Thanks, Xinyu Liu

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- ./gradlew build Thanks, Xinyu Liu

Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 Diff: https://reviews.apache.org/r/52401/diff/ Testing --- ./gradlew build Thanks, Xinyu Liu

Review Request 52400: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 Diff: https://reviews.apache.org/r/52400/diff/ Testing --- Thanks, Xinyu Liu

Re: Review Request 52140: added docs for split deployment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/#review150500 --- Ship it! Ship It! - Xinyu Liu On Sept. 27, 2016, 12:58 a.m

Re: Review Request 52140: added docs for split deployment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/#review150101 --- Ship it! Ship It! - Xinyu Liu On Sept. 22, 2016, 11:38 p.m

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

docs/learn/tutorials/versioned/index.md ca2b08fb02a83f72f804c4059f258253c046a1b6 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 52140: added docs for split deployment

ease, can we use 0.11.0 acrose all examples here? docs/learn/documentation/versioned/operations/split-deployment.md (line 113) <https://reviews.apache.org/r/52140/#comment217715> I think we need to mention the framework libraries needed to be placed to each node in the cluster. -

Re: Review Request 52133: reopen a Kafka system producer if send called again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52133/#review149925 --- Ship it! Ship It! - Xinyu Liu On Sept. 21, 2016, 8:36 p.m

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

() will always be invoked from a single thread (for all tasks). The reason being asynchronous calls will not require threads blocking on the calls. The callback can be invoked from multiple threads. Samza controls when to invoke processAsync()/window()/commit() for each task. - Xinyu -

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

.html 54c52981c3055b398ee60af50eeaf2592ed0e64f docs/learn/tutorials/versioned/index.md b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

block_ns are high at the same time. Diffs - samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

ck_ns are high at the same time. Diffs - samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148826 ----------- On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote: > > --- > This

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

sit: https://reviews.apache.org/r/50174/#review148824 --- On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

.html 54c52981c3055b398ee60af50eeaf2592ed0e64f docs/learn/tutorials/versioned/index.md b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 51934: reopen a Kafka system producer if send called again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51934/#review149131 --- Ship it! Thanks for the fix! - Xinyu Liu On Sept. 15, 2016

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

Good catch! Thanks! - Xinyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148041 --- On Sept

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

sting --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 51819: SAMZA-1015 Add support for streams, Lambdas and other JDK 8 like features in checkstyle

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51819/#review148585 --- Ship it! Ship It! - Xinyu Liu On Sept. 12, 2016, 7:28 p.m

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

/SystemConsumers.scala (line 207) <https://reviews.apache.org/r/51346/#comment215701> nit: no ";" at the end for scala - Xinyu Liu On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatic

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

1) <https://reviews.apache.org/r/51346/#comment215659> seems this is only needed for unit test. Please move the code to scala test. - Xinyu Liu On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote: > > --- > This is an

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

r job.container.thread.pool.size, task.callback.timeout.ms and > > task.max.concurrency This config is pretty awkward (so is the name). It's just for fallback to old runloop if there is any issue with the new AsyncRunLoop. So I don't expect users to set it no

Re: [DISCUSS] End of Stream Feature in Samza

It's very exciting that Samza is adding support of bounded input streams. Nice write-up of different scenarios and options. Look forward to having this feature work with the upcoming HDFS consumer! Thanks, Xinyu On Tue, Aug 30, 2016 at 12:09 PM, Jagadish Venkatraman < jagadish1...@gmail.com> wrot

Re: Review Request 51252: SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask

/main/scala/org/apache/samza/container/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b28b6422 Diff: https://reviews.apache.org/r/51252/diff/ Testing --- gradlew clean build. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

use AsyncStreamTask by default? > > Esp. on jobs that don't need any async processing. > > Why is the default value false? > > > > If users upgrade to the new version and automatically start using > > multithreaded execution, will they see any performance impact? The default of new AsyncRunLoop is still

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

1 once AsyncRunLoop is fully stablized. - Xinyu Liu On Aug. 30, 2016, 12:49 a.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

ed since no invoke anymore, right? - Xinyu Liu On Aug. 29, 2016, 11:47 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

eam. Let's chat offline. - Xinyu Liu On Aug. 25, 2016, 11:52 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

syncRunLoop.java (line 605) <https://reviews.apache.org/r/51346/#comment213289> if(endOfStream) ... samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala (line 355) <https://reviews.apache.org/r/51346/#comment213294> No need for this logic since AsyncRunLoop won&#x

[DISCUSS] Samza 0.11.0 release

Hi, All, There have been quite a lot of new features added to master since 0.10 release to warrant a new major release. At LinkedIn, we've done functional and performance testing against master in the past weeks, and deployed jobs with the latest build in production. We will continue to test for s

Re: Review Request 51252: SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask

/apache/samza/container/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b28b6422 Diff: https://reviews.apache.org/r/51252/diff/ Testing (updated) --- gradlew clean build. Thanks, Xinyu Liu

Review Request 51252: SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask

/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b28b6422 Diff: https://reviews.apache.org/r/51252/diff/ Testing --- Thanks, Xinyu Liu

Review Request 51225: SAMZA-1003: Restore lazy init for kafka system producer

/diff/ Testing --- Tested in local deployment and the system producer defined but not used was not be inited. Thanks, Xinyu Liu

Re: Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50682/#review144417 --- Ship it! +1. thanks for the quick fix! - Xinyu Liu On Aug

Re: Review Request 50670: SAMZA-991: Continue to report SamzaAppMasterMetrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50670/#review144393 --- Ship it! +1 - Xinyu Liu On Aug. 1, 2016, 10:21 p.m

Re: Review Request 50670: SAMZA-991: Continue to report SamzaAppMasterMetrics

ations. Could you please take a look? Thanks. - Xinyu Liu On Aug. 1, 2016, 9:07 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: [DISCUSS] [VOTE] Apache Samza 0.10.1 RC0

+1 (non-binding). Thanks, Xinyu On Mon, Aug 1, 2016 at 11:41 AM, Jagadish Venkatraman < jagadish1...@gmail.com> wrote: > Thanks for driving this release.+1 approve (non-binding) > > Thanks, > Jagadish > > On Mon, Aug 1, 2016 at 11:39 AM, Navina Ramesh > > wrote: > > > Hey all, > > > > This is a

Re: Review Request 50527: SAMZA-970: fix integration tests

/diff/ Testing --- run integration tests and now they work fine. Thanks, Xinyu Liu

Review Request 50590: Update jackson version in hello-samza to match samza

://reviews.apache.org/r/50590/diff/ Testing --- Tested by running hello-world and check the output. Thanks, Xinyu Liu

Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

scala 75ba8af7cdda6b297abaa3dbb99c98b406e31f88 Diff: https://reviews.apache.org/r/50588/diff/ Testing --- tested by unit tests and verifed also in hello-samza jobs. Thanks, Xinyu Liu

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

#x27;s better to have: Logging.info((message, startupLog:boolean=false) => Any) That way we can use info log for both startup and non startup logging, and potentially adding it for debug and error in the future too. - Xinyu Liu On July 28, 2016, 8:

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

9> Please take a look at this again. - Xinyu Liu On July 27, 2016, 11:05 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

<    1   2   3   >