Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Roger Hoover
On July 29, 2015, 8:42 a.m., Dan Harvey wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 116 https://reviews.apache.org/r/36815/diff/6/?file=1024157#file1024157line116 Should we add a Samza specifc message, then

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Roger Hoover
Thanks, Yi! On Wed, Jul 29, 2015 at 12:16 PM, Yi Pan nickpa...@gmail.com wrote: Hi, Roger, I am testing the patch now. Will update the JIRA soon. Thanks! -Yi On Wed, Jul 29, 2015 at 12:11 PM, Roger Hoover roger.hoo...@gmail.com wrote: Thank you, Dan. I think we're ready to merge.

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Dan Harvey
On July 29, 2015, 8:42 a.m., Dan Harvey wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 116 https://reviews.apache.org/r/36815/diff/6/?file=1024157#file1024157line116 Should we add a Samza specifc message, then

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Roger Hoover
Thank you, Dan. I think we're ready to merge. Can one of the Samza committers please take a look? On Wed, Jul 29, 2015 at 11:31 AM, Dan Harvey danharve...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ On July 29th, 2015,

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Yi Pan
Hi, Roger, I am testing the patch now. Will update the JIRA soon. Thanks! -Yi On Wed, Jul 29, 2015 at 12:11 PM, Roger Hoover roger.hoo...@gmail.com wrote: Thank you, Dan. I think we're ready to merge. Can one of the Samza committers please take a look? On Wed, Jul 29, 2015 at 11:31 AM,

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Dan Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93413 ---

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Roger Hoover
On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 149 https://reviews.apache.org/r/36815/diff/4/?file=1024086#file1024086line149 Quick question: Is it

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Roger Hoover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 29, 2015, 6:22 a.m.) Review request for samza and Dan Harvey.

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Yi Pan (Data Infrastructure)
On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 149 https://reviews.apache.org/r/36815/diff/4/?file=1024086#file1024086line149 Quick question: Is it

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-28 Thread Roger Hoover
On July 28, 2015, 7:36 a.m., Dan Harvey wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 115 https://reviews.apache.org/r/36815/diff/3/?file=1023400#file1023400line115 could switch these around so you've got

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-28 Thread Roger Hoover
On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, line 149 https://reviews.apache.org/r/36815/diff/4/?file=1024086#file1024086line149 Quick question: Is it

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-28 Thread Roger Hoover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 28, 2015, 6:13 a.m.) Review request for samza. Changes ---

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-25 Thread Roger Hoover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 25, 2015, 4:48 p.m.) Review request for samza. Repository: