Re: [sc-dev] Data loss in shared spreadsheet

2008-10-31 Thread Thomas Benisch
Hi Sophie, we will try to fix those issues for OOo 3.1. Thomas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [sc-dev] Some questions about the exporting

2008-05-19 Thread Thomas Benisch
Hi Gao, are you sure? When looking at the content of a saved document I see, that the new filter conditions were written to the file. Therefore the problem must be the import, not the export. Nevertheless debugging your new methods in the sc module during import is the right approach. Thomas

Re: [sc-dev] Something about Data Filter

2008-04-30 Thread Thomas Benisch
Hi Gao, gaozm wrote: When I want to use the XSheetFilterDescriptor2(setFilterFields2() and getFilterFields2()) in sc/source/ui/vba/vbarange.cxx file, I find a bit difficult, so I hope you can give me some help, Thank you. I think the strategy is the same as for those changes you've

Re: [sc-dev] Something about to make a new patch

2008-04-22 Thread Thomas Benisch
Hi Gao, It's unlucky for me to find you didn't attend the IRC meeting. I'm sorry, but I had several days off. I sent one screenshot of testdoc to you a few days before. Can you reproduce the crash phenomenon? No, even with your test document I cannot reproduce your crashes. Did

Re: [sc-dev] Something about the XML export/import

2008-03-12 Thread Thomas Benisch
Hi Gao, you cannot simply use the type ::com::sun::star::sheet::TableFilterField2 instead of the type ::com::sun::star::sheet::TableFilterField, e.g. as parameter for the method ScXMLExportDatabaseRanges::WriteCondition(). At that point you have to start to write code which handles the type

Re: [sc-dev] A new patch about the XML import/export

2008-02-08 Thread Thomas Benisch
Hi Gao, please see my comments in the issue. Thomas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [sc-dev] Something about the UNO API

2008-01-22 Thread Thomas Benisch
Hi Gao, gaozm wrote: Hello Thomas: As you know that I have added three files to extend the UNO API. After I added the code to the XML import/export, there are still something wrong when compiling. Do you think whether I need add some other files to extend the UNO API? Such as:

Re: [sc-dev] Extend the UNO API

2008-01-18 Thread Thomas Benisch
Hi Gao, gaozm wrote: Hello Thomas: Thank you for your comments. Following your advices, I have modified the three files. Please check it and give me some advice. Thank you! :-) Best Regards! Gao Zemin please see my comments in the issue. Thomas

Re: [sc-dev] One question about i35579

2008-01-18 Thread Thomas Benisch
Cor Nouws wrote: Thomas Benisch wrote (17-1-2008 10:37) Lvyue wrote: I have combined the two code branches, please check patch2 of i35579. this patch is fine, thanks for this nice work. +1 :-) Target ?? Just to clarify. This part of the patch if fine, but the code for exporting

Re: [sc-dev] Extend the UNO API

2008-01-17 Thread Thomas Benisch
Hi Gao, gaozm wrote: Hello Thomas: I have added three files to extend the UNO API, please check it, do you think whether what I do is right? If not, I hope you give me some advice. Thank you! adding the new IDL files is the right direction. Please see my comments in the issue. Thomas

Re: [sc-dev] One question about i35579

2008-01-15 Thread Thomas Benisch
Hi Lvyue, Lvyue wrote: Hi Thomas, Thank you for your detailed comments in issue #35579#. I can consolidate code by combining the SC_EQUAL ... code branch and the SC_CONTAINS ... code branch. But the SC_EQUAL ... code branch seems to have some connections with other functions, I don't know

Re: [sc-dev] Some work about Data Filter

2008-01-07 Thread Thomas Benisch
Please see my comments in issue #35579#. Thomas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [sc-dev] A patch about Data Filter

2007-12-19 Thread Thomas Benisch
Hi Gao, thanks for this patch. As Kohei already wrote, please attach the next iteration of the patch to issue #35579#. In addition also the specification needs to be updated. Although we work mainly with specifications as odt document, Kohei is right that wiki is also an accepted format. So it's

Re: [sc-dev] New features about Data Filter

2007-12-11 Thread Thomas Benisch
Hi Gao, gaozm wrote: The naming of the conditions doesn't seem to be the best choice, but Frank Loehmann will have a look at this issue and will propose some better names. I think we should wait for Frank Loehmann's reply, right? yes, for the final naming you should wait for Frank's reply.

Re: [sc-dev] New features about Data Filter

2007-12-07 Thread Thomas Benisch
In yesterday's Calc usability meeting we had some discussion about the specification. Let me summarize the current status. 1.1 New filter conditions All agreed that we want to have the additional filter conditions. The naming of the conditions doesn't seem to be the best choice, but Frank

Re: [sc-dev] Re: R / Calc Name ?

2007-08-29 Thread Thomas Benisch
4.) RooT = R-OpenOfiice Tool 4') ROOT I personally disfavor this one, as ROOT is a well-known data analysis tool used in particle physics. Thomas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail:

Re: [sc-dev] i20496 : Enhanced formula input

2007-08-21 Thread Thomas Benisch
Please note, that I updated the specification at http://specs.openoffice.org/calc/ease-of-use/Enhanced_Formula_Input.odt Although the question which user input is converted into a formula is quite controversial, I tried to include the most important comments into the specification. In a

Re: [sc-dev] Re: dev Digest 8 Aug 2007 18:57:14 -0000 Issue 599

2007-08-10 Thread Thomas Benisch
Hi Muthu, Have you tried the patch that I have attached (in issue 20496)? as I have issue #20496 on my list I propose that I will have a look at the patch, probably in a few days. Thomas - To unsubscribe, e-mail: [EMAIL

Re: [sc-dev] i20496 : Enhanced formula input

2007-08-10 Thread Thomas Benisch
Hi Eike, the examples in the spec basically follow the Excel behavior. You made some good points and it seems, that the Excel behavior is not always wanted. Unfortunately Frank is on vacation until end of August, but the specification definitely needs to be reworked. From an implementation

Re: [sc-dev] Re: [sc-features] changed/CWS dr55 : Default print options in Calc

2007-08-02 Thread Thomas Benisch
PA Galmes wrote: There is no link to a sepc, is it missing? The iTeam agreed, that this change doesn't need a specification. All necessary information is available in the feature announcement. Thomas - To unsubscribe,

Re: [sc-dev] User Visible UI for Insertion of Cells in a Spreadsheet via Drag Drop

2007-07-26 Thread Thomas Benisch
PA Galmes wrote: Not all of the feature is accessible through menus/right-click. For example, the sections: 1.3.2.1 Insert Move DD to Same Row/Column 1.4 Insert Move Drop of Whole Columns in Same Table do not currently work using what you described, or am I wrong? No, you're right. The

Re: [sc-dev] User Visible UI for Insertion of Cells in a Spreadsheet via Drag Drop

2007-07-26 Thread Thomas Benisch
PA Galmes wrote: Thus, I think that the paste special behavior should be adapted to reflect your changes as obviously, they are what user expects. Should we create an issue for that ? Yes, you can write an issue. Please see also issues #21280 Automatic Insert (shift down or shift right) of

Re: [sc-dev] User Visible UI for Insertion of Cells in a Spreadsheet via Drag Drop

2007-07-25 Thread Thomas Benisch
PA Galmes wrote: Hello, I just read the new spec for inserting data in OOo (Insertion of Cells in a Spreadsheet via Drag Drop). *Specification URL* --- http://specs.openoffice.org/calc/ease-of-use/Insertion_of_Cells.odt This new feature is based on the use of the DD and the

Re: [sc-dev] Re: [specs-announce] Extend AutoSum Capabilities in Calc

2007-06-05 Thread Thomas Benisch
PA Galmes wrote: On 6/4/07, Thomas Benisch [EMAIL PROTECTED] wrote: PA Galmes wrote: - What about selections with cells removed (ex : A1:D10 intersection C5) There's no special handling of such cases yet. I don't know which behaviour should be chosed. What do you think would

Re: [sc-dev] Re: [specs-announce] Extend AutoSum Capabilities in Calc

2007-06-01 Thread Thomas Benisch
PA Galmes wrote: Some more points to think about: - What about multi-selection using ctrl (ex 1: A2:A4 + D3:D5) ? - Will OOo calculate the result for each line/column? Yes, the result will be calculated for each selection separately. In your example the first result will be inserted into A5,