ngachung merged pull request #147:
URL: https://github.com/apache/incubator-sdap-nexus/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jasonmlkang opened a new pull request #147:
URL: https://github.com/apache/incubator-sdap-nexus/pull/147
Current data-inbounds-search algorithm would throw error `NexusPoint' object
has no attribute 'data_val'`. This is a quick fix to replace data_val to
data_vals in data-inbounds-search
ngachung merged pull request #146:
URL: https://github.com/apache/incubator-sdap-nexus/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tloubrieu-jpl merged pull request #145:
URL: https://github.com/apache/incubator-sdap-nexus/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tloubrieu-jpl merged pull request #50:
URL: https://github.com/apache/incubator-sdap-ingester/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tloubrieu-jpl commented on pull request #107:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/107#issuecomment-986064244
@ngachung @jjacob7734, I often have issues with 504 error on SDAP bigdata
and when it happens, I need to wait for SDAP to consume all the requests I
ngachung opened a new pull request #146:
URL: https://github.com/apache/incubator-sdap-nexus/pull/146
Even though for DOMS/CDMS we've only documented the matchup endpoints, the
OpenAPI spec isn't restricted to just matchup endpoints, so worth changing the
title.
--
This is an automated
tloubrieu-jpl opened a new pull request #145:
URL: https://github.com/apache/incubator-sdap-nexus/pull/145
The helm chart is updated to use the bitnami stable chart instead of the
incubator version previously.
The update requires the use of a specific docker solr image to have the
tloubrieu-jpl opened a new pull request #50:
URL: https://github.com/apache/incubator-sdap-ingester/pull/50
See ticket https://issues.apache.org/jira/browse/SDAP-359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tloubrieu-jpl merged pull request #144:
URL: https://github.com/apache/incubator-sdap-nexus/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jasonmlkang commented on pull request #48:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/48#issuecomment-972140635
@tloubrieu-jpl Updated the code to use strptime instead of regex
--
This is an automated message from the Apache Git Service.
To respond to the message,
tloubrieu-jpl opened a new pull request #144:
URL: https://github.com/apache/incubator-sdap-nexus/pull/144
See ticket https://issues.apache.org/jira/browse/SDAP-358
The correction has been initially found by @jjacob7734
--
This is an automated message from the Apache Git Service.
tloubrieu-jpl merged pull request #143:
URL: https://github.com/apache/incubator-sdap-nexus/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
joshgarde opened a new pull request #49:
URL: https://github.com/apache/incubator-sdap-ingester/pull/49
GitHub Actions build pipeline including current versions taken from current
DockerHub images.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jasonmlkang commented on pull request #48:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/48#issuecomment-966906135
@tloubrieu-jpl I had implemented a more generic way to parse date time from
file name. The commit is 92eb7dc. Please take a look
jjacob7734 merged pull request #46:
URL: https://github.com/apache/incubator-sdap-ingester/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tloubrieu-jpl commented on a change in pull request #48:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/48#discussion_r745816922
##
File path:
granule_ingester/granule_ingester/processors/TileSummarizingProcessor.py
##
@@ -27,17 +30,45 @@ class
tloubrieu-jpl commented on a change in pull request #48:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/48#discussion_r745807760
##
File path:
granule_ingester/granule_ingester/processors/TileSummarizingProcessor.py
##
@@ -27,17 +30,45 @@ class
tloubrieu-jpl opened a new pull request #143:
URL: https://github.com/apache/incubator-sdap-nexus/pull/143
…3.8 and spark 3.1.1
mostly for bug https://issues.apache.org/jira/projects/SDAP/issues/SDAP-356
--
This is an automated message from the Apache Git Service.
To respond to
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ngachung merged pull request #142:
URL: https://github.com/apache/incubator-sdap-nexus/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955098723
Gotcha, makes sense thanks @joshgarde !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
joshgarde commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955098279
The commit of the versioning only occurs on `develop` and `master` branches
--
This is an automated message from the Apache Git Service.
To respond to the
joshgarde commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955095907
Now that I'm thinking more about it however, since the `openapi.yml` file
remains static until an API update and it's not dynamically generated, perhaps
it's
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955095917
Does the version get bumped and committed back to openapi.yml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
joshgarde commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955094503
Yes - the versioning for the openapi.yml now tracks the Docker version. The
main version file in `docker/` gets bumped first and that version change gets
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955084328
Can you explain how the versioning works now for the openapi.yml file?
--
This is an automated message from the Apache Git Service.
To respond to the message,
joshgarde commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955062213
Yep - I was experimenting with a few solutions. The build's now passing -
https://github.com/joshgarde/incubator-sdap-nexus/runs/4051377910
--
This is an
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955040495
It looks like 88aa028 caused the build to break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
joshgarde edited a comment on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954970994
> I also wonder if we should document the new development process now that
it has changed. For example, we have been opening PRs against the master
branch,
joshgarde commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954970994
> I also wonder if we should document the new development process now that
it has changed. For example, we have been opening PRs against the master
branch, but I
skorper commented on a change in pull request #142:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/142#discussion_r739458964
##
File path: analysis/webservice/apidocs/openapi.yml
##
@@ -671,12 +673,19 @@ components:
type: string
source:
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954963802
Another thought -- what about the version in the openapi.yml file? It would
be nice to version that automatically as well, though maybe that's a task for
another
joshgarde commented on a change in pull request #142:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/142#discussion_r739450431
##
File path: analysis/webservice/apidocs/openapi.yml
##
@@ -671,12 +673,19 @@ components:
type: string
source:
tloubrieu-jpl commented on a change in pull request #48:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/48#discussion_r739423815
##
File path:
granule_ingester/granule_ingester/processors/TileSummarizingProcessor.py
##
@@ -27,17 +30,45 @@ class
skorper commented on pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954209076
I also wonder if we should document the new development process now that it
has changed. For example, we have been opening PRs against the master branch,
but I
skorper opened a new pull request #142:
URL: https://github.com/apache/incubator-sdap-nexus/pull/142
- Updated matchup request param from `matchup` to `secondary`
- Updated matchup output `data` to either `primary` or `secondary`
- Updated `matchup` terminology to `secondary` in code
jasonmlkang opened a new pull request #141:
URL: https://github.com/apache/incubator-sdap-nexus/pull/141
**Included in this PR:**
- [x] Specified `cassandraPort` option to return an integer. Cassandra port
number needs to be an integer. Otherwise, Cassandra library will throw an error.
skorper commented on a change in pull request #140:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/140#discussion_r738644533
##
File path: environment.yml
##
@@ -0,0 +1,147 @@
+name: sdap-nexus
Review comment:
I assume we will need to re-generate this file
joshgarde opened a new pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
Initial build pipeline work with GitHub Actions. Tested with forked repo:
https://github.com/joshgarde/incubator-sdap-nexus/actions
--
This is an automated message from the Apache Git
joshgarde closed pull request #139:
URL: https://github.com/apache/incubator-sdap-nexus/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joshgarde opened a new pull request #139:
URL: https://github.com/apache/incubator-sdap-nexus/pull/139
Initial build pipeline work with GitHub Actions. Tested with forked repo:
https://github.com/joshgarde/incubator-sdap-nexus/actions
--
This is an automated message from the Apache Git
jasonmlkang opened a new pull request #48:
URL: https://github.com/apache/incubator-sdap-ingester/pull/48
Some datasets lack a time variable and attributes and only indicate the date
and/or time in the filename. In these cases, the ingester needs to be able to
extract the time stamp from
ngachung merged pull request #47:
URL: https://github.com/apache/incubator-sdap-ingester/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #47:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/47#issuecomment-940574407
@ngachung
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
skorper opened a new pull request #47:
URL: https://github.com/apache/incubator-sdap-ingester/pull/47
Fixed bug where arg `--zk-host-and-port` was incorrectly named
`--zk_host_and_port`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
skorper opened a new pull request #46:
URL: https://github.com/apache/incubator-sdap-ingester/pull/46
In order to support Gregorian calendar types, I updated the Julian check to
check instead for the base class `cftime.datetime`. This means this code will
run for both Julian and Gregorian
twnone commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-940123869
@skorper
I integrated your previous commits into our merge request. Please let me
know if anything's wrong.
--
This is an automated message from the Apache Git
tloubrieu-jpl opened a new pull request #137:
URL: https://github.com/apache/incubator-sdap-nexus/pull/137
Make the deployment work on Redhat openshift
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tloubrieu-jpl opened a new pull request #45:
URL: https://github.com/apache/incubator-sdap-ingester/pull/45
And other update for the deployment to work on RedHat openshift
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jjacob7734 merged pull request #44:
URL: https://github.com/apache/incubator-sdap-ingester/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jjacob7734 removed a comment on pull request #44:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/44#issuecomment-937383277
Confirmed I was able to ingest a GPM_3IMERGDE_V06 file with this fix.
--
This is an automated message from the Apache Git Service.
To respond to
jjacob7734 commented on pull request #44:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/44#issuecomment-937383277
Confirmed I was able to ingest a GPM_3IMERGDE_V06 file with this fix.
--
This is an automated message from the Apache Git Service.
To respond to the
jjacob7734 removed a comment on pull request #44:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/44#issuecomment-937383277
Confirmed I was able to ingest a GPM_3IMERGDE_V06 file with this fix.
--
This is an automated message from the Apache Git Service.
To respond to
jjacob7734 commented on pull request #44:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/44#issuecomment-937383277
Confirmed I was able to ingest a GPM_3IMERGDE_V06 file with this fix.
--
This is an automated message from the Apache Git Service.
To respond to the
jjacob7734 merged pull request #44:
URL: https://github.com/apache/incubator-sdap-ingester/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
skorper opened a new pull request #44:
URL: https://github.com/apache/incubator-sdap-ingester/pull/44
Fixed issue with GPM data seen here:
https://issues.apache.org/jira/browse/SDAP-343
I have not regression tested this issue but all GridReadingProcessor tests
are passing.
--
twnone commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-930870662
@skorper Thank you for the heads up, I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ngachung merged pull request #132:
URL: https://github.com/apache/incubator-sdap-nexus/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-930429047
@WicketWarrick We just merged a change to nexustiles which is probably
causing the merge conflicts. Can you rebase on the master branch and fix the
merge conflicts?
skorper commented on pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#issuecomment-929755901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
skorper commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-930429047
@WicketWarrick We just merged a change to nexustiles which is probably
causing the merge conflicts. Can you rebase on the master branch and fix the
merge conflicts?
ngachung merged pull request #132:
URL: https://github.com/apache/incubator-sdap-nexus/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#issuecomment-930323278
Further updated the backwards compatibility of the solr doc -- works when
the `tile_standard_name_s` field is not present. Tested this on dataset
skorper commented on pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#issuecomment-930303660
I've added backwards compatibility with the previous iteration of the solr
doc. Example solr doc:
```json
{
"table_s":"sea_surface_temp",
skorper commented on pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#issuecomment-929755901
@ngachung In the latest commit, I've updated matchup to work with the new
multi-var solr doc structure. I also updated the unit tests and tested locally:
```
frankinspace commented on pull request #43:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/43#issuecomment-929364695
This was the "old" ingest code that was able to write to S3 instead of
cassandra:
jjacob7734 commented on pull request #43:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/43#issuecomment-929532976
Adding S3 as a datastore option was work done by David Silvan, a summer
intern at JPL, in Summer of 2017. I think he worked primarily with @ngachung
on that.
frankinspace commented on pull request #43:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/43#issuecomment-929364695
This was the "old" ingest code that was able to write to S3 instead of
cassandra:
wphyojpl opened a new pull request #43:
URL: https://github.com/apache/incubator-sdap-ingester/pull/43
- add class to store tile blob in S3 in addition to Cassandra
- update configuration to accept either S3 or Cassandra
- refactor main method to avoid code duplication
- TODO: add
ngachung merged pull request #42:
URL: https://github.com/apache/incubator-sdap-ingester/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ngachung merged pull request #41:
URL: https://github.com/apache/incubator-sdap-ingester/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #41:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/41#issuecomment-925410165
@ngachung I've updated the ingester so the standard_name field is only
included if that value is non-null.
--
This is an automated message from the Apache Git
skorper commented on pull request #41:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/41#issuecomment-925394198
Don't index null field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
twnone commented on pull request #42:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/42#issuecomment-924995382
Hi @ngachung
We noticed that there is a method in Nexus webapp which relies on
day_of_year_i field which does not exist in the ingester module, so we decided
to
WicketWarrick opened a new pull request #42:
URL: https://github.com/apache/incubator-sdap-ingester/pull/42
Added day_of_year_i to Solr and Elasticsearch writers, and fixed issue in
the way we access units in kelvintocelsius processor
--
This is an automated message from the Apache Git
WicketWarrick commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-923960026
@ngachung, this should be all good.
Let us know !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
skorper closed pull request #40:
URL: https://github.com/apache/incubator-sdap-ingester/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #40:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/40#issuecomment-923185638
Closing this PR because the agreed upon multi-var format has changed. A new
PR will be opened with the multi-var solr metadata format.
--
This is an automated
skorper edited a comment on pull request #40:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/40#issuecomment-922148942
@ngachung This has been tested on bigdata and is working as expected.
```json
{
"table_s":"sea_surface_temp",
skorper commented on pull request #40:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/40#issuecomment-922148942
@ngachung This has been tested on bigdata and is working as expected.
```json
{
"table_s":"sea_surface_temp",
"geo":"POLYGON((-169.151
ngachung merged pull request #136:
URL: https://github.com/apache/incubator-sdap-nexus/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709673761
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
def
frankinspace commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709669114
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
skorper commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709666976
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
def
skorper commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709666976
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
def
frankinspace commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709661092
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
skorper commented on a change in pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709632309
##
File path: data-access/nexustiles/model/nexusmodel.py
##
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
def
joshgarde closed pull request #135:
URL: https://github.com/apache/incubator-sdap-nexus/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #40:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/40#issuecomment-919426072
@ngachung @wphyojpl FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
skorper opened a new pull request #40:
URL: https://github.com/apache/incubator-sdap-ingester/pull/40
To support https://github.com/apache/incubator-sdap-nexus/pull/132, I've
added the standard name to the solr doc, and the var_name field in the solr doc
uses the var name instead of the
ngachung commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-916225721
@WicketWarrick Sounds good. Yes, if you can fix the unit tests for SolrProxy
that would be greatly appreciated. Thank you!
--
This is an automated message from
WicketWarrick commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-916172380
> @WicketWarrick @twnone Thank you for your work on adding Elasticsearch as
a metadata store for SDAP. Can you please include unit tests for your changes?
ngachung commented on pull request #133:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/133#issuecomment-915659763
@WicketWarrick @twnone Thank you for your work on adding Elasticsearch as a
metadata store for SDAP. Can you please include unit tests for your changes?
--
This
ngachung merged pull request #36:
URL: https://github.com/apache/incubator-sdap-ingester/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ngachung merged pull request #134:
URL: https://github.com/apache/incubator-sdap-nexus/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
skorper commented on pull request #132:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/132#issuecomment-915451724
Updated response fields to 'variable_name' as-per the feedback received on
Friday. Also added an extra test for multi-var sat to multi-var sat.
Once
wphyojpl opened a new pull request #39:
URL: https://github.com/apache/incubator-sdap-ingester/pull/39
- for multivariable processes, pass `null` when `standard_name` is missing
- updated test case
- if it is single variable data, it will be either `"the name"` or `null` is
passed
301 - 400 of 1280 matches
Mail list logo
