[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199283266 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/traindata/ExpertRankTrainData.java

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279501 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SparkFormatter.java ##

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279768 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/traindata/RankTrainDataFactory.java

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277801 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SVMLearner.java ## @@

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279293 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SparkFormatter.java ##

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276440 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/Learner.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277549 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/evaluate/ClickstreamImporter.java

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279464 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SparkFormatter.java ##

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276256 ## File path: ranking/src/main/assembly/bin.xml ## @@ -0,0 +1,50 @@ + Review comment: We do

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277654 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/evaluate/ClickstreamImporter.java

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276741 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/LearnerFactory.java ## @@

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277894 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SVMLearner.java ## @@

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279819 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/traindata/RankTrainDataFactory.java

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276589 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/Learner.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277104 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/dlrank/DLLearner.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276534 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/Learner.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276202 ## File path: ranking/pom.xml ## @@ -0,0 +1,215 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199279167 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/ranksvm/SVMLearner.java ## @@

[GitHub] lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module

2018-06-29 Thread GitBox
lewismc commented on a change in pull request #31: SDAP-118 create a new ranking module URL: https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276659 ## File path: ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/LearnerFactory.java ## @@