Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49491/ --- Review request for sentry, Anne Yu and Dapeng Sun. Bugs: SENTRY-1334

Re: Review Request 49428: SENTRY-1327?Enable "show grant role roleName on all" command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/#review140303 --- Ship it! Ship It! - Dapeng Sun On 七月 1, 2016, 10:25 a.m.,

Re: Review Request 49428: SENTRY-1327?Enable "show grant role roleName on all" command

> On June 30, 2016, 8:37 a.m., Dapeng Sun wrote: > > Thank Ke, I left some comments. Thanks dapeng comment. I fixed. - Ke --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/#review140122

Re: Review Request 49428: SENTRY-1327?Enable "show grant role roleName on all" command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/ --- (Updated July 1, 2016, 2:25 a.m.) Review request for sentry and Dapeng Sun.

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

> On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1857 > > > > > > nit: _new string :-), may

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/#review140273 ---

Re: Review Request 49477: SENTRY-1378: Login fails for a secure Sentry Web UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49477/#review140271 --- Hadoop treats the username and group name as case sensitive, same

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

> On June 30, 2016, 10:19 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1829 > > > > > > Thats a good point.

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

On June 28, 2016, 4:08 p.m., Sravya Tirukkovalur wrote: > > A general comment. We have had testing running too long and vm gets killed > > issue. So for each test class, ideally it is a small and focused test > > suite. If it grows large, can put into a seperate test class. So ensure > > each

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

> On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1829 > > > > > > I presume Sentry is

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

On June 28, 2016, 4:08 p.m., Sravya Tirukkovalur wrote: > > A general comment. We have had testing running too long and vm gets killed > > issue. So for each test class, ideally it is a small and focused test > > suite. If it grows large, can put into a seperate test class. So ensure > > each

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49290/#review140246 ---

Review Request 49428: SENTRY-1327?Enable "show grant role roleName on all" command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/ --- Review request for sentry and Dapeng Sun. Bugs: SENTRY-1327

RE: Status of SENTRY-1205

Hello Ashish, Thanks for your review. Currently, for sentry plugin, it won't depend on sentry-service-server which includes about 50 classes. I think SENTRY-1205 is the first step to refactor the module, and I'll improve it according to your evaluation for Kafka plugin later. best regards,