Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

2016-07-27 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/ --- (Updated July 27, 2016, 11:58 p.m.) Review request for sentry and Hao Hao.

Re: Review Request 50537: SENTRY-1413:Changes to get the Fencer working with Oracle and MySQL

2016-07-27 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50537/ --- (Updated July 27, 2016, 10:59 p.m.) Review request for sentry, Hao Hao and

Review Request 50537: SENTRY-1413:Changes to get the Fencer working with Oracle and MySQL

2016-07-27 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50537/ --- Review request for sentry, Hao Hao and Sravya Tirukkovalur. Repository: sentry

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
> On July 27, 2016, 9:37 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Are you making that configurable

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > > > > > It would be better to test

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
> On July 26, 2016, 7:16 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Will it be possible to have more than 2

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Rahul Sharma
> On July 26, 2016, 7:16 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Will it be possible to have more than 2

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Rahul Sharma
> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > > > > > It would be better to test