Re: Review Request 56000: SENTRY-1604 Sentry JSON message factory: Need more information in alter partition event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56000/ --- (Updated Feb. 4, 2017, 5:48 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55999/ --- (Updated Feb. 4, 2017, 5:42 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55999/#review164218 --- sentry-binding/sentry-binding-hive-follower/src/main/java/org/apa

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

> On Feb. 3, 2017, 7:51 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java, > > line 26 > > > > > >

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

> On Feb. 3, 2017, 7:32 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java, > > line 60 > > > > > > Whi

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55999/#review164082 --- Fix it, then Ship it! Ship It! sentry-binding/sentry-binding-

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

> On Feb. 3, 2017, 7:51 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java, > > line 26 > > > > > >

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

> On Feb. 3, 2017, 7:51 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java, > > line 26 > > > > > >

Re: Review Request 56134: SENTRY-1593 and SENTRY-1592 Implementing client failover for Generic policy clients and namenode clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56134/#review164166 --- sentry-core/sentry-core-common/pom.xml (lines 117 - 122)

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Feb. 3, 2017, 7:12 p.m., Vadim Spector wrote: > > Hao, I'm not sure what "to allow for extra transactions for a single > > permission update" means, could you, please, clarify? > > Vadim Spector wrote: > Do you mean placing a single permision update inside a transaction (then > I'm no

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Feb. 3, 2017, 10:59 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java, > > line 295 > > > > > > general question for all onAlterSentryRole...(

Re: Review Request 56271: SENTRY-1621: HMSFollower to retry connecting to HMS upon connection loss

> On Feb. 3, 2017, 8:28 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 265 > > > > > > Could there be any other exception impile

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Feb. 3, 2017, 10:59 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java, > > line 295 > > > > > > general question for all onAlterSentryRole...(

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/#review164182 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 56000: SENTRY-1604 Sentry JSON message factory: Need more information in alter partition event

> On Feb. 3, 2017, 8:34 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java, > > line 32 > > > > > >

Re: Review Request 56000: SENTRY-1604 Sentry JSON message factory: Need more information in alter partition event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56000/#review164160 --- sentry-binding/sentry-binding-hive-follower/src/main/java/org/apa

Re: Review Request 56271: SENTRY-1621: HMSFollower to retry connecting to HMS upon connection loss

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56271/#review164158 --- Fix it, then Ship it! sentry-provider/sentry-provider-db/src/m

Re: Review Request 56200: Renamed the sql with proper jira id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56200/#review164151 --- Ship it! Ship It! - Hao Hao On Feb. 2, 2017, 2:43 p.m., kaly

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55999/#review164147 --- Fix it, then Ship it! sentry-binding/sentry-binding-hive-follo

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

> On Feb. 3, 2017, 7:32 p.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java, > > line 60 > > > > > > Whi

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55999/#review164144 --- sentry-binding/sentry-binding-hive-follower/src/main/java/org/apa

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Feb. 3, 2017, 7:12 p.m., Vadim Spector wrote: > > Hao, I'm not sure what "to allow for extra transactions for a single > > permission update" means, could you, please, clarify? Do you mean placing a single permision update inside a transaction (then I'm not sure why "transactions" in plur

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/#review164139 --- Hao, I'm not sure what "to allow for extra transactions for a sing