Re: Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/#review203906 ---

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review203889 ---

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review203899 ---

Re: Thoughts on using lombok?

The lombok plugin for IntelliJ has all of that built in. You select find usage of on the variable and it will show the usage of the getters and setters. From what I have seen the eclipse plugin has that as well. -=Brian On Fri, May 25, 2018 at 12:28 PM Alexander Kolbasov

Re: Thoughts on using lombok?

The usage would be for any class that can make use of some of the attributes. @Data is a nice one for pojos and entities, but the constructor ones, Synchronized and others can be used in almost any class. The @Log/@Slf4j ones are very handy. It happens at compile time and does not generate

Re: Thoughts on using lombok?

Brian, This seems interesting. How does it interplay with IntelliJ/Eclipse ability to find all usages of the method - will we still be able to find all references to constructors/getters/setters e.t.c. ? > On May 24, 2018, at 12:54 PM, Brian Towles wrote: > > Howdy all,

Re: Thoughts on using lombok?

Would this mainly be on the DB layer? With intellij, theres a shortcut to auto-gen these fields, does this improve on that? At compile time, does it overwrite the src or generate a new file? In the case of needing additional logic in a set/get method, can I override that? > On May 24, 2018,

Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2246

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/ --- (Updated May 25, 2018, 1:59 p.m.) Review request for sentry. Changes ---