Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

2019-01-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 30, 2019, 5:02 a.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

2019-01-29 Thread Na Li via Review Board
> On Jan. 30, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > > Lines 113 (patched) > > > > > > Don'

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

2019-01-29 Thread Na Li via Review Board
> On Jan. 30, 2019, 12:35 a.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java > > Line 158 (original), 162 (patched) > >

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

2019-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/#review212291 --- Fix it, then Ship it! Please consider the cosmetic comments add

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

2019-01-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/ --- (Updated Jan. 29, 2019, 9:09 p.m.) Review request for sentry, Haley Reeve, kaly

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

2019-01-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69832/ --- (Updated Jan. 29, 2019, 6:47 p.m.) Review request for sentry, Haley Reeve, kaly

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

2019-01-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 29, 2019, 4:15 p.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

2019-01-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/ --- (Updated Jan. 29, 2019, 3:43 p.m.) Review request for sentry, Haley Reeve, kaly