Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-25 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209014 --- Ship it! Ship It! - Na Li On Sept. 25, 2018, 9:23 p.m., Hao

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-25 Thread Hao Hao via Review Board
> On Sept. 25, 2018, 11:22 p.m., Na Li wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Lines 419 (patched) > > > > > > I heard today that it is possible to assign

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-25 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209007 ---

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-25 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 11:23 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 915 (patched) > > > > > > you have

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-25 Thread Hao Hao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/ --- (Updated Sept. 25, 2018, 9:23 p.m.) Review request for sentry, Na Li and

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 11:23 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 915 (patched) > > > > > > you have

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208969 ---

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 3:35 p.m., Sergio Pena wrote: > > Btw, are you going to have another JIRA for the client to call this new API? > > Hao Hao wrote: > Sure, I can create a jira for adding the client side logical. SENTRY-2418 is filed. - Hao

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/ --- (Updated Sept. 24, 2018, 9:31 p.m.) Review request for sentry, Na Li and

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 3:35 p.m., Sergio Pena wrote: > > Btw, are you going to have another JIRA for the client to call this new API? Sure, I can create a jira for adding the client side logical. - Hao --- This is an automatically

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208950 --- Btw, are you going to have another JIRA for the client to call