Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201939 --- dev-support/smart-apply-patch.sh Line 33 (original), 32

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Anthony Young-Garner via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201928 --- dev-support/smart-apply-patch.sh Line 33 (original), 32

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-25 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/#review201942 --- Why is the package name changed for

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Alexander Kolbasov
> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-25 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 --- Lina, would it be better to create another patch to fix the 2.1.0

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Steve Moist via Review Board
> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 33 (original), 32 (patched) > > > > > > Will we not continue to support stdin patches? I think it can still be

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201957 --- I found out that Hive made a change on the smart-apply-patch.sh

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-25 Thread Steve Moist via Review Board
> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-25 Thread Na Li via Review Board
> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? Sergio, I don't want to take the trouble to fix the 2.1.0

Re: HMS catalogs and Sentry

2018-04-25 Thread Alexander Kolbasov
See https://issues.apache.org/jira/browse/HIVE-18755. Basically catalog is a container for databases - all databases belong to a catalog. This means that Sentry may need to support catalog-level privileges. - Alex On Wed, Apr 25, 2018 at 5:06 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com>

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Steve Moist via Review Board
> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Steve Moist via Review Board
> On April 25, 2018, 7:58 p.m., Sergio Pena wrote: > > I found out that Hive made a change on the smart-apply-patch.sh to use git > > apply instead of patch, and the patch still have some validation to check > > if the patch was generated using the --no-prefix and also the levels. > > See > >

Re: HMS catalogs and Sentry

2018-04-25 Thread Kalyan Kumar Kalvagadda
Sasha, Could you share information on what catalog is? -Kalyan *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer t. (469) 279- <00>5732 cloudera.com [image: Cloudera] [image: Cloudera on Twitter]

HMS catalogs and Sentry

2018-04-25 Thread Alexander Kolbasov
Hive 3 introduced the notion of catalog. What do people think about supporting it in Sentry as well? At some point we will move to Hive-3 and then it will become a requirement I guess. - Alex