Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 15, 2018, 10:46 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 276 (patched) > > > > > > This

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 15, 2018, 9:02 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 206 (original), 211 (patched) > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
- Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204870 --- On June 15, 2018, 8:08 p.m., Arjun Mishra wrote: > > --

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 15, 2018, 10:46 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 291 (patched) > > > > > > I do

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 18, 2018, 6:59 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated June 18, 2018, 7:08 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

2018-06-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/#review204935 --- I think we should start thinking on splitting this patch into two,

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204955 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 295 (patched) > > > > > > Space

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Line 243 (original), 258 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

2018-06-18 Thread Arjun Mishra via Review Board
> On June 18, 2018, 9:31 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java > > Lines 27-28 (patched) > > > > > > Assing the v

Review Request 67637: SENTRY-2265: Translate owner privilege in sentry binding for authorization

2018-06-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67637/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2265 ht