Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212499 --- General comment - Instead of logging sentances can we simplify it

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212500 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212501 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212502 --- We definitely need logs on Entry class - Arjun Mishra On Jan. 3

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212503 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread Haley Reeve via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212504 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread kalyan kumar kalvagadda via Review Board
> On Feb. 1, 2019, 4:48 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 199 (original), 203 (patched) > > > > > > Why n

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread kalyan kumar kalvagadda via Review Board
> On Feb. 1, 2019, 4:34 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 468 (original), 472 (patched) > > > > > > Log here? added log to remov

Re: Review Request 69875: SENTRY-2205: Improve Sentry NN Logging

2019-02-01 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/ --- (Updated Feb. 1, 2019, 10:22 p.m.) Review request for sentry, Arjun Mishra, Hal