Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-06 Thread Daniel Qian
Hi Ma, what I have done is: 1. 3rd-party LICENSE information is merged 2. connect the pom.xml together so it can be built from project root dir 3. check style functionality he integrated into cli So from the perspective of building and distribution, it's been integrated. But from the perspective

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hi Ma, got it. Bin Ma 于2019年11月5日周二 上午11:19写道: > > Hi Daniel, > > Sorry, I misread the question. > > I think it's better to support both checkcompatibility and cc as > subcommands. > > Wishes & Regards > --- > Mabin > > > > sen sun 于2019年11月5日周二 上午9:40写道: > > > I

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
Hi Daniel, Sorry, I misread the question. I think it's better to support both checkcompatibility and cc as subcommands. Wishes & Regards --- Mabin sen sun 于2019年11月5日周二 上午9:40写道: > I think Ma just made an example of the option naming style instead of the >

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread sen sun
I think Ma just made an example of the option naming style instead of the subcommand. I think it's a good idea to support both checkcompatibility and cc as subcommands. Daniel Qian 于2019年11月5日周二 上午7:28写道: > Hello Ma, found current cli style is . > So if we do --check-compatability then which

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hello Ma, found current cli style is . So if we do --check-compatability then which subcommand should we use? Bin Ma 于2019年11月5日周二 上午12:44写道: > > I recommend keeping the same as the current option naming style, > such as "-c", "-- check-compability " > > > Wishes & Regards >

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
I recommend keeping the same as the current option naming style, such as "-c", "-- check-compability " Wishes & Regards --- Mabin Willem Jiang 于2019年11月1日周五 下午12:31写道: > I think we can support checkcompatibility and the short one cc at the same > time. > Any

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-10-31 Thread Willem Jiang
I think we can support checkcompatibility and the short one cc at the same time. Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian wrote: > > I created an issue SCB-1555[1] to integrate oas-validator > compatibility check to toolkit

[DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-10-29 Thread Daniel Qian
I created an issue SCB-1555[1] to integrate oas-validator compatibility check to toolkit cli. I suggest usage like this: java -jar toolkit-cli-{version}.jar checkcompability /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml But the subcommand checkcompability is too long, maybe we can use a