[GitHub] coveralls commented on issue #636: SCB-189 fix CI problems and warnings for feature support async restTe…

2018-04-07 Thread GitBox 
coveralls commented on issue #636: SCB-189 fix CI problems and warnings for 
feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#issuecomment-379521919
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16403409/badge)](https://coveralls.io/builds/16403409)
   
   Coverage decreased (-0.006%) to 87.6% when pulling 
**5e809f2ad8a44589ac526b9af6526483ede8da95 on lijasonvip:scb-189** into 
**8a77e34365e786462b74826c724d10f0e735d5fe on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #58: Fix some incorrect style

2018-04-07 Thread GitBox 
WillemJiang closed pull request #58: Fix some incorrect style
URL: https://github.com/apache/incubator-servicecomb-website/pull/58
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/_users/cn/metrics-in-1.0.0-m1.md b/_users/cn/metrics-in-1.0.0-m1.md
index bd08c41..dcbbf1e 100644
--- a/_users/cn/metrics-in-1.0.0-m1.md
+++ b/_users/cn/metrics-in-1.0.0-m1.md
@@ -251,8 +251,10 @@ public class OrderController {
 }
 ```
 
-注意事项：  
-1. 
通过MonitorManager获取Monitor传递name和tag数组，最终输出的ID是它们连接后的字符串，所以请保持唯一性，上面的例子输出的Metrics为：
+注意事项： 
+ 
+1.通过MonitorManager获取Monitor传递name和tag数组，最终输出的ID是它们连接后的字符串，所以请保持唯一性，上面的例子输出的Metrics为：
+
 ```java
 Map metrics = MonitorManager.getInstance().measure();
 
@@ -263,18 +265,20 @@ Map metrics = 
MonitorManager.getInstance().measure();
 // 生成订单(统计项=最大生成时间,单位=MILLISECONDS)
 ```
 
-2. MonitorManager获取Monitor的方法均为**获取或创建**，因此多次传递相同的name和tag数组返回的是同一个计数器：
+2.MonitorManager获取Monitor的方法均为**获取或创建**，因此多次传递相同的name和tag数组返回的是同一个计数器：
+
 ```java
-Counter counter1 = MonitorManager.getInstance().getCounter("订单数量", "商品名", 
"levis jeans", "型号", "512");
-Counter counter2 = MonitorManager.getInstance().getCounter("订单数量", "商品名", 
"levis jeans", "型号", "512");
+Counter counter1 = MonitorManager.getInstance().getCounter("订单数量", "商品名", 
"levis jeans", "型号", "512");
+Counter counter2 = MonitorManager.getInstance().getCounter("订单数量", "商品名", 
"levis jeans", "型号", "512");
 
-counter1.increment();
-counter2.increment();
+counter1.increment();
+counter2.increment();
 
-Assert.assertEquals(2,counter1.getValue());
-Assert.assertEquals(2,counter2.getValue());
-
Assert.assertEquals(2.0,MonitorManager.getInstance().measure().get("订单数量(商品名=levis
 jeans,型号=512)"),0);
+Assert.assertEquals(2,counter1.getValue());
+Assert.assertEquals(2,counter2.getValue());
+Assert.assertEquals(2.0,MonitorManager.getInstance().measure().get("订单数量(商品名=levis
 jeans,型号=512)"),0);
 ```
+
 **获取Monitor的方法性能较低，请在初始化阶段一次获取所需的Monitor，然后将它们缓存起来，请参照前面OrderController的做法。**
 
 **提示：Servo已经被Netflix标记为DEPRECATED，我们将在1.0.0-m2中使用Netflix 
spectator替换，扩展自定义Metrics的方式会有调整**
diff --git a/_users/cn/metrics-integration-with-prometheus-in-1.0.0-m1.md 
b/_users/cn/metrics-integration-with-prometheus-in-1.0.0-m1.md
index b5100dc..63fc23b 100644
--- a/_users/cn/metrics-integration-with-prometheus-in-1.0.0-m1.md
+++ b/_users/cn/metrics-integration-with-prometheus-in-1.0.0-m1.md
@@ -87,6 +87,7 @@ scrape_configs:
 
 ### 验证输出
 Prometheus Simple HTTP 
Server使用/metrics作为默认URL，metrics-prometheus会使用9696作为默认端口，微服务启动后你可以使用http://localhost:9696/metrics
 访问它。
+
 使用Prometheus Simple HTTP Server接口发布的数据是Prometheus采集的标准格式：
 ```text
 # HELP ServiceComb Metrics ServiceComb Metrics
@@ -114,6 +115,7 @@ 
servicecomb_invocation_calculator_calculatorRestEndpoint_calculate{role="produce
 
如何在Grafana中添加Prometheus作为数据源请参考[这篇文章](https://prometheus.io/docs/visualization/grafana/)。
 ## 运行效果
 配置好Prometheus并启动了微服务之后，就可以打开Prometheus Web界面（默认地址是http://localhost:9090/ 
），在Metrics列表中看到ServiceComb开头的Java Chassis Metrics，如下图所示：
+
 ![MetricsInPrometheus](/assets/images/MetricsInPrometheus.png)  
 
 为了能够达到更好的查询效果，在Grafana中添加Prometheus作为数据源，通过Grafana查询数据如下图示：
diff --git a/_users/edge-in-1.0.0-m1.md b/_users/edge-in-1.0.0-m1.md
index 4bd689a..7429f56 100644
--- a/_users/edge-in-1.0.0-m1.md
+++ b/_users/edge-in-1.0.0-m1.md
@@ -92,7 +92,7 @@ Edge Service use SPI(Service Provider Interface) to load 
custom VertxHttpDispatc
 Edge Service always use to provide monitoring, resiliency, security, and more, 
not only dynamic routing. We recommend extend custom handlers, there is an 
example named AuthHandler in demo-edge.
 
 ## Other Reference
-In demo/demo-edge we had provided a simple demo to show abilities of Edge 
Service：
+In demo/demo-edge we had provided a simple demo to show abilities of Edge 
Service:
 1. edge-service:Edge Service, include AuthHandler;
 2. authentication:Simulate authentication, accept requests from AuthHandler;
 3. business-x.x.x:Simulate multi-version business instances;
diff --git a/_users/metrics-in-1.0.0-m1.md b/_users/metrics-in-1.0.0-m1.md
index f46d845..f591706 100644
--- a/_users/metrics-in-1.0.0-m1.md
+++ b/_users/metrics-in-1.0.0-m1.md
@@ -200,6 +200,7 @@ Metrics data will output as Map,in order to 
let user easier fetch
 //get K3=30 Metric from node
 
node.getChildrenNode("1").getChildrenNode("20").getFirstMatchMetricValue("K3","30");
 ```
+
 *More detail can be found in demo/perf/PerfMetricsFilePublisher.java*
 
 ## How to Extend Custom Metrics
@@ -250,8 +251,11 @@ public class OrderController {
   }
 }
 ```
+
 Notice:
-1. Metric ID is join name and all tags that pass to MonitorManager when 
getting monitor,so please keep uniqueness,metrics output of front example

[GitHub] wujimin commented on a change in pull request #635: [SCB-462] cloud eye publisher switch to new mechanism

2018-04-07 Thread GitBox 
wujimin commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179916788
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/resources/sample-log4j2.xml
 ##
 @@ -0,0 +1,29 @@
+
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] little-cui closed pull request #323: Update the description of Service-Center in Readme

2018-04-07 Thread GitBox 
little-cui closed pull request #323: Update the description of Service-Center 
in Readme
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/323
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #322: [SCB-454] update instance status api param check

2018-04-07 Thread GitBox 
codecov-io commented on issue #322: [SCB-454] update instance status api param 
check
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/322#issuecomment-377680435
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=h1)
 Report
   > Merging 
[#322](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/9a95fec2a48c8997e794d8a77deaff502578c142?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `38.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/graphs/tree.svg?height=150=650=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#322  +/-   ##
   =
   - Coverage   69.98%   69.7%   -0.29% 
   =
 Files  17  17  
 Lines34353426   -9 
   =
   - Hits 24042388  -16 
   - Misses860 871  +11 
   + Partials  171 167   -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv)
 | `47.75% <0%> (-5.71%)` | :arrow_down: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `68.21% <82.35%> (+0.69%)` | :arrow_up: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=footer).
 Last update 
[9a95fec...343b179](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lijasonvip opened a new pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

2018-04-07 Thread GitBox 
lijasonvip opened a new pull request #636: SCB-189 fix CI problems and warnings 
for feature support async restTe…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/636
 
 
   …mplate
   
   Signed-off-by: lijasonvip 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #637: [SCB-459]Update netty's version to 4.1.19 and vertx's version to 3.5.1

2018-04-07 Thread GitBox 
coveralls commented on issue #637: [SCB-459]Update netty's version to 4.1.19 
and vertx's version to 3.5.1
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/637#issuecomment-379520177
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16403278/badge)](https://coveralls.io/builds/16403278)
   
   Coverage remained the same at 87.605% when pulling 
**e8a78817ad054d2bc0b162c024c10a93d2946aef on xuyiyun0929:upgradeNetty** into 
**8a77e34365e786462b74826c724d10f0e735d5fe on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics

2018-04-07 Thread GitBox 
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179932884
 
 

 ##
 File path: 
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestDefaultRegistryInitializer.java
 ##
 @@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.metrics.core;
+
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.hamcrest.Matchers;
+import org.junit.Assert;
+import org.junit.Test;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.ManualClock;
+import com.netflix.spectator.api.SpectatorUtils;
+import com.netflix.spectator.servo.ServoRegistry;
+
+public class TestDefaultRegistryInitializer {
+  CompositeRegistry globalRegistry = 
SpectatorUtils.createCompositeRegistry(new ManualClock());
+
+  DefaultRegistryInitializer registryInitializer = new 
DefaultRegistryInitializer();
+
+  @Test
+  public void init() {
+registryInitializer.init(globalRegistry, new EventBus(), new 
MetricsBootstrapConfig());
+
+Assert.assertEquals(-10, registryInitializer.getOrder());
+Assert.assertThat(registryInitializer.getRegistry(), 
Matchers.instanceOf(ServoRegistry.class));
+
+registryInitializer.uninit();
 
 Review comment:
   doen


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics

2018-04-07 Thread GitBox 
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179932881
 
 

 ##
 File path: 
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestClientPool.java
 ##
 @@ -17,43 +17,16 @@
 
 package org.apache.servicecomb.serviceregistry.client.http;
 
-import org.apache.servicecomb.serviceregistry.config.ServiceRegistryConfig;
 import org.junit.Test;
 
-import io.vertx.core.http.HttpVersion;
-import mockit.Mock;
-import mockit.MockUp;
-
 public class TestClientPool {
   @Test
   public void testHttpClientPool() {
-new MockUp() {
-  @Mock
-  public HttpVersion getHttpVersion() {
-return HttpVersion.HTTP_2;
-  }
-
-  @Mock
-  public boolean isSsl() {
-return true;
-  }
-};
 HttpClientPool.INSTANCE.create();
 
 Review comment:
   done
   add new test cases for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #322: [SCB-454] update instance status api param check

2018-04-07 Thread GitBox 
coveralls commented on issue #322: [SCB-454] update instance status api param 
check
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/322#issuecomment-377680464
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16402936/badge)](https://coveralls.io/builds/16402936)
   
   Coverage decreased (-0.4%) to 73.247% when pulling 
**f2f9a08cfbe4fbded40c95cbfe1a6b4800cdfb34 on aseTo2016:aseTo** into 
**9a95fec2a48c8997e794d8a77deaff502578c142 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #322: [SCB-454] update instance status api param check

2018-04-07 Thread GitBox 
codecov-io commented on issue #322: [SCB-454] update instance status api param 
check
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/322#issuecomment-377680435
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=h1)
 Report
   > Merging 
[#322](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/9a95fec2a48c8997e794d8a77deaff502578c142?src=pr=desc)
 will **decrease** coverage by `0.28%`.
   > The diff coverage is `38.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#322  +/-   ##
   =
   - Coverage   69.98%   69.7%   -0.29% 
   =
 Files  17  17  
 Lines34353426   -9 
   =
   - Hits 24042388  -16 
   - Misses860 871  +11 
   + Partials  171 167   -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv)
 | `47.75% <0%> (-5.71%)` | :arrow_down: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `68.21% <82.35%> (+0.69%)` | :arrow_up: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=footer).
 Last update 
[9a95fec...f2f9a08](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/322?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services