+1
We can add the vendor to SC folder, this will ease out the development of
SC specially in China region where GFC blocks the downloading of google
libs.
Regards
Asif
On Sat, 25 Aug 2018, 3:22 pm Yang Bo, wrote:
> +1
>
> As for the Apache compliance, It's OK to include the vendor source
I have tired go mod today, it is a good tool. consider about it
glide is never a option, because it is recommending user to use dep.
Mohammad Asif Siddiqui 于2018年8月25日周六 下午5:57写道：
> +1
>
> We can add the vendor to SC folder, this will ease out the development of
> SC specially in China region
+1
As for the Apache compliance, It's OK to include the vendor source code in
our repository. We can update the release script and exclude the vendor
directory when releasing.
On Sat, Aug 25, 2018 at 4:20 PM Kirin Wang wrote:
> +1
> But may be we need to confirm if there are Apache compliance
+1 non-binding
Yang Bo 于2018年8月25日周六 下午6:00写道：
> +1 Non-binding
>
> On Sat, Aug 25, 2018 at 11:34 AM wjm wjm wrote:
>
> > +1 binding
> >
> > 2018-08-25 10:53 GMT+08:00 YangYongZheng <342906...@qq.com>:
> >
> > > That's Great!
> > > +1 non-binding.
> > >
> > > Best Regards!
> > > YangYongZheng
Congratulations!
DeanLee <82529...@qq.com> 于2018年8月25日周六 上午10:10写道：
> Congratulations ~
>
>
> Best Regards!
> Dian Li
>
>
>
> ---原始邮件---
> 发件人: "Willem Ning Jiang"
> 发送时间: 2018年8月24日(星期五) 中午11:27
> 收件人: "dev";
> 主题: [ANN] New ServiceComb committer: Yang Bo (杨波)
>
>
> Please join me and the rest
+1
But may be we need to confirm if there are Apache compliance issue about
it ?
Xiaoliang Tian 于2018年8月25日周六 上午10:48写道：
> +1 Agree
> the truth is go project can easily go into a dep hell and there is no dep
> tool can manage the complicated deps
>
> checkout how go project does
>
+1 Non-binding
On Sat, Aug 25, 2018 at 11:34 AM wjm wjm wrote:
> +1 binding
>
> 2018-08-25 10:53 GMT+08:00 YangYongZheng <342906...@qq.com>:
>
> > That's Great!
> > +1 non-binding.
> >
> > Best Regards!
> > YangYongZheng
> >
> > -邮件原件-
> > 发件人: Zen Lin
Hi，bismy
in factor we can import Lombok and make the scope is provided.
Then users dependency service Lombok will not see the Lombok jar.
We(sharding-sphere) use Lombok like this.
org.projectlombok
lombok
1.16.4
provided
> On 25 Aug 2018, at 9:27 AM, bismy wrote:
>
> @赵俊
>
Using glide or dep tool can achieve the effect of generating vendor.
As sc already used glide to manage package and go mod is still the experimental
feature in go 1.11,
i think there is no need to changed it, we can just push the source code to
repo.
--
+1 to include source code into vendor folders, and it is better to update
the release script of excluding the vendor directories at the same time.
Best Regards,
---
Zen Lin
zenlintechnofr...@gmail.com
Focused on Micro Service and Apache ServiceComb
Sure 于2018年8月25日周六 下午10:25写道：
> Using glide
Hi All,
We are glad to announce that ServiceComb community has approved Holding an
event called Apache ServiceComb (incubating) Meetup as a Co-located Event in
HC 2018 Shanghai, China, OCT 12, with the following results:
+1 binding: 4(Willem Jiang, Liubao, Wu Jimin, Sure)
+1 non-binding:
11 matches
Mail list logo
