[GitHub] coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#issuecomment-364824526 [![Coverage Status](https://coveralls.io/builds/15684092/badge)](https://coveralls.io/builds

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170439612 ## File path: metrics/metrics-core/src/test/java/org/apache/servic

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170439576 ## File path: metrics/metrics-core/src/main/java/org/apache/servic

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170439521 ## File path: foundations/foundation-metrics/src/test/java/org/apa

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170439517 ## File path: metrics/metrics-core/src/test/java/org/apache/servic

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170439515 ## File path: metrics/metrics-core/src/main/java/org/apache/servic

[GitHub] WillemJiang commented on issue #559: ??cse????????????????????multipart????????

2018-02-24 Thread GitBox
WillemJiang commented on issue #559: ??csemultipart URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/559#issuecomment-368236477 ?1.0.0-m1-SNAPSHOT, ? https://repository.apache.org/content/repositories/snapshots/

[GitHub] WillemJiang commented on issue #138: [WIP] SCB-224 retry sub-transaction on failure

2018-02-24 Thread GitBox
WillemJiang commented on issue #138: [WIP] SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368236318 @eric-lee-ltk There are some build error in you commit, could you take a look at it?

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422863 ## File path: metrics/metrics-core/src/test/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422785 ## File path: metrics/metrics-core/src/main/java/org/apache/servicec

[GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170422650 ## File path: foundations/foundation-metrics/src/test/java/org/apach

[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-02-24 Thread Mohammad Asif Siddiqui
Hi All, This is a call for vote(second attempt) to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes:  https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md    Release Candidate: https://dist.apache.org/repos/

[GitHub] coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#issuecomment-364824526 [![Coverage Status](https://coveralls.io/builds/15679133/badge)](https://coveralls.io/builds

[GitHub] coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

2018-02-24 Thread GitBox
coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364033007 [![Coverage Status](https://coveralls.io/builds/15678329/badge)](https://coveralls.i

[GitHub] codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

2018-02-24 Thread GitBox
codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?

[GitHub] coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
coveralls commented on issue #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#issuecomment-364824526 [![Coverage Status](https://coveralls.io/builds/15678180/badge)](https://coveralls.io/builds

Clean up the old saga modules

2018-02-24 Thread Willem Jiang
Hi team, As we are planning the servicecomb-saga binary release[1], I found out there are some old saga modules in the current master branch need to be archived. My proposal is we create a branch which holds current master branch codes and remove the old saga module from the master branch. After

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415566 ## File path: metrics/metrics-core/src/main/java/org/apache/servic

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415562 ## File path: metrics/metrics-core/src/main/java/org/apache/servic

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415520 ## File path: foundations/foundation-metrics/src/test/java/org/apa

[GitHub] codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

2018-02-24 Thread GitBox
codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415503 ## File path: demo/perf/src/main/java/org/apache/servicecomb/demo/

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415486 ## File path: demo/demo-springmvc/springmvc-client/src/main/java/o

[GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)

2018-02-24 Thread GitBox
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415468 ## File path: core/src/main/java/org/apache/servicecomb/core/Invoca

[GitHub] coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

2018-02-24 Thread GitBox
coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364033007 [![Coverage Status](https://coveralls.io/builds/15678032/badge)](https://coveralls.i