[GitHub] [incubator-shardingsphere] fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478203599 https://github.com/fdlzp/sharding-jdbc_jpa_oracle Thanks a lot!

[GitHub] [incubator-shardingsphere] msnetc closed issue #2106: sharding_proxy: Caused by: java.sql.SQLException: Unknown system variable 'query_cache_size'

2019-03-29 Thread GitBox
msnetc closed issue #2106: sharding_proxy: Caused by: java.sql.SQLException: Unknown system variable 'query_cache_size' URL: https://github.com/apache/incubator-shardingsphere/issues/2106 This is an automated message from

[GitHub] [incubator-shardingsphere] msnetc commented on issue #2106: sharding_proxy: Caused by: java.sql.SQLException: Unknown system variable 'query_cache_size'

2019-03-29 Thread GitBox
msnetc commented on issue #2106: sharding_proxy: Caused by: java.sql.SQLException: Unknown system variable 'query_cache_size' URL: https://github.com/apache/incubator-shardingsphere/issues/2106#issuecomment-478201697 @tuohai666 ,maybe I use the wrong version of config file, so I close the

[GitHub] [incubator-shardingsphere] msnetc closed issue #2109: sharding_proxy : lack of config file for config_sharding_masterslave.yaml

2019-03-29 Thread GitBox
msnetc closed issue #2109: sharding_proxy : lack of config file for config_sharding_masterslave.yaml URL: https://github.com/apache/incubator-shardingsphere/issues/2109 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] msnetc commented on issue #2109: sharding_proxy : lack of config file for config_sharding_masterslave.yaml

2019-03-29 Thread GitBox
msnetc commented on issue #2109: sharding_proxy : lack of config file for config_sharding_masterslave.yaml URL: https://github.com/apache/incubator-shardingsphere/issues/2109#issuecomment-478201604 thanks @terrymanu This

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread zhaojun
Agree to release +1 I have checked all item, it is ok 1. sha512 hash. 2. gpg Signature. 3. Items for source package. 4. Items for binary packages. Also ,the result of shardingsphere-accept-test is ok -- Zhao Jun Apache Sharding-Sphere & ServiceComb > On Mar 30, 2019, at 8:53

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
terrymanu commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478200627 Your environment is too complicated. Cloud you find what is root reason to

[GitHub] [incubator-shardingsphere] fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478200466 sharding-jdbc+jpa+oracle

[GitHub] [incubator-shardingsphere] fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478199817 only when i use save to add ,then: 2019-03-30 09:54:23.490 WARN 4000 ---

[GitHub] [incubator-shardingsphere] fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp edited a comment on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478199817 only when i use save to add ,then: 2019-03-30 09:54:23.490 WARN 4000 ---

[GitHub] [incubator-shardingsphere] fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp commented on issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138#issuecomment-478199817 只有新增不能成功,提示 2019-03-30 09:54:23.490 WARN 4000 --- [nio-8080-exec-1]

[GitHub] [incubator-shardingsphere] fdlzp opened a new issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase

2019-03-29 Thread GitBox
fdlzp opened a new issue #2138: Could not commit JPA transaction when I use save to insert data to oracledatabase URL: https://github.com/apache/incubator-shardingsphere/issues/2138 ![图片](https://user-images.githubusercontent.com/44960833/55270434-7ec91900-52d9-11e9-8fb5-ff1b56d3f0b7.png)

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
betterjava commented on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-478195979 Thanks,I will try. This is an automated message from the Apache Git

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread vongosling
I checked all the links that Liang provides. It seems to be the right time to vote for release. juan pan 于2019年3月29日周五 下午8:14写道: > After my items-checking, i think it is time for our 4.0.0-RC1 release. > > Here are my checked items, > > Feature check > > 1. DISTINCT SQL syntax available. > 2.

[GitHub] [incubator-shardingsphere] trojanliu commented on issue #2125: not support count if, database will be the default , not the true

2019-03-29 Thread GitBox
trojanliu commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478069991 This is an automated message

[GitHub] [incubator-shardingsphere] trojanliu commented on issue #2125: not support count if, database will be the default , not the true

2019-03-29 Thread GitBox
trojanliu commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-478069214 `

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2135: When will version 4.0 start?

2019-03-29 Thread GitBox
terrymanu closed issue #2135: When will version 4.0 start? URL: https://github.com/apache/incubator-shardingsphere/issues/2135 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2135: When will version 4.0 start?

2019-03-29 Thread GitBox
terrymanu commented on issue #2135: When will version 4.0 start? URL: https://github.com/apache/incubator-shardingsphere/issues/2135#issuecomment-478058108 FIY:

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
terrymanu commented on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-478057555 You can use reflection to inject mocked logger This is an automated message

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
terrymanu commented on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-478057301 Import new mock dependency is unnecessary. method `log.info()` is not static method, why we have to import power mock to mock this?

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-03-29 Thread GitBox
AlbertTao edited a comment on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478020035 @terrymanu @codefairy08 I just

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-03-29 Thread GitBox
AlbertTao commented on issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101#issuecomment-478020035 @codefairy08 I just try with version

[GitHub] [incubator-shardingsphere] AlbertTao opened a new issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column.

2019-03-29 Thread GitBox
AlbertTao opened a new issue #2101: Sharding-jdbc get different shardingValue between version 3.1.0 and version 2.0.3 when use a string type sharding column. URL: https://github.com/apache/incubator-shardingsphere/issues/2101 Use a string sharding column , suppose the sharding column

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread juan pan
After my items-checking, i think it is time for our 4.0.0-RC1 release. Here are my checked items, Feature check 1. DISTINCT SQL syntax available. 2. Data encrypt available. 3. All SQL 100% compatible if route to single data node (MySQL Only). Release check 1. sha512 hash. 2. gpg Signature. 3.

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread Zhang Yonglun
My tests are focus one the PostgreSQL protocol feature on this release. Here are some test results: PostgreSQL server version: 8.4 and 10.4 Include basic SQLs like INSERT/DELETE/UPDATE/SELECT. Compatibility 1. Support PostgreSQL command line. 2. Support

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result

2019-03-29 Thread GitBox
tuohai666 commented on issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result URL: https://github.com/apache/incubator-shardingsphere/issues/2136#issuecomment-477970029 Could you try to execute the same SQL without sharding-jdbc and watch the results? What

[GitHub] [incubator-shardingsphere] zcqshine opened a new issue #2137: batchSave IndexOutOfBoundsException

2019-03-29 Thread GitBox
zcqshine opened a new issue #2137: batchSave IndexOutOfBoundsException URL: https://github.com/apache/incubator-shardingsphere/issues/2137 ## Bug Report version: `4.0.0-RC1-RELEASE` `4.0.0.RC1-SNAPSHOT` batchInsert will throwable IndexOutOfBoundsException: Index:0, Size 0 err

[GitHub] [incubator-shardingsphere] matchmen opened a new issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result

2019-03-29 Thread GitBox
matchmen opened a new issue #2136: (mybatis + shardingjdbc ) multithreading paging query Incorrect result URL: https://github.com/apache/incubator-shardingsphere/issues/2136 environment: spring boot + mybatis + shatdingjdbc multithreading paging query,database exists enough data;

[GitHub] [incubator-shardingsphere] gaodesen163 opened a new issue #2135: When will version 4.0 start?

2019-03-29 Thread GitBox
gaodesen163 opened a new issue #2135: When will version 4.0 start? URL: https://github.com/apache/incubator-shardingsphere/issues/2135 When will version 4.0 start? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] gaodesen163 removed a comment on issue #2135: When will version 4.0 start?

2019-03-29 Thread GitBox
gaodesen163 removed a comment on issue #2135: When will version 4.0 start? URL: https://github.com/apache/incubator-shardingsphere/issues/2135#issuecomment-477953319 When will version 4.0 start? This is an automated message

[GitHub] [incubator-shardingsphere] gaodesen163 commented on issue #2135: When will version 4.0 start?

2019-03-29 Thread GitBox
gaodesen163 commented on issue #2135: When will version 4.0 start? URL: https://github.com/apache/incubator-shardingsphere/issues/2135#issuecomment-477953319 When will version 4.0 start? This is an automated message from the

Re: [DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread tsubasaotl
Agree to release version 4.0.0-RC1. I've tested some of features and made sure checklists for version 4.0.0-RC1. Following are my tests and checked items. Test features - Sharding-Proxy with MySQL protocol - Basic SQLs like INSERT/DELETE/UPDATE/SELECT - Broadcast table - Solve

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
betterjava edited a comment on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-477932991 @terrymanu PowerMock can do this work. ``` Logger log = PowerMockito.mock(Logger.class);

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
betterjava commented on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-477932991 PowerMock can do this work. ``` Logger log = PowerMockito.mock(Logger.class);

[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #121: add discussion templates

2019-03-29 Thread GitBox
tuohai666 opened a new pull request #121: add discussion templates URL: https://github.com/apache/incubator-shardingsphere-doc/pull/121 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] codefairy08 opened a new issue #2134: MySQL sharding encrypt test

2019-03-29 Thread GitBox
codefairy08 opened a new issue #2134: MySQL sharding encrypt test URL: https://github.com/apache/incubator-shardingsphere/issues/2134 This issue is for sharding encrypt parsing test. when using encryption for sharding, it needs SQL parser doing something for encryption, SQL parser need

[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #120: change community

2019-03-29 Thread GitBox
tristaZero merged pull request #120: change community URL: https://github.com/apache/incubator-shardingsphere-doc/pull/120 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #120: change community

2019-03-29 Thread GitBox
tristaZero opened a new pull request #120: change community URL: https://github.com/apache/incubator-shardingsphere-doc/pull/120 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] osbornjonny opened a new issue #2133: sharding-proxy customer database or table strategy config

2019-03-29 Thread GitBox
osbornjonny opened a new issue #2133: sharding-proxy customer database or table strategy config URL: https://github.com/apache/incubator-shardingsphere/issues/2133 Is there any way config my own custom database or table strategy in sharding-proxy? Maybe support this in the recently

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2081: EncryptDatasource does not support sql which is not DML

2019-03-29 Thread GitBox
tristaZero closed issue #2081: EncryptDatasource does not support sql which is not DML URL: https://github.com/apache/incubator-shardingsphere/issues/2081 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2081: EncryptDatasource does not support sql which is not DML

2019-03-29 Thread GitBox
tristaZero commented on issue #2081: EncryptDatasource does not support sql which is not DML URL: https://github.com/apache/incubator-shardingsphere/issues/2081#issuecomment-477910093 Testing for this issue has been done. Everything is ok.

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
betterjava commented on issue #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127#issuecomment-477906881 I can not find a way to mock a logger for SQLLogger. Mockito can create a mock for Logger,but I can not figure out how to replace real

[GitHub] [incubator-shardingsphere] betterjava closed pull request #2127: #2126 add SQLLoggerTest

2019-03-29 Thread GitBox
betterjava closed pull request #2127: #2126 add SQLLoggerTest URL: https://github.com/apache/incubator-shardingsphere/pull/2127 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] codefairy08 commented on issue #2125: not support count if, database will be the default , not the true

2019-03-29 Thread GitBox
codefairy08 commented on issue #2125: not support count if, database will be the default , not the true URL: https://github.com/apache/incubator-shardingsphere/issues/2125#issuecomment-477904970 @trojanliu thanks for you issue, is 'user' database for sharding ? please show your

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2129: #2081 bug fixs

2019-03-29 Thread GitBox
terrymanu merged pull request #2129: #2081 bug fixs URL: https://github.com/apache/incubator-shardingsphere/pull/2129 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2131: support rlike

2019-03-29 Thread GitBox
terrymanu merged pull request #2131: support rlike URL: https://github.com/apache/incubator-shardingsphere/pull/2131 This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 [RC1]

2019-03-29 Thread zhangli...@apache.org
I'd like to cancel this vote, and discuss for round 2 in thread [1] first. After discuss, I will create new [VOTE] thread for this round. [1] https://lists.apache.org/thread.html/ebdd59188ceee264d6f64823becf9a4ee0ae92ccf85eb30f09f02b17@%3Cdev.shardingsphere.apache.org%3E --

[GitHub] [incubator-shardingsphere] LinXinHun commented on issue #2130: supported hibernate insert values ( )

2019-03-29 Thread GitBox
LinXinHun commented on issue #2130: supported hibernate insert values ( ) URL: https://github.com/apache/incubator-shardingsphere/issues/2130#issuecomment-477891440 My full SQL : `insert into coupon_code_id_generate values ( )` And Exception info :

[DISCUSS] ShardingSphere 4.0.0-RC1 release [ROUND 2]

2019-03-29 Thread zhangli...@apache.org
Hello ShardingSphere Community, This is a call for 2 round of discuss to release Apache ShardingSphere (Incubating) version 4.0.0-RC1 Release notes: *https://github.com/apache/incubator-shardingsphere/releases/tag/untagged-a7276f4b3f5fb99f2c2b

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #2132: ResultSetMetaData for Encrypt ResultSet

2019-03-29 Thread GitBox
tristaZero opened a new issue #2132: ResultSetMetaData for Encrypt ResultSet URL: https://github.com/apache/incubator-shardingsphere/issues/2132 When users use encrypt data source to get encrypt resultset, we need to consider the resultset metadata. Especially, when users use

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 [RC1]

2019-03-29 Thread zhangli...@apache.org
Hi Craig and Sheng, Thank you for your advice. I finally know the reason to cause you confused. > From my understanding, 4.0.0-RC1 is your release version, but not RC1 for 4.0.0 release, I am just guessing this from your release discussion. Yes, you are right. The version of this release is

[GitHub] [incubator-shardingsphere] codefairy08 opened a new pull request #2131: support rlike

2019-03-29 Thread GitBox
codefairy08 opened a new pull request #2131: support rlike URL: https://github.com/apache/incubator-shardingsphere/pull/2131 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an

Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 [RC1]

2019-03-29 Thread ???? Sheng Wu
Hi John I think there is a thing needs to be clear. From my understanding, 4.0.0-RC1 is your release version, but not RC1 for 4.0.0 release, I am just guessing this from your release discussion. So, I would suggest you to take `4.0.0 [RC1] (take 1/round 1)` as part of your discussion/vote

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2129: #2081 bug fixs

2019-03-29 Thread GitBox
coveralls commented on issue #2129: #2081 bug fixs URL: https://github.com/apache/incubator-shardingsphere/pull/2129#issuecomment-477879962 ## Pull Request Test Coverage Report for [Build 7375](https://coveralls.io/builds/22471943) * **0** of **12** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] LinXinHun commented on issue #2130: supported hibernate insert values ( )

2019-03-29 Thread GitBox
LinXinHun commented on issue #2130: supported hibernate insert values ( ) URL: https://github.com/apache/incubator-shardingsphere/issues/2130#issuecomment-477879358 `insert into id_generate values ( )` This is an automated

[GitHub] [incubator-shardingsphere] LinXinHun removed a comment on issue #2130: supported hibernate insert values ( )

2019-03-29 Thread GitBox
LinXinHun removed a comment on issue #2130: supported hibernate insert values ( ) URL: https://github.com/apache/incubator-shardingsphere/issues/2130#issuecomment-477879223 `insert into _id_generate values ( )` This is an

[GitHub] [incubator-shardingsphere] LinXinHun commented on issue #2130: supported hibernate insert values ( )

2019-03-29 Thread GitBox
LinXinHun commented on issue #2130: supported hibernate insert values ( ) URL: https://github.com/apache/incubator-shardingsphere/issues/2130#issuecomment-477879223 `insert into _id_generate values ( )` This is an automated