Re: Talk about how to set committer bar

2019-09-10 Thread Sheng Wu
I would suggest that. Attracting new contributors and committers is our highest priority to us today. Sheng zhangli...@apache.org 于2019年9月10日 周二上午10:02写道: > How about just remove this page from the website? > > -- > > Liang Zhang (John) > Apache ShardingSphere & Dubbo > > >

Re: Talk about how to set committer bar

2019-09-10 Thread zhangli...@apache.org
How about just remove this page from the website? -- Liang Zhang (John) Apache ShardingSphere & Dubbo Sheng Wu 于2019年9月10日周二 上午12:19写道: > Again. > I don't like the static and strict rules for either committer or PPMC. > Consider my as -0 to this. > > Sheng Wu 吴晟 > > Apache

Re: Talk about how to set committer bar

2019-09-10 Thread Sheng Wu
Again. I don't like the static and strict rules for either committer or PPMC. Consider my as -0 to this. Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108 zhangli...@apache.org 于2019年9月10日周二 上午12:15写道: > The

Re: Talk about how to set committer bar

2019-09-10 Thread zhangli...@apache.org
The draft of voting Committer and PPMC: ## Becoming a Committer - Make several pull requests (pull requests should exclude just fix a typo ) - Participate discussion with community actively, include issue on GitHub and apache mailing list - Participate contribution with other way,

Re: Talk about how to set committer bar

2019-09-07 Thread Juan Pan
Agree with William and Sheng. Dynamic and not tight rules will attract more participants to contribute. If he or she can show their commitment to community, we can invite them. Actually, after browsing the Issues and Prs currently in community, i think there are some participants who we can

Re: Talk about how to set committer bar

2019-09-06 Thread zhangli...@apache.org
> I agree that the 6 month guideline is probably too strict. Maybe replace this with a general "Make several high-quality contributions to code, documentation, or mail lists". Agree. Maybe we can separate committers and PPMCs, the original rules are suitable for PPMCs. For committers, better for

Re: Talk about how to set committer bar

2019-09-06 Thread Craig Russell
I agree that the 6 month guideline is probably too strict. Maybe replace this with a general "Make several high-quality contributions to code, documentation, or mail lists". The 6 month guideline might be more appropriate for PPMC members. And "understanding the core technology deeply" will

Re: Talk about how to set committer bar

2019-09-06 Thread Sheng Wu
> > -- 原始邮件 -- > > 发件人: "zhangli...@apache.org"; > > 发送时间: 2019年9月6日(星期五) 上午10:49 > > 收件人: "dev"; > > > > 主题: Re: Talk about how to set committer bar > > > > > > > > Ok, we can set the co

Re: Talk about how to set committer bar

2019-09-06 Thread ??????
Sothecontributionssomeonemakesisambiguous.Ijustmentionthatthing. Butwhatever,thecommunitywillknowwhomakescontributions. Inconclusion,Iapprovetherules. ---Original--- From: zhangli...@apache.org

Re: Talk about how to set committer bar

2019-09-06 Thread zhangli...@apache.org
I agree with the rules. > > > But the question is ,such as rule 3, we may not have effect method to > meature how much contributions someone makes. > > > lulu > > > -- 原始邮件 -- > 发件人: "zhangli...@apache.org"; > 发送时间: 2019年9月6日(

?????? Talk about how to set committer bar

2019-09-06 Thread ??????
dev"; ????: Re: Talk about how to set committer bar Ok, we can set the committer bar more dynamic for different stage. Right now, the rules may include: 1. Contribute codes, contributor may contribute several pull requests. 2. Answer questions and participant discussion on Github and mail

Re: Talk about how to set committer bar

2019-09-06 Thread Justin Mclean
Hi, There are many ways someone can contribute, writing documentation or tests, helping users, reviewing release candidates, cleaning up the website etc etc it's not just code. Thanks, Justin

Re: Talk about how to set committer bar

2019-09-05 Thread zhangli...@apache.org
Ok, we can set the committer bar more dynamic for different stage. Right now, the rules may include: 1. Contribute codes, contributor may contribute several pull requests. 2. Answer questions and participant discussion on Github and mailing list actively. 3. Other things for participant and

Re: Talk about how to set committer bar

2019-09-05 Thread Justin Mclean
Hi, Again each project is different and sets their own committer bar, but I wouldn't worry so much about the PR being perfect either, they can always be fixed and improved. By setting the quality bar too high people may not contribute because they don't think this code is good enough, even

Re: Talk about how to set committer bar

2019-09-05 Thread Justin Mclean
Hi, > Yeah, I aggree, if the person can show his commitment to the > community, we should invite him or her to be a committer. > But here is a problem what can we do if the person doesn't involove > any activity of the community once he gets the committer right? There is no problem with this.

Re: Talk about how to set committer bar

2019-09-05 Thread Sheng Wu
>From my personal experience, I would worry about this much. In SkyWalking, some contributors(committers) come and go, but mostly, they are around, keep contributing in different ways. Such as answering questions, talk about the project in public conf/event. Feedback about the use case in

Re: Talk about how to set committer bar

2019-09-05 Thread Willem Jiang
Yeah, I aggree, if the person can show his commitment to the community, we should invite him or her to be a committer. But here is a problem what can we do if the person doesn't involove any activity of the community once he gets the committer right? Willem Jiang Twitter: willemjiang Weibo:

Re: Talk about how to set committer bar

2019-09-05 Thread Sheng Wu
+1 for this. For me, I think sharding is lacking about diversity contribution mechanism too. The major thing needs to improve before we think about graduation. Justin Mclean 于2019年9月5日 周四下午2:22写道: > Hi, > > > And we can discuss how many pull requests is necessary for elect. > > And contribution

Re: Talk about how to set committer bar

2019-09-05 Thread Justin Mclean
Hi, > And we can discuss how many pull requests is necessary for elect. And contribution can be for things other than code or PRs. Thanks, Justin

Re: Talk about how to set committer bar

2019-09-05 Thread Sheng Wu
Hi > How about change `Make contributions consistently during the past 6 months` to `Submit 5 quality pull requests`? >From this moment, I think this requirement is a little too high. We haven't elected new committer for a long time, especially out of JD original team. I think if 3+ code commits

Re: Talk about how to set committer bar

2019-09-05 Thread Zheng Feng
OK, I agree and maybe 2 or 3 Quality PR are enough to vote. We need more committers to involve in the community. zhangli...@apache.org 于2019年9月5日周四 下午10:17写道: > > What is the "Quality PR" ? e.g. introduce a new feature or fix a very > internal bug ? > > "Quality PR" means fix bug or dev new

Re: Talk about how to set committer bar

2019-09-05 Thread Zheng Feng
I think we could also consider the activities in the community, such as proposal a topic in the mailing list, raise an issue on the github and involve in the discuss to help the other people to resolve the problem. zhangli...@apache.org 于2019年9月5日周四 下午10:08写道: > How about change `Make

Re: Talk about how to set committer bar

2019-09-05 Thread zhangli...@apache.org
> What is the "Quality PR" ? e.g. introduce a new feature or fix a very internal bug ? "Quality PR" means fix bug or dev new feature, "Quality PR" should exclude a PR only fix a typo -- Liang Zhang (John) Apache ShardingSphere & Dubbo Zheng Feng 于2019年9月5日周四 下午10:12写道: >

Re: Talk about how to set committer bar

2019-09-05 Thread Zheng Feng
What is the "Quality PR" ? e.g. introduce a new feature or fix a very internal bug ? zhangli...@apache.org 于2019年9月5日周四 下午10:08写道: > How about change `Make contributions consistently during the past 6 months` > to `Submit 5 quality pull requests`? > > And we can discuss how many pull requests

Re: Talk about how to set committer bar

2019-09-05 Thread zhangli...@apache.org
Hi Zheng, > Enable Google Two-factor authentication Apache committer must Enable 2FA to login their github, otherwise he will be removed from the organization. -- Liang Zhang (John) Apache ShardingSphere & Dubbo zhangli...@apache.org 于2019年9月5日周四 下午10:07写道: > How about

Re: Talk about how to set committer bar

2019-09-05 Thread zhangli...@apache.org
How about change `Make contributions consistently during the past 6 months` to `Submit 5 quality pull requests`? And we can discuss how many pull requests is necessary for elect. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Zheng Feng 于2019年9月5日周四 下午9:57写道: > I agree

Re: Talk about how to set committer bar

2019-09-05 Thread Zheng Feng
I agree with Justin that we vote the committers more often. Justin Mclean 于2019年9月5日周四 下午9:46写道: > Hi, > > >1. Make contributions consistently during the past 6 months > >2. Understand the core technology of ShardingSphere deeply > >3. Obey the Code of Conduct > >4. Submit

Re: Talk about how to set committer bar

2019-09-05 Thread Justin Mclean
Hi, >1. Make contributions consistently during the past 6 months >2. Understand the core technology of ShardingSphere deeply >3. Obey the Code of Conduct >4. Submit high-quality content >5. Enable Google Two-factor authentication While each PPMC/PMC can set their own bar this

Re: Talk about how to set committer bar

2019-09-05 Thread Zheng Feng
Why we need the 5. Enable Google Tow-factor authentication ? zhangli...@apache.org 于2019年9月5日周四 下午9:29写道: > Hi ShardingSphere community, > > There are 64 contributors for ShardingSphere, I want discuss about elected > more committers. > > How to set committer bar? The previous rules can find

Talk about how to set committer bar

2019-09-05 Thread zhangli...@apache.org
Hi ShardingSphere community, There are 64 contributors for ShardingSphere, I want discuss about elected more committers. How to set committer bar? The previous rules can find here[1], they are: 1. Make contributions consistently during the past 6 months 2. Understand the core technology