Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi, Thanks for Willem and Sheng's reminder. I have put the wrong link of Maven 2 staging repository. The link is updated to: Maven 2 staging repository: https://repository.apache.org/content/repositories/orgapacheshardingsphere-1022/org/apache/shardingsphere/ We have updated the release

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi Craig, We have updated the release doc[1] to fix the two problems you mentioned so that we can use correct mail template the next time. 1. Use PPMC member instead of binding while community instead of non-binding in the vote result announcement. 2. Add note to invite all mentors to vote

Re:Re: [DISCUSS] Do we have to resolve issue #2884 in 4.0.0-RC2

2019-08-20 Thread Sion Yang
I think so, DML for encrypt can work well now. Users can create table by themselves instead of by JPA to solve the problem. We can complete DDL for encrypt at next release. -- Yi Yang(Sion) Apache ShardingSphere 在 2019-08-21 12:08:42,"zhangli...@apache.org" 写道: >Because it is not a

Re: [DISCUSS] Do we have to resolve issue #2884 in 4.0.0-RC2

2019-08-20 Thread zhangli...@apache.org
Because it is not a blocking issue, we don't do ddl for data mask now, (data mask only for DML), so I prefer leave this issue for now, we can fix this issue at next release. -- Liang Zhang (John) Apache ShardingSphere & Dubbo juan pan 于2019年8月21日周三 上午11:09写道: > Ok, so that we

Re: [DISCUSS] Do we have to resolve issue #2884 in 4.0.0-RC2

2019-08-20 Thread juan pan
Ok, so that we can have more time to take care of it, and yesterday one volunteer also showed interest on it. So i think fixing it in our next version is better. - Juan Pan (Trista) Apache ShardingSphere Zhang Yonglun 于2019年8月21日周三 上午10:58写道: > Hi, > > I think

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi Craig, Thanks for your reminder. I understand that a key motto at Apache is “If it didn’t happen on the mailing list, it didn’t happen.” I have called for a discussion for the issue 2884. You can find it in this thread:

[DISCUSS] Do we have to resolve issue #2884 in 4.0.0-RC2

2019-08-20 Thread Zhang Yonglun
Hi, I think this issue ( https://github.com/apache/incubator-shardingsphere/issues/2884) is not a serious or block bug. What's your opinion on this? I suggest to resolve this problem in the next release. -- Zhang Yonglun Apache ShardingSphere

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Sheng Wu
One question Why does not your staging repo include number? > Maven 2 staging repository: > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ There should be a link related to each release process. Please check, if so, I think you just missed deleting old

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Willem Jiang
Sorry, I was traveling last two days and just missed the vote. I just had a quick check of the release kit, most of them are OK but for the staging repo[1] I found there is a RC1 version beside RC2, which means if we do the release in Maven repo, we will publish the RC1 and RC2 version at the same

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, I'd like to suggest that when a release vote does not get all mentors to vote, we should ping them so the IPMC vote is just a formality. This results in a lot less stress on everyone in the incubator community. If mentors respond that they are just too busy right now, we should accept that

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

2019-08-20 Thread Craig Russell
Hi Yonglun, Where was the discussion about the issue 2884? I cannot find it in the mail archives. Regards, Craig > On Aug 16, 2019, at 9:33 PM, Zhang Yonglun wrote: > > The issue #2884 mentioned by Sion Yang was determined to be fixed in the > next release. > > So, the discussion is

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, We should not use "binding" as a term when referring to votes of PPMC members. Binding has a specific meaning in Apache that for release votes means IPMC. Better to use "6 PPMC member +1 votes" and "1 community +1 vote". You can refer to "mentor" votes as "binding" but it's better just to

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
The vote to release Apache ShardingSphere (Incubating) 4.0.0-RC2 has passed. 6 binding +1 votes: Liang Zhang Juan Pan Craig L Russell (mentor) Yi Yang Hao Cao Von Gosling (mentor) 1 non-binding +1 vote: Haisheng Sun Gosling Von 于2019年8月20日周二 上午11:28写道: > > Thanks for your prompt reply. > >

ShardingSphere

2019-08-20 Thread jsbxyyx
Hi: subscribe