Re: project web site with shindig

2010-03-08 Thread 王超
Hi VU, are u using Java Shindig or PHP one? You may like to add some debug lines like console.info(gadgets.rpc); etc. among the sample container code, and check its output in Firebug. Hope it helps, Jacky On Mon, Mar 8, 2010 at 5:32 PM, VU, Thi Thu Thuy thi.thu.thuy...@sap.comwrote: Hi all,

RE: project web site with shindig

2010-03-08 Thread VU, Thi Thu Thuy
I use java shindig. But I really don't understand much about these examples. I don't find any code which indicates that it already used some libraries from shindig. So, how it run? For example file samplecontainer.html. It run by which library from shindig? Besides, I tried to used object

run shindig with tomcat

2010-03-08 Thread VU, Thi Thu Thuy
Hi I really want to use shindig with tomcat (not with jetty). So, I created a project web site with shindig. But, I didn't work well. Does anyone do that Can you help me? Thanks a lot

RE: Errors in end to end tests?

2010-03-08 Thread Jordan Zimmerman
Yes - I'm sending this email from that account now. Jordan Zimmerman Principal Software Architect 831.647.4712 831.214.2990 (cell) jord...@shop.com SHOP*COMTM Shop Smart, Save Big(tm) www.shop.com Join us on Facebook. Follow us on Twitter. Read The Shopping Vine. -Original

Re: Errors in end to end tests?

2010-03-08 Thread Paul Lindner
okay, can you try one last time and save the messages with full headers I can help these guys track it down? Send to dev-unsubscr...@shindig.apache.org Thanks On Mon, Mar 8, 2010 at 1:00 PM, Jordan Zimmerman jord...@shop.com wrote: Yes - I'm sending this email from that account now.

Re: UserPrefsDialog results in jsonp call to http://gmodules.com/ig?

2010-03-08 Thread Paul Lindner
I'd love to see someone take this patch and make it generic.. If I had some spare cycles I'd do it myself... On Fri, Mar 5, 2010 at 5:01 PM, Robert Peterson juzzam.shin...@gmail.comwrote: This answers my question: http://issues.apache.org/jira/browse/SHINDIG-1188 For our project, we will

Re: Taming osapi (issue223109)

2010-03-08 Thread johnfargo
nits http://codereview.appspot.com/223109/diff/6001/4004 File features/src/main/javascript/features/core.json/json.js (right): http://codereview.appspot.com/223109/diff/6001/4004#newcode56 features/src/main/javascript/features/core.json/json.js:56: if (!/___$/.test(k)) worth precompiling

Re: Use ProxyUriManager in CajaCssSanitizer (issue223093)

2010-03-08 Thread John Hjelmstad
On Fri, Mar 5, 2010 at 10:41 AM, zhor...@gmail.com wrote: LGTM The more I read, the more I like the original interface LinkRewriter. Maybe UriManager should at least implement the LinkRewriter interface? As perhaps noted elsewhere, UriManager really is LinkRewriter, but provided

Re: Use ProxyUriManager in CssRequestRewriter (issue224093)

2010-03-08 Thread John Hjelmstad
Good call, fixed, thx! On Fri, Mar 5, 2010 at 11:49 AM, zhor...@gmail.com wrote: LGTM http://codereview.appspot.com/224093/diff/2001/2003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java (right):

Re: Refactor ConcatLinkRewriter as a Visitor (issue224097)

2010-03-08 Thread John Hjelmstad
On Fri, Mar 5, 2010 at 5:41 PM, zhor...@gmail.com wrote: http://codereview.appspot.com/224097/diff/2001/2003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatLinkRewriter.java (right): http://codereview.appspot.com/224097/diff/2001/2003#newcode122

Re: Refactor ConcatLinkRewriter as a Visitor (issue224097)

2010-03-08 Thread johnfargo
Renamed ConcatVisitor; tweaked tests per zhoresh's comments. http://codereview.appspot.com/224097/show

Re: Refactor ConcatLinkRewriter as a Visitor (issue224097)

2010-03-08 Thread zhoresh
LGTM http://codereview.appspot.com/224097/diff/11001/12002 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java (right): http://codereview.appspot.com/224097/diff/11001/12002#newcode194

Re: StyleTagExtractorVisitor implementation (issue223098)

2010-03-08 Thread John Hjelmstad
On Sun, Mar 7, 2010 at 11:17 AM, zhor...@gmail.com wrote: http://codereview.appspot.com/223098/diff/2001/2003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagContentRewriter.java (right): http://codereview.appspot.com/223098/diff/2001/2003#newcode33

Re: StyleTagExtractorVisitor implementation (issue223098)

2010-03-08 Thread johnfargo
Updated naming; integration test stub. http://codereview.appspot.com/223098/show

Re: Refactor ProxyingLinkRewriter into a Visitor (issue224094)

2010-03-08 Thread johnfargo
Integration test stub, renaming for consistency. http://codereview.appspot.com/224094/show

Re: StyleTagExtractorVisitor implementation (issue223098)

2010-03-08 Thread zhoresh
On 2010/03/09 01:23:51, johnfargo wrote: Updated naming; integration test stub. LGTM http://codereview.appspot.com/223098/show

Re: Introduce ScriptTagContentRewriter (issue223099)

2010-03-08 Thread johnfargo
Added (now-boilerplate) TBD test stub. http://codereview.appspot.com/223099/show

Re: Taming osapi (issue223109)

2010-03-08 Thread jasvir
http://codereview.appspot.com/223109/diff/6001/4004 File features/src/main/javascript/features/core.json/json.js (right): http://codereview.appspot.com/223109/diff/6001/4004#newcode56 features/src/main/javascript/features/core.json/json.js:56: if (!/___$/.test(k)) On 2010/03/08 22:45:11,

Re: Refactor ProxyingLinkRewriter into a Visitor (issue224094)

2010-03-08 Thread John Hjelmstad
Thanks again Ziv! Comments inline. On Mon, Mar 8, 2010 at 6:08 PM, zhor...@gmail.com wrote: LGTM (Sorry previous mail didn't take comment...) http://codereview.appspot.com/224094/diff/16001/17004 File