Re: Cleaning up warnings (issue1807042)

http://codereview.appspot.com/1807042/diff/14001/15001 File java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java (right): http://codereview.appspot.com/1807042/diff/14001/15001#newcode629 java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.ja

Re: Uploading and storing files data

Hi John, About Jira, I've found this https://issues.apache.org/jira/browse/SHINDIG-738, but I don't have the permissions to assign it to me, my username is gguardin. Question about the spec: >From what I understand from the spec, when you upload a content, it should be upload to some Data Object

Re: Handling post requests for Accel servlet (issue1822041)

beautification http://codereview.appspot.com/1822041/show

Re: Handling post requests for Accel servlet (issue1822041)

adding tests http://codereview.appspot.com/1822041/show

Handling post requests for Accel servlet (issue1822041)

Reviewers: johnfargo, zhoresh, shindig.remailer_gmail.com, dev-remailer_shindig.apache.org, cool-shindig-committers_googlegroups.com, Please review this at http://codereview.appspot.com/1822041/show Affected files: main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java main/java

Remove ApiServlet.checkContentTypes public method in favor of ContentTypes.checkContentTypes (issue1820041)

Reviewers: dev-remailer_shindig.apache.org, Message: Simple change to remove ApiServlet.checkContentTypes method to use ContentTypes.checkContentTypes method instead. Description: The ApiServlet.checkContentTypes method it is just a simple wrapper to ContentTypes.checkContentTypes and its not us

Re: Support startIndex and count in os:ActivitiesRequest (issue1756043)

+...@shindig.apache.org Doesn't look like the original email was dispatched by dev-remai...@shindig.apache.org. On Fri, Jul 9, 2010 at 10:35 AM, wrote: > Reviewers: dev-remailer_shindig.apache.org, > > Description: > Add support for startIndex and count in os:ActivitiesRequest. > > These attrib

Re: Cleaning up warnings (issue1807042)

http://codereview.appspot.com/1807042/diff/5001/6003 File java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java (right): http://codereview.appspot.com/1807042/diff/5001/6003#newcode65 java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:

Re: UserPref server side

>From what I've seen so far, the UserPrefs are mainly client-driven. It is up to your implementation to pass in the the UP values to the client container so that they can be added to the iframe url. The sample container uses a metadata rpc call to get the UP metadata and default values from the Ga

UserPref server side

I'm trying figure out how to get the shindig server to pull up my (to- be) persistent user preferences, mainly to use the __UP...__ substitution at this point. I see where all that substitution takes place in java, but I haven't been able to find where the server loads them up (except for t

Re: Cleaning up warnings (issue1807042)

http://codereview.appspot.com/1807042/diff/5001/6003 File java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java (right): http://codereview.appspot.com/1807042/diff/5001/6003#newcode65 java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:

Re: Cleaning up warnings (issue1807042)

http://codereview.appspot.com/1807042/diff/1/2 File java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java (right): http://codereview.appspot.com/1807042/diff/1/2#newcode624 java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java:624: public b

Re: DefaultJsUriManager no longer replaces %host%, %js%

On Sat, Jul 10, 2010 at 7:23 PM, Michael Young wrote: > For some reason my first reply was rejected by the moderator at > dev-ow...@shindig... Here it is again: > > Thanks for the reply, John. I will use the interim solution, for now. > > I noticed that SERVER_PORT is injected into the JsonContain

Re: Adding database to Java Shindig

Hi Evgeny. I have my own guice module based on JPA. On Mon, Jul 12, 2010 at 5:56 PM, Evgeny Bogdanov wrote: > The same problem is with a branches/2.0.x/ > > Franck, How did you add your own Guice JPA? > this is from my web.xml guice-modules org.apache.shindig.common.PropertiesModule: org.ap

Re: Adding database to Java Shindig

The same problem is with a branches/2.0.x/ Franck, How did you add your own Guice JPA? Did you also register it in web.xml and added a module into profile "all" in shindig/pom.xml? Or did you add some dependencies? On 12.07.10 15:59, franck tankoua wrote: http://svn.apache.org/repos/asf/shindi

Re: Adding database to Java Shindig

http://svn.apache.org/repos/asf/shindig/branches/2.0.x/ On Mon, Jul 12, 2010 at 3:49 PM, Evgeny Bogdanov wrote: > Where do you take shindig 2.0 release (I can't find it)? Or do you mean > trunk here? > > > On 12.07.10 15:18, franck tankoua

Re: Adding database to Java Shindig

Where do you take shindig 2.0 release (I can't find it)? Or do you mean trunk here? On 12.07.10 15:18, franck tankoua wrote: I am using my own JPA implementation and the shindig 2.0 release. things work fine so far. I will try to add JPAModule and let you know. which version of shindig are you

Re: Adding database to Java Shindig

Yes, trunk version (I'll try also to use 2.0 release) Do I need to install java ee for it to work (I have java sdk 6)? On 12.07.10 15:18, franck tankoua wrote: I am using my own JPA implementation and the shindig 2.0 release. things work fine so far. I will try to add JPAModule and let you kno

Re: Adding database to Java Shindig

I am using my own JPA implementation and the shindig 2.0 release. things work fine so far. I will try to add JPAModule and let you know. which version of shindig are you using? the trunk version ? On Mon, Jul 12, 2010 at 2:38 PM, Evgeny Bogdanov wrote: > Thank you Franck for helping! > > still t

Re: Adding database to Java Shindig

This is a full jetty log $ mvn jetty:run [INFO] Scanning for projects... [INFO] [INFO] Building Apache Shindig Web App [INFO]task-segment: [jetty:run] [INFO] ---

Re: Adding database to Java Shindig

Thank you Franck for helping! still the same Does it work for you? On 12.07.10 14:27, franck tankoua wrote: what if you remove the space line before JPASocialModule? On Mon, Jul 12, 2010 at 2:25 PM, Evgeny Bogdanovwrote: On 12.07.10 14:19, franck tankoua wrote: Just out of curio

Re: Adding database to Java Shindig

what if you remove the space line before JPASocialModule? On Mon, Jul 12, 2010 at 2:25 PM, Evgeny Bogdanov wrote: > > > On 12.07.10 14:19, franck tankoua wrote: > >> Just out of curiosity. which version are you using? >> >> > Do you mean shindig? (latest trunk shindig) > $ mvn --version > Apache

Re: Adding database to Java Shindig

On 12.07.10 14:19, franck tankoua wrote: Just out of curiosity. which version are you using? Do you mean shindig? (latest trunk shindig) $ mvn --version Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) Java version: 1.6.0_20 Java home: /System/Library/Frameworks/JavaVM.framework/Vers

Re: Adding database to Java Shindig

Just out of curiosity. which version are you using? could you paste also the web.xml param-value for your param-name * guice-modules* . On Mon, Jul 12, 2010 at 2:04 PM, Evgeny Bogdanov wrote: > Probably misunderstood you before ... > I did now: > $cd java/samples > $mvn > Build Successful > >

Re: Adding database to Java Shindig

Probably misunderstood you before ... I did now: $cd java/samples $mvn Build Successful On 12.07.10 13:02, franck tankoua wrote: were you able to successfully run mvn at /java/samples level? On Mon, Jul 12, 2010 at 12:57 PM, Evgeny Bogdanov wrote: Sorry for spamming but I still can't get

Re: Adding database to Java Shindig

Yes, it said "build is successful" for all profiles (samples, all, reporting) [INFO] Reactor Summary: [INFO] [INFO] Apache Shindig Project SUCCESS [2.878s] [INFO] Apache Shindig Features .

Enabling StyleTagProxyEmbeddedUrlsRewriter for accel (issue1813041)

Reviewers: johnfargo, zhoresh, shindig.remailer_gmail.com, dev-remailer_shindig.apache.org, cool-shindig-committers_googlegroups.com, Please review this at http://codereview.appspot.com/1813041/show Affected files: RewriteModule.java Index: RewriteModule.java

Re: Adding database to Java Shindig

were you able to successfully run mvn at /java/samples level? On Mon, Jul 12, 2010 at 12:57 PM, Evgeny Bogdanov wrote: > Sorry for spamming but I still can't get a working version. > > This is what I did based on the suggestions here. > > 1) I've checked out a latest shindig version. > 2) I added

Adding database to Java Shindig

Sorry for spamming but I still can't get a working version. This is what I did based on the suggestions here. 1) I've checked out a latest shindig version. 2) I added a Guice module "org.apache.shindig.social.opensocial.jpa.spi.JPASocialModule:" into java/server/src/main/webapp/WEB-INF/web.xml

Re: Returning same status code as fetched (issue1811042)

On 2010/07/12 09:27:19, gagan.goku wrote: fixing tests Comment addressed. http://codereview.appspot.com/1811042/show

Re: Returning same status code as fetched (issue1811042)

fixing tests http://codereview.appspot.com/1811042/show

Re: Returning same status code as fetched (issue1811042)

http://codereview.appspot.com/1811042/diff/1/2 File servlet/AccelHandler.java (right): http://codereview.appspot.com/1811042/diff/1/2#newcode217 servlet/AccelHandler.java:217: response.sendError(results.getHttpStatusCode(), ERROR_FETCHING_DATA); Shouldn't we retain the error mesg in the results

Returning same status code as fetched (issue1811042)

Reviewers: johnfargo, zhoresh, shindig.remailer_gmail.com, dev-remailer_shindig.apache.org, cool-shindig-committers_googlegroups.com, Description: Returning the error http status code as the fetched resource. Since we want to proxy the resource through, we want the user to see the exact code re

Cleaning up warnings (issue1807042)

Reviewers: johnfargo, Description: Simple clean up * getting rid of the unused imports * added .equals() on classes that have a .compare() * corrected misuse of == instead of .equals() for testing strings * replace repeated string concat with a stringbuffer Please review this at http://coderevi

Re: Cleaning up HtmlAccelServlet (issue1798042)

fixing bad things http://codereview.appspot.com/1798042/show