Re: Felix Lee as Shindig Committer

2011-06-25 Thread Chirag Shah
Congratulations Felix! 2011/6/23 ๏̯͡๏ Jasvir Nagra jas...@google.com: The votes are in. Congratulations Felix Lee on becoming a Shindig committer! On Wed, Jun 15, 2011 at 2:41 PM, Ziv Horesh zhor...@gmail.com wrote: +1 On Wed, Jun 15, 2011 at 2:30 PM, Henry Saputra

Re: Review Request: Fix some osapi+caja onload timing issues

2011-06-15 Thread Chirag Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/795/#review845 --- Ship it! - Chirag On 2011-05-27 20:06:44, Felix Lee wrote:

Re: container accel

2010-10-18 Thread Chirag Shah
Hi Gagandeep, I was wondering how accel distinguishes itself from other HTTP reverse cache proxies such as squid, apache traffic server, and varnish? Squid and ATS both implement HTTP cache-control extensions such as http-stale-while-revalidate/http-stale-while-error. Currently the only

Re: Adding an html parser router (issue2119043)

2010-10-04 Thread Chirag Shah
Wouldn't Google Guice annotations[1] would solve this problem. Example Bind: bind(GadgetHtmlParser.class) .annotatedWith(Names.named(parser-accel)) .to(CajaHtmlParser.class); Inject: @Inject public Accel(@Named(parser-acce) GadgetHtmlParser parser, ...

Re: aKey in web.xml

2010-09-30 Thread Chirag Shah
Hey Michael, Hm good question. I tracked the origin of aKey down to this change http://svn.apache.org/viewvc/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml?r1=957770r2=990263 but I'm not sure how it's used. On Fri, Sep 24, 2010 at 3:07 PM, Michael Young michael.yo...@liferay.com

Re: OpenSocial gadget editor (issue2203047)

2010-09-27 Thread Chirag Shah
Resending to d...@shindig.apache.org.. On Mon, Sep 27, 2010 at 9:55 PM, chiragsh...@gmail.com wrote: Reviewers: dev-remailer_shindig.apache.org, Paul Lindner, Description: This is a simple opensocial gadget editor that allows developers to quickly test their gadgets against Shindig.

Re: Did not receive emails to dev-remai...@shindig.apache.org for codereview requests

2010-09-21 Thread Chirag Shah
I'm seeing the same issue. I try to resend the code review to dev@ manually if I don't see it appear on markmail http://shindig-dev.markmail.org/search/?q= On Tue, Sep 21, 2010 at 11:58 AM, Paul Lindner lind...@inuus.com wrote: Sometimes the spam filter at apache flags the email to dev-remailer

Re: Don't return in CajaContentRewriter's finally clause (issue2152046)

2010-09-14 Thread Chirag Shah
) at com.google.caja.parser.quasiliteral.DefaultValijaRewriter$42.fire(DefaultValijaRewriter.java:1343) The test case works when the properties inside tests are removed. On Mon, Sep 13, 2010 at 2:34 PM, Chirag Shah chiragsh...@gmail.com wrote: This change surfaces several (rather odd) unit test

Re: Don't return in CajaContentRewriter's finally clause (issue2152046)

2010-09-14 Thread Chirag Shah
inside tests are removed. On Mon, Sep 13, 2010 at 2:34 PM, Chirag Shah mailto:chiragsh...@gmail.com wrote: This change surfaces several (rather odd) unit test failures in EndToEndTest. Do you see the same errors? java.lang.AssertionError nbsp; nbsp; nbsp; nbsp

Re: Don't return in CajaContentRewriter's finally clause (issue2152046)

2010-09-13 Thread Chirag Shah
This change surfaces several (rather odd) unit test failures in EndToEndTest. Do you see the same errors? java.lang.AssertionError at com.google.caja.lexer.FilePosition.lt;initgt;(FilePosition.java:52) at com.google.caja.lexer.SourceBreaks.toFilePosition(SourceBreaks.java:73)

Re: [VOTE] Approve Gagandeep singh as Shindig Committer

2010-08-20 Thread Chirag Shah
+1 On Thu, Aug 19, 2010 at 10:46 PM, Paul Lindner lind...@inuus.com wrote: I would like to propose that Gagandeep Singh be granted committer access to Shindig along with PMC membership if desired. WIth over 20 accepted patches, numerous reviews of code and all around activity I believe

Re: Fix default EL functions (issue1885042)

2010-07-29 Thread Chirag Shah
Doesn't look like the code review was dispatched by dev-remai...@shindig.apache.org. Resending to dev@shindig.apache.org Thanks, Chirag On Thu, Jul 29, 2010 at 11:21 AM, chiragsh...@gmail.com wrote: Reviewers: dev-remailer_shindig.apache.org, shindig.remailer_gmail.com, Description: This

Re: Support startIndex and count in os:ActivitiesRequest (issue1756043)

2010-07-12 Thread Chirag Shah
+...@shindig.apache.org Doesn't look like the original email was dispatched by dev-remai...@shindig.apache.org. On Fri, Jul 9, 2010 at 10:35 AM, chiragsh...@gmail.com wrote: Reviewers: dev-remailer_shindig.apache.org, Description: Add support for startIndex and count in

Re: Shindig OpenSocial 0.9 Templating (Custom Tags)

2010-07-01 Thread Chirag Shah
in the PHP implementation. Are the php and java efforts co-ordinated in terms of what functionality goes in them per release ? Please help -- I really need these tags to work in shindig Many Thanks JP -Original Message- From: Chirag Shah [mailto:chir...@yahoo-inc.com] Sent: Tuesday

RE: Shindig OpenSocial 0.9 Templating (Custom Tags)

2010-06-29 Thread Chirag Shah
Hey JP, It looks like the second text/os-template block is missing the xmlns declaration. Try this: ?xml version=1.0 encoding=UTF-8 ? Module ModulePrefs title= Require feature=opensocial-0.9 / Require feature=opensocial-templates/ /ModulePrefs Content type=html

Re: Is ImageUtils.getSacledInstance() LGPL license?

2010-05-27 Thread Chirag Shah
org.jdesktop.swingx.graphics.GraphicsUtilities#createThumbnail is very similar and is LGPL/BSD. GraphicsUtilities is referenced in the article and can still be found here: https://swingx.dev.java.net/files/documents/2981/149644/swingx-2010_04_18-src.zip Thanks, Chirag On Thu, May 27, 2010 at

Re: Passing params to a view

2010-05-21 Thread Chirag Shah
This isn't documented very well, but try adding the following to the url. The representation of view-param is json. url += 'view-params=' + encodeURIComponent(paramStr); Thanks, Chirag On Fri, May 21, 2010 at 11:38 AM, Jason Eggers jason.egg...@infinitecampus.com wrote: Does anyone know how to

Re: data pipeline and template gadets for testing

2010-05-14 Thread Chirag Shah
Hey Han, Here are a few links to help you get started. OpenSocial Templates doc: http://wiki.opensocial.org/index.php?title=OpenSocial_Templates Data Pipelining doc: http://wiki.opensocial.org/index.php?title=Data_Pipelining Example gadget xml: http://chiarg.com/opensocial/http.xml Thanks,

Re: [2.0] Removing some @Deprecated classes/methods/features

2010-05-13 Thread Chirag Shah
While we're at it.. what do you think about adding RestfulCollection(ListT entry, CollectionOptions options), and deducing startIndex (from options), totalResults (from entry), itemsPerPage (from options)? Thanks, Chirag On Thu, May 13, 2010 at 4:26 PM, Paul Lindner plind...@linkedin.com wrote:

Re: upgrade to servlet-api 2.5

2010-05-12 Thread Chirag Shah
+1 On Wed, May 12, 2010 at 12:12 PM, Paul Lindner plind...@linkedin.com wrote: I'm going ahead with this change * web.xml has already had servlet-2.5 markup for a long time... * I forgot that I raised this issue long ago and no one complained. On Wed, May 12, 2010 at 11:20 AM, Paul Lindner

Re: [VOTE] Ziv Horesh as Shindig Committer

2010-04-13 Thread Chirag Shah
d...@apache.org Chico Charlesworth ch...@apache.org Chirag Shahchi...@apache.org [2010-02-20] Chris Chabot chab...@apache.org Daniel Petersondpeter...@apache.org Evan Gilbert e...@apache.org Henning

Re: trunk unstable...

2010-03-17 Thread Chirag Shah
send the sample code? The gadgets in the endtoend test use osapi and they're working fine. On Wed, Mar 17, 2010 at 10:09 AM, Chirag Shah chiragsh...@gmail.com wrote: It looks like most osapi methods aren't working for me on trunk. Is this true for anybody else? Here's the gadget i'm using