[RESULT] [VOTE] Release Apache Shiro 1.4.1

2019-04-30 Thread fpapon
Hi, This vote passed with the following result: +1 (binding): Les Hazlewood, Brian Demers, François Papon +1 (non binding): Tamás Cservenák, Jean-Baptiste Onofré, Stephen Agyepong I'm promoting the artifacts on Central and dist.apache.org, update website and Jira, I will then announce the

Re: [VOTE] Release Apache Shiro 1.4.1

2019-04-30 Thread Brian Demers
Thanks François! +1 On Tue, Apr 30, 2019 at 1:43 PM Francois Papon wrote: > Hi Brian, > > Thanks for catching this! > > You're right, I forgot to tag the vote and it's ok now: > > > https://github.com/apache/shiro/compare/master...shiro-root-1.4.1-release-vote1 > > regards, > > François Papon

Re: [VOTE] Release Apache Shiro 1.4.1

2019-04-30 Thread Francois Papon
Hi Brian, Thanks for catching this! You're right, I forgot to tag the vote and it's ok now: https://github.com/apache/shiro/compare/master...shiro-root-1.4.1-release-vote1 regards, François Papon fpa...@apache.org Le 30/04/2019 à 18:58, Brian Demers a écrit : > I'm -1, due to the fact the

Re: [VOTE] Release Apache Shiro 1.4.1

2019-04-30 Thread Brian Demers
I'm -1, due to the fact the tag isn't available for inspection (I'm sure I've done this too). That said I took a look at where master is now compared to 1.4.0 and there are no surprises, I've also run the staged build through a couple of projects without issue. I suggest the tag is pushed as

[GitHub] [shiro-site] fpapon merged pull request #43: Update java-authentication-guide.md.vtl

2019-04-30 Thread GitBox
fpapon merged pull request #43: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro-site] fpapon commented on issue #43: Update java-authentication-guide.md.vtl

2019-04-30 Thread GitBox
fpapon commented on issue #43: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/43#issuecomment-487899404 Good catch ;) LGTM! Thanks This is an automated message from the Apache Git

[GitHub] [shiro-site] small-wei opened a new pull request #43: Update java-authentication-guide.md.vtl

2019-04-30 Thread GitBox
small-wei opened a new pull request #43: Update java-authentication-guide.md.vtl URL: https://github.com/apache/shiro-site/pull/43 [typo] This is an automated message from the Apache Git Service. To respond to the message,