[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #496: SINGA-474 Mean operator

2019-08-14 Thread GitBox
ShichengChen commented on a change in pull request #496: SINGA-474 Mean operator URL: https://github.com/apache/incubator-singa/pull/496#discussion_r313862676 ## File path: python/singa/autograd.py ## @@ -354,6 +354,41 @@ def backward(self, dy): return

[GitHub] [incubator-singa] chrishkchris commented on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris commented on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521247206 > Just now I did a test: When I replace the merged tensor.cc file by the latest master branch tensor.cc, the loss can be reduced again. So I just

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris edited a comment on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521258077 Also the change in the following conda meta.yaml file I am not sure

[GitHub] [incubator-singa] chrishkchris commented on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris commented on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521258077 Also the change in the following conda file I am not sure

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #505: SINGA-474 sum operator

2019-08-14 Thread GitBox
ShichengChen commented on a change in pull request #505: SINGA-474 sum operator URL: https://github.com/apache/incubator-singa/pull/505#discussion_r313891578 ## File path: python/singa/autograd.py ## @@ -440,6 +440,21 @@ def add_bias(x, b, axis=0): return

[GitHub] [incubator-singa] pinpom opened a new pull request #513: SINGA-475 add Div

2019-08-14 Thread GitBox
pinpom opened a new pull request #513: SINGA-475 add Div URL: https://github.com/apache/incubator-singa/pull/513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-10 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311068821 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-10 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311056639 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-10 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r310328731 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] kaiping merged pull request #501: Singa 480 Update documentations

2019-08-10 Thread GitBox
kaiping merged pull request #501: Singa 480 Update documentations URL: https://github.com/apache/incubator-singa/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] nudles opened a new pull request #501: Singa 480 Update documentations

2019-08-10 Thread GitBox
nudles opened a new pull request #501: Singa 480 Update documentations URL: https://github.com/apache/incubator-singa/pull/501 https://issues.apache.org/jira/browse/SINGA-480 This is an automated message from the Apache Git

[GitHub] [incubator-singa] moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-13 Thread GitBox
moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313273313 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-13 Thread GitBox
joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313281841 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] ShichengChen edited a comment on issue #502: SINGA-474 Clip operator

2019-08-12 Thread GitBox
ShichengChen edited a comment on issue #502: SINGA-474 Clip operator URL: https://github.com/apache/incubator-singa/pull/502#issuecomment-520658575 > the same code appears in both #503 and #502 . > you can add feature A, commit and send PR A; then add feature B, commit and send PR B;

[GitHub] [incubator-singa] ShichengChen commented on issue #502: SINGA-474 Clip operator

2019-08-12 Thread GitBox
ShichengChen commented on issue #502: SINGA-474 Clip operator URL: https://github.com/apache/incubator-singa/pull/502#issuecomment-520658575 > the same code appears in both #503 and #502 . > you can add feature A, commit and send PR A; then add feature B, commit and send PR B; > you

[GitHub] [incubator-singa] nudles commented on issue #502: SINGA-474 Clip operator

2019-08-12 Thread GitBox
nudles commented on issue #502: SINGA-474 Clip operator URL: https://github.com/apache/incubator-singa/pull/502#issuecomment-520653605 the same code appears in both #503 and #502 . you can add feature A, commit and send PR A; then add feature B, commit and send PR B; you can also

[GitHub] [incubator-singa] joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-12 Thread GitBox
joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313209763 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-12 Thread GitBox
joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313209881 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-12 Thread GitBox
joddiy commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313209763 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] nudles commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-12 Thread GitBox
nudles commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r313189915 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-11 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r311056639 ## File path: src/api/config.i ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [incubator-singa] pinpom opened a new pull request #525: SINGA 475 - add Or operator

2019-08-19 Thread GitBox
pinpom opened a new pull request #525: SINGA 475 - add Or operator URL: https://github.com/apache/incubator-singa/pull/525 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] dcslin closed pull request #467: SINGA-440 update available dockerhub tags

2019-08-20 Thread GitBox
dcslin closed pull request #467: SINGA-440 update available dockerhub tags URL: https://github.com/apache/incubator-singa/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator

2019-08-18 Thread GitBox
chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515#discussion_r314934800 ## File path: python/singa/autograd.py ## @@ -2316,3 +2315,37 @@ def backward(self, dy): def max(a,b):

[GitHub] [incubator-singa] ShichengChen opened a new pull request #505: SINGA-474 sum operator

2019-08-13 Thread GitBox
ShichengChen opened a new pull request #505: SINGA-474 sum operator URL: https://github.com/apache/incubator-singa/pull/505 SINGA-474 sum operator for autograd and ONNX operator This is an automated message from the Apache

[GitHub] [incubator-singa] ShichengChen opened a new pull request #506: SINGA-474 mul operator

2019-08-13 Thread GitBox
ShichengChen opened a new pull request #506: SINGA-474 mul operator URL: https://github.com/apache/incubator-singa/pull/506 SINGA-474 mul operator for autograd and ONNX operator This is an automated message from the Apache

[GitHub] [incubator-singa] nudles opened a new pull request #515: SINGA-474 Add gemm operator

2019-08-14 Thread GitBox
nudles opened a new pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] chrishkchris commented on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris commented on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521270716 I have created an additional image in AWS: Jupyter Notebook Demo (Distributed Module) version 2 based on the current status (updated dist_new by merging

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris edited a comment on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521270716 I have created an additional image in AWS: Jupyter Notebook Demo (Distributed Module) version 2 based on the current status (updated dist_new by

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #468: Distributted module

2019-08-14 Thread GitBox
chrishkchris edited a comment on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-521270716 I have created an additional image in AWS: Jupyter Notebook Demo (Distributed Module) version 2 based on the current status of dist_new (updated

[GitHub] [incubator-singa] dcslin opened a new pull request #514: tc comprehension integration Ref. SINGA-482

2019-08-14 Thread GitBox
dcslin opened a new pull request #514: tc comprehension integration Ref. SINGA-482 URL: https://github.com/apache/incubator-singa/pull/514 Hi this is not completely ready for merge, pending to fix a testing error. This is an

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator

2019-08-16 Thread GitBox
chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515#discussion_r314934800 ## File path: python/singa/autograd.py ## @@ -2316,3 +2315,37 @@ def backward(self, dy): def max(a,b):

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator

2019-08-16 Thread GitBox
chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515#discussion_r314934800 ## File path: python/singa/autograd.py ## @@ -2316,3 +2315,37 @@ def backward(self, dy): def max(a,b):

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator

2019-08-16 Thread GitBox
chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515#discussion_r314934800 ## File path: python/singa/autograd.py ## @@ -2316,3 +2315,37 @@ def backward(self, dy): def max(a,b):

[GitHub] [incubator-singa] chrishkchris opened a new pull request #523: SINGA-478 Improve __itruediv__ in tensor.py

2019-08-16 Thread GitBox
chrishkchris opened a new pull request #523: SINGA-478 Improve __itruediv__ in tensor.py URL: https://github.com/apache/incubator-singa/pull/523 Improve the __itruediv__ operation by using the /= operator in c tensor directly instead of *= operator. Has tested two cases (because

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator

2019-08-16 Thread GitBox
chrishkchris commented on a change in pull request #515: SINGA-474 Add gemm operator URL: https://github.com/apache/incubator-singa/pull/515#discussion_r314934800 ## File path: python/singa/autograd.py ## @@ -2316,3 +2315,37 @@ def backward(self, dy): def max(a,b):

[GitHub] [incubator-singa] pinpom opened a new pull request #522: SINGA 478 - add And operator

2019-08-16 Thread GitBox
pinpom opened a new pull request #522: SINGA 478 - add And operator URL: https://github.com/apache/incubator-singa/pull/522 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-singa] chrishkchris commented on issue #468: Distributted module

2019-08-21 Thread GitBox
chrishkchris commented on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-523749828 merged from latest master again, the sonnx.py is the same as master This is an automated

[GitHub] [incubator-singa] chrishkchris edited a comment on issue #468: Distributted module

2019-08-21 Thread GitBox
chrishkchris edited a comment on issue #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#issuecomment-523749828 merged from latest master again, the sonnx.py is the same as master Also, retested in AWS

[GitHub] [incubator-singa] dcslin commented on issue #514: SINGA-482 tc comprehension integration

2019-08-22 Thread GitBox
dcslin commented on issue #514: SINGA-482 tc comprehension integration URL: https://github.com/apache/incubator-singa/pull/514#issuecomment-523808529 TODO: 1. move tc execution code into device `DoExec`, and support CPU 2. package dependencies as conda package 3. integer support

[GitHub] [incubator-singa] pinpom opened a new pull request #526: SINGA 475 - add not operator

2019-08-20 Thread GitBox
pinpom opened a new pull request #526: SINGA 475 - add not operator URL: https://github.com/apache/incubator-singa/pull/526 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-singa] moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx

2019-08-20 Thread GitBox
moazreyad commented on a change in pull request #504: SINGA-481 Reconsturct soonx URL: https://github.com/apache/incubator-singa/pull/504#discussion_r315733324 ## File path: test/python/test_onnx.py ## @@ -0,0 +1,202 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-25 Thread GitBox
ShichengChen commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317383759 ## File path: test/python/test_operation.py ## @@ -1587,25 +1587,148 @@ def

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-25 Thread GitBox
ShichengChen commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317383894 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-25 Thread GitBox
ShichengChen commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317383903 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-25 Thread GitBox
ShichengChen commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317383901 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] moazreyad opened a new pull request #530: SINGA-456 Add KEYS file

2019-08-24 Thread GitBox
moazreyad opened a new pull request #530: SINGA-456 Add KEYS file URL: https://github.com/apache/incubator-singa/pull/530 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317377016 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317377008 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317375031 ## File path: CMakeLists.txt ## @@ -30,7 +30,7 @@ LIST(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake/Thirdparty)

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317375284 ## File path: src/api/config.i ## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317375169 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: can combine mnist_dist.py and

[GitHub] [incubator-singa] nudles commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-24 Thread GitBox
nudles commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317377077 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] nudles commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-24 Thread GitBox
nudles commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317377059 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] nudles commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-24 Thread GitBox
nudles commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317377086 ## File path: test/python/test_operation.py ## @@ -1587,25 +1587,148 @@ def test_min_gpu(self):

[GitHub] [incubator-singa] nudles commented on a change in pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-08-24 Thread GitBox
nudles commented on a change in pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524#discussion_r317377067 ## File path: python/singa/autograd.py ## @@ -608,21 +608,177 @@ def backward(self, dy): def

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317382034 ## File path: CMakeLists.txt ## @@ -30,7 +30,7 @@ LIST(APPEND CMAKE_MODULE_PATH

[GitHub] [incubator-singa] nudles merged pull request #530: SINGA-456 Add KEYS file

2019-08-24 Thread GitBox
nudles merged pull request #530: SINGA-456 Add KEYS file URL: https://github.com/apache/incubator-singa/pull/530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317382891 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: I see. I will modify the

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317382900 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-24 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317381887 ## File path: src/api/config.i ## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-singa] moazreyad opened a new pull request #529: SINGA-484 Code analysis with LGTM

2019-08-24 Thread GitBox
moazreyad opened a new pull request #529: SINGA-484 Code analysis with LGTM URL: https://github.com/apache/incubator-singa/pull/529 Adding code analysis badges to README. This is an automated message from the Apache Git

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317889630 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317889630 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317889630 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317889630 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317889630 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317937233 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: Has modified mnist_cnn.py

[GitHub] [incubator-singa] moazreyad commented on issue #426: SINGA-405 Add roles to contributors

2019-08-27 Thread GitBox
moazreyad commented on issue #426: SINGA-405 Add roles to contributors URL: https://github.com/apache/incubator-singa/pull/426#issuecomment-525205924 I think we need to review and merge this pull request before graduation. This is related to CS10 in [the maturity

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317938576 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: I have already followed up

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-27 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317938576 ## File path: examples/autograd/mnist_dist.py ## @@ -0,0 +1,251 @@ +# Review comment: I have already followed up

[GitHub] [incubator-singa] moazreyad opened a new pull request #531: SINGA-485 Add code coverage with codecov

2019-08-30 Thread GitBox
moazreyad opened a new pull request #531: SINGA-485 Add code coverage with codecov URL: https://github.com/apache/incubator-singa/pull/531 Using [Codecov Bash Uploader](https://docs.codecov.io/docs/about-the-codecov-bash-uploader) with Travis CI to upload coverage information to

[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
nudles commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320326414 ## File path: src/dist/communicator.cc ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-singa] nudles merged pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-09-03 Thread GitBox
nudles merged pull request #524: SINGA-474 prelu,add,equal,selu,elu operator URL: https://github.com/apache/incubator-singa/pull/524 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320542607 ## File path: src/dist/communicator.cc ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320542607 ## File path: src/dist/communicator.cc ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320544707 ## File path: src/dist/communicator.cc ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320544707 ## File path: src/dist/communicator.cc ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317488906 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317488906 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317488906 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317488906 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317488906 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-08-26 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module URL: https://github.com/apache/incubator-singa/pull/468#discussion_r317527518 ## File path: python/singa/autograd.py ## @@ -1286,25 +1287,26 @@ def set_params(self, **parameters): class

<    1   2   3   4   5   6   7   8   >