Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread Sheng Wu
This PR has been approved by 1. Han Liu 2. Haochao Zhuang 3. Zhenxu Ke 4. Hongtao Gao 5. Yanlong He 6. Wei Zhang 3 PMC members and 3 committers. Tests have been covering agent tests, e2e tests, language agents of java/php/lua/go. I am going to merge that PR now. Sheng Wu 吴晟 Twitter, wusheng1108

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread Sheng Wu
Great. If any of you think this PR is ready, please approve(but don’t merge) the PR. han liu 于2020年4月9日 周四下午10:21写道: > Hi, Sheng Wu > > I have test the alarm module, and it works well. > > Sheng Wu 于2020年4月9日周四 下午8:26写道: > >> Summary >> > This pull request is open for 10 days, and I worked on

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread han liu
Hi, Sheng Wu I have test the alarm module, and it works well. Sheng Wu 于2020年4月9日周四 下午8:26写道: > Summary > > This pull request is open for 10 days, and I worked on this 2 weeks ago. > Thanks everyone to help making this PR and tests work now. > > Here are the list of changes we made in this

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread Sheng Wu
If anyone still doesn't know the PR, here is the link, https://github.com/apache/skywalking/pull/4599 Sheng Wu 吴晟 Twitter, wusheng1108 Sheng Wu 于2020年4月9日周四 下午8:26写道: > Summary > > This pull request is open for 10 days, and I worked on this 2 weeks ago. > Thanks everyone to help making this

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread Sheng Wu
Summary This pull request is open for 10 days, and I worked on this 2 weeks ago. Thanks everyone to help making this PR and tests work now. Here are the list of changes we made in this pull request. Top 3 are the principle changes, others are following these principles. 1. New agent and mesh

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread kezhenxu94@apache
The E2E should be fixed according the new codes now, good luck GitHub @kezhenxu94 Apache SkyWalking, Apache Dubbo > On Apr 6, 2020, at 20:45, Sheng Wu wrote: > > Zhenxu Ke > My PR is ready locally, but e2e seems still failing. Please help with > locating what are the issues. > > Haochao

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-09 Thread han liu
Hi Dev Team, The skywalking-nginx-lua has finished adapting the new v3 protocol[1]. Thank Sheng Wu, Wen Ming, and YuanSheng Wang to review the code. [1] https://github.com/apache/skywalking-nginx-lua/pull/30 Sheng Wu 于2020年4月8日周三 下午8:49写道: > han liu 于2020年4月8日周三 下午8:44写道: > > > Hi Dev Team,

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-08 Thread Sheng Wu
han liu 于2020年4月8日周三 下午8:44写道: > Hi Dev Team, > > I upgraded skywalking-nginx-lua to protocol v3[1] and it seems working > well. Also, I have finished the lua e2e test in the local environment. > I'm still waiting for the Nginx PR review finish, then I can commit the e2e > Wen Ming I will

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-08 Thread han liu
Hi Dev Team, I upgraded skywalking-nginx-lua to protocol v3[1] and it seems working well. Also, I have finished the lua e2e test in the local environment. I'm still waiting for the Nginx PR review finish, then I can commit the e2e files into the main repo. [1]

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-08 Thread Sheng Wu
Great. Very appreciated for the quick update. Wei Zhang 于2020年4月7日 周二下午9:26写道: > Hi Dev Team, > > I upgraded go2sky to protocol v3[1] and it seems to be working well so > far[2], then I will check the details. > > [1]: https://github.com/SkyAPM/go2sky/pull/53 < >

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-08 Thread Yanlong He
Hi Dev Team, I upgraded SkyWalking-PHP to protocol v3[1] and it seems to be working well so far, then I will check the details. [1]: https://github.com/SkyAPM/SkyAPM-php-sdk/pull/213 < https://github.com/SkyAPM/SkyAPM-php-sdk/pull/213> Yanlong 何延龙 > 2020年4月7日 下午9:26,Wei Zhang 写道: > > Hi Dev

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-07 Thread Wei Zhang
Hi Dev Team, I upgraded go2sky to protocol v3[1] and it seems to be working well so far[2], then I will check the details. [1]: https://github.com/SkyAPM/go2sky/pull/53 < https://github.com/SkyAPM/go2sky/pull/53> [2]: https://github.com/SkyAPM/go2sky/pull/53#issuecomment-610384191 <

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-07 Thread Daming
Hi, It is good to me to remove the InfluxDB storage E2E Test. I will make it adapt to the new protocol and restore it. After the PR merged. — Daming(@dmsolr) Apache SkyWalking > 在 2020年4月7日,下午2:56,Sheng Wu 写道: > > Haochao Zhuang, Zhenxu Ke, Yanlong He and Han Liu > > I just adjusted

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-07 Thread kezhenxu94@apache
The removal in E2E part looks good to me > On Apr 7, 2020, at 14:56, Sheng Wu wrote: > > Haochao Zhuang, Zhenxu Ke, Yanlong He and Han Liu > > I just adjusted the following things in PR tests > 1. Remove influxdb storage, lua agent and PHP agent from e2e tests. Once > you have done in your

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-07 Thread Sheng Wu
Haochao Zhuang, Zhenxu Ke, Yanlong He and Han Liu I just adjusted the following things in PR tests 1. Remove influxdb storage, lua agent and PHP agent from e2e tests. Once you have done in your side, please restore these, we stil expect these in 8.0 release. 2. No need to do a reboot test. Remove

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-06 Thread Daming
Hi Dev Team, Currently, I have upgraded the Agent-Test Tools to protocol v3. And it is in service on PluginTests of the main repository[1]. As I know, @mrproliu have brought it to lua-nginx repository[2]. [1]:https://github.com/apache/skywalking/pull/4599

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-04-06 Thread Sheng Wu
Zhenxu Ke My PR is ready locally, but e2e seems still failing. Please help with locating what are the issues. Haochao Zhuang I noticed you have upgraded the test tool for v3 protocol. Please move on making the plugin tests passed in the v8-core branch. Sheng Wu 吴晟 Twitter, wusheng1108 Sheng Wu

Re: [8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-03-31 Thread Yanlong He
A great idea. skywalking-php agent will be the fastest compatible with 8.0.0 > 2020年3月31日 上午11:29,Sheng Wu 写道: > > Hi Dev Team > > After the experiences of removing endpoint_inventory, I found out this > strategy is successful. > Especially, we totally get rid of register, so I want to do

[8.0.0] Move forward to 8.0.0. REMOVE the register and inventory permanently.

2020-03-30 Thread Sheng Wu
Hi Dev Team After the experiences of removing endpoint_inventory, I found out this strategy is successful. Especially, we totally get rid of register, so I want to do more. *SkyWalking 8.0.0* First, it is already unexpected for me, we have to move to 8.0.0 so quickly, but after the discussion