This's a valuable discussion, but I think we can reach a conclusion in a
short time.
My personal preference is not to require more than one viewer for *EVERY*
PR.
For example, if I tweak a single line of the config file in one PR, I don't
want to wait for 2 reviews to help me with it.
But the
It's a good practice to share the ownership of the project. If the
code can be reviewed by multiple eyes, the code quality will not be an
issue.
BTW, if you keep an eye on the PR, you will not be surprised when you
try to do some modifications on the code :)
+1 to invite more people to review the
Hi,
I agree with him more. No matter what, I will participate in the review more
actively.
--
Daming(@dmsolr)
Apache SkyWalking
> 在 2020年2月16日，上午11:48，Sheng Wu 写道：
>
> More importantly, I want to share the idea.
>
> Don't have to wait for me to express what is my idea. I just
More importantly, I want to share the idea.
Don't have to wait for me to express what is my idea. I just knew and took
part in the project from day one, nothing more.
If more people want to take part in and make decisions, let's do it.
If currently, PMC and committer still think it is better to
Hi
In this discussion, I didn't start to think about the rules of GitHub. That
is another discussion.
As we know, in the community, people sometimes prefer contributing based on
their own interests, rather than reviewing others.
There is not a right or wrong thing.
Please consider this just as a
The more reviewers, the better, but forcing it to be **REQUIRED**
just doesn't make things better, IMO, it slows down the contribution
process, people who take less part in reviewing works won't take more
after the setting.
But as you called for more committers/PMC to take part in reviewing,
we
As I asked before, I hope there will be more approvers to review.
For me, I'd love to participate.
Jian Tan, both.
Hi Dev and committer team
Since today, we have 207 contributors in our main repo. And many PRs landed
every week, which have to be approved by one person. But with the
increasement of the committer and the community, I want to ask your opinion
about
Do we need to set up the rule for the main
