[GitHub] wengangJi opened a new pull request #967: Wengang ji branch

2018-03-20 Thread GitBox
wengangJi opened a new pull request #967: Wengang ji branch URL: https://github.com/apache/incubator-skywalking/pull/967 { "query":"{ getServiceTPSTrend(serviceId: 2,duration:{start: \"201701\", end: \"201702\",step: MONTH}) {trendList} }" } { "data": {

[GitHub] wu-sheng commented on issue #967: Wengang ji branch

2018-03-20 Thread GitBox
wu-sheng commented on issue #967: Wengang ji branch URL: https://github.com/apache/incubator-skywalking/pull/967#issuecomment-374503033 Please be advised: 1. You need to pull request an entirety feature, not just a few DAO implementations. 1. Your pr descriptions are meaningless, I

[GitHub] wu-sheng closed pull request #966: Update How-to-release

2018-03-20 Thread GitBox
wu-sheng closed pull request #966: Update How-to-release URL: https://github.com/apache/incubator-skywalking/pull/966 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #966: Update How-to-release

2018-03-20 Thread GitBox
coveralls commented on issue #966: Update How-to-release URL: https://github.com/apache/incubator-skywalking/pull/966#issuecomment-374502543 [![Coverage Status](https://coveralls.io/builds/16068407/badge)](https://coveralls.io/builds/16068407) Coverage remained the same at

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819 review the code , the question is here ```java long callTimes =

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819 review the code , the question is here ```data { "_index" : "instance_metric_day",

[GitHub] wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374535834 @cyberdak I think 0 is a good choice. Can you send a pull reuqest to fix?

[GitHub] wu-sheng commented on issue #969: fix #939

2018-03-20 Thread GitBox
wu-sheng commented on issue #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374577237 @cyberdak CI fails :) Please fix this. This is an automated message from the Apache Git Service.

[GitHub] coveralls commented on issue #970: add npm install error tips.

2018-03-20 Thread GitBox
coveralls commented on issue #970: add npm install error tips. URL: https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577690 [![Coverage Status](https://coveralls.io/builds/16072684/badge)](https://coveralls.io/builds/16072684) Coverage remained the same

[GitHub] cyberdak opened a new pull request #970: add npm install error tips.

2018-03-20 Thread GitBox
cyberdak opened a new pull request #970: add npm install error tips. URL: https://github.com/apache/incubator-skywalking/pull/970 tell people use taobao's npm source. Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha (2nd round)

2018-03-20 Thread Sheng Wu
+1 binding. I have checked the following things: 1. All artifacts in staging repository are published with .asc, .md5, *sha1 files. 2. Source code and distribution package are in https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha with .asc, .sha512. 3. LICENSE and NOTICE

[GitHub] wu-sheng closed pull request #970: add npm install error tips.

2018-03-20 Thread GitBox
wu-sheng closed pull request #970: add npm install error tips. URL: https://github.com/apache/incubator-skywalking/pull/970 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] coveralls commented on issue #970: add npm install error tips.

2018-03-20 Thread GitBox
coveralls commented on issue #970: add npm install error tips. URL: https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577690 [![Coverage Status](https://coveralls.io/builds/16072230/badge)](https://coveralls.io/builds/16072230) Coverage remained the same

[GitHub] wu-sheng commented on issue #970: add npm install error tips.

2018-03-20 Thread GitBox
wu-sheng commented on issue #970: add npm install error tips. URL: https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577886 FYI @hanahmily This is an automated message from the Apache Git Service. To

[GitHub] cyberdak opened a new pull request #969: fix #939

2018-03-20 Thread GitBox
cyberdak opened a new pull request #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969 fix #939 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374546532 @cyberdak are you using skywalking in company now? This is

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819 review the code , the question is here ```data { "_index" : "instance_metric_day",

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374560030 @wu-sheng no,last time i want try skywalking to trace some performance issue , then i meet #773 issue. So i am looking

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
wu-sheng commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374519453 FYI @hanahmily I think you are interested in this feature, too. Welcome to sub and join.

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha (2nd round)

2018-03-20 Thread xin zhang
+1 (binding) I had checked the following items: [x] feature tested. [x] SHA and ASC files are verified. [x] Source package build success. [x] LICENSE and NOTICE file in the source package and binary package. [x] Apache RAT checked -- Xin Zhang Apache SkyWalking PPMC member On

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

2018-03-20 Thread GitBox
cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374544536 PR submited. This is an automated message from the Apache

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [![Coverage Status](https://coveralls.io/builds/16075020/badge)](https://coveralls.io/builds/16075020) Coverage

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [![Coverage Status](https://coveralls.io/builds/16074665/badge)](https://coveralls.io/builds/16074665) Coverage

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [![Coverage Status](https://coveralls.io/builds/16088920/badge)](https://coveralls.io/builds/16088920) Coverage

[GitHub] peng-yongsheng closed pull request #969: fix #939

2018-03-20 Thread GitBox
peng-yongsheng closed pull request #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [![Coverage Status](https://coveralls.io/builds/16089097/badge)](https://coveralls.io/builds/16089097) Coverage

[GitHub] wendal commented on issue #443: Which companies are using SkyWalking

2018-03-20 Thread GitBox
wendal commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374826028 广州文尔软件科技有限公司 https://www.site0.cn 当前使用的版本号 3.2.6 This is an automated

[GitHub] wu-sheng closed pull request #967: Wengang ji branch

2018-03-20 Thread GitBox
wu-sheng closed pull request #967: Wengang ji branch URL: https://github.com/apache/incubator-skywalking/pull/967 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] wu-sheng commented on issue #967: Wengang ji branch

2018-03-20 Thread GitBox
wu-sheng commented on issue #967: Wengang ji branch URL: https://github.com/apache/incubator-skywalking/pull/967#issuecomment-374807235 I am going to close this pull request. Please start a new if you are ready. FYI @apache/skywalking-committers

[GitHub] ascrutae opened a new pull request #971: Upgrade netty version

2018-03-20 Thread GitBox
ascrutae opened a new pull request #971: Upgrade netty version URL: https://github.com/apache/incubator-skywalking/pull/971 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
wu-sheng commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750 FYI @hanahmily TLS has been established in core with optional setting. And you should be care of port setting, only

[GitHub] chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking

2018-03-20 Thread GitBox
chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374827519 当当网 [http://www.dangdang.com/](url) 已在生产环境使用,并自研PHP探针,当前使用的版本号为3.2.6

[GitHub] coveralls commented on issue #969: fix #939

2018-03-20 Thread GitBox
coveralls commented on issue #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374694660 [![Coverage Status](https://coveralls.io/builds/16088325/badge)](https://coveralls.io/builds/16088325) Coverage remained the same at 19.191% when

[GitHub] ascrutae closed pull request #971: Upgrade netty version

2018-03-20 Thread GitBox
ascrutae closed pull request #971: Upgrade netty version URL: https://github.com/apache/incubator-skywalking/pull/971 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

2018-03-20 Thread GitBox
wu-sheng commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750 FYI @hanahmily TLS has been established in core with optional setting. And you should take care of port setting, only

[GitHub] coveralls commented on issue #969: fix #939

2018-03-20 Thread GitBox
coveralls commented on issue #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374694660 [![Coverage Status](https://coveralls.io/builds/16079751/badge)](https://coveralls.io/builds/16079751) Coverage remained the same at 19.191% when