[GitHub] ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437
ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362509001 @wu-sheng Sorry for my poor english, and here is my explain. I use the demo to enhance ServicceComb and found that the trace is broken. Here is the expected segment about demo: ``` ServiceComb-Segment: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` Span-1: `codefirst.codeFirstHello.sayHi` ``` In fact the generated segment looks like this: ``` SerivceComb-Segment-0: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` ServiceComb-Segment-1: Span-0: `codefirst.codeFirstHello.sayHi` ``` The question is cause by the buired point is incorrect. Because of the enhance method `next` finished before the service method invoke. I found some suggest enhance class about `REST` service. But the ServiceComb support multiple way to provide service, maybe @lytscu still find the similar enhance class. **Consumer side** `io.servicecomb.common.rest.RestProducerInvocation#invoke`: The entry method about REST way to provide service. `io.servicecomb.provider.pojo.Invoker#invoke`: The entry method about ServiceComb RPC client stub .(The demo in call ServiceComb service by PRC) **Producer side** `io.servicecomb.core.handler.impl.ProducerOperationHandler#handle`: The entry method about RPC service stub. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437
ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362509001 @wu-sheng Sorry for my poor english, and here is my explain. I use the demo to enhance ServicceComb and found that the trace is broken. Here is the expected segment about demo: ``` ServiceComb-Segment: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` Span-1: `codefirst.codeFirstHello.sayHi` ``` In fact the generated segment looks like this: ``` SerivceComb-Segment-0: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` ServiceComb-Segment-1: Span-0: `codefirst.codeFirstHello.sayHi` ``` The question is cause by the buired point is incorrect. Because of the enhance method `next` finished before the service method invoked. I found some suggest enhance class about `REST` service. But the ServiceComb support multiple way to provide service, maybe @lytscu still find the similar enhance class. **Consumer side** `io.servicecomb.common.rest.RestProducerInvocation#invoke`: The entry method about REST way to provide service. `io.servicecomb.provider.pojo.Invoker#invoke`: The entry method about ServiceComb RPC client stub .(The demo in call ServiceComb service by PRC) **Producer side** `io.servicecomb.core.handler.impl.ProducerOperationHandler#handle`: The entry method about RPC service stub. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437
ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362509001 @wu-sheng Sorry for my poor english, and here is my explain. I use the demo to enhance ServicceComb and found that the trace is broken. Here is the expected segment about demo: ``` ServiceComb-Segment: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` Span-1: `codefirst.codeFirstHello.sayHi` ``` In fact Here is the generated segment: ``` SerivceComb-Segment-0: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` ServiceComb-Segment-1: Span-0: `codefirst.codeFirstHello.sayHi` ``` The question is cause by the buired point is incorrect. Because of the enhance method `next` finished before the service method invoked. I found some suggest enhance class about `REST` service. But the ServiceComb support multiple way to provide service, maybe @lytscu still find the similar enhance class. **Consumer side** `io.servicecomb.common.rest.RestProducerInvocation#invoke`: The entry method about REST way to provide service. `io.servicecomb.provider.pojo.Invoker#invoke`: The entry method about ServiceComb RPC client stub .(The demo in call ServiceComb service by PRC) **Producer side** `io.servicecomb.core.handler.impl.ProducerOperationHandler#handle`: The entry method about RPC service stub. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 opened a new issue #788: Grouping the performance matrix per application instead per VM
zone1511 opened a new issue #788: Grouping the performance matrix per application instead per VM URL: https://github.com/apache/incubator-skywalking/issues/788 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question Is it possible to let the agent return per application's performance matrix instead per VM? For example I have J2ee container and multiple application has been deployed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Podling Report Reminder - February 2018
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 21 February 2018, 10:30 am PDT. The report for your podling will form a part of the Incubator PMC report. The Incubator PMC requires your report to be submitted 2 weeks before the board meeting, to allow sufficient time for review and submission (Wed, February 07). Please submit your report with sufficient time to allow the Incubator PMC, and subsequently board members to review and digest. Again, the very latest you should submit your report is 2 weeks prior to the board meeting. Thanks, The Apache Incubator PMC Submitting your Report -- Your report should contain the following: * Your project name * A brief description of your project, which assumes no knowledge of the project or necessarily of its field * A list of the three most important issues to address in the move towards graduation. * Any issues that the Incubator PMC or ASF Board might wish/need to be aware of * How has the community developed since the last report * How has the project developed since the last report. * How does the podling rate their own maturity. This should be appended to the Incubator Wiki page at: https://wiki.apache.org/incubator/February2018 Note: This is manually populated. You may need to wait a little before this page is created from a template. Mentors --- Mentors should review reports for their project(s) and sign them off on the Incubator wiki page. Signing off reports shows that you are following the project - projects that are not signed may raise alarms for the Incubator PMC. Incubator PMC
[GitHub] wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362462279 @ascrutae I can't follow you with the spans expected: > Span-0: codefirstClient.codeFirstSpringmvcHello.say Span-1: codefirst.codeFirstHello.sayHi What does this mean? What is now? and brake how? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362461187 @ascrutae I don't think these can be caused by where you set the interceptor. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437
ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362199137 I found some question about this PR, here are the questions: Q1: I use the [demo](https://github.com/lytscu/skywalking-agent-testcases/tree/servicecomb/servicecomb-0.x-scenario) to trace the service about Servicecomb, I found the trace is broken, The **consumer** trace segment should be like the following: ``` Span-0: codefirstClient.codeFirstSpringmvcHello.say Span-1: codefirst.codeFirstHello.sayHi ``` but in fact those spans are in two segments. Q2: The buried point `Invocation` is more complex, I found some buried point about Servicecomb plugin will more simple. **Consumer side**: 1. `io.servicecomb.common.rest.RestProducerInvocation#createInvocation` 2. `io.servicecomb.common.rest.AbstractRestInvocation#invoke` The `Pojo` way about Servicecomb 1. `io.servicecomb.provider.pojo.Invoker#invoke` **Producer Side**: 1. `io.servicecomb.swagger.engine.SwaggerProducerOperation#invoke` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
