[GitHub] peng-yongsheng closed pull request #969: fix #939

[GitBox]

peng-yongsheng closed pull request #969: fix #939
URL: https://github.com/apache/incubator-skywalking/pull/969
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java
 
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java
index 701550b96..81cde47c7 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java
@@ -144,7 +144,12 @@ public InstanceMetricEsUIDAO(ElasticSearchClient client) {
 long errorCallTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS)).longValue();
 long durationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_DURATION_SUM)).longValue();
 long errorDurationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_BUSINESS_TRANSACTION_ERROR_DURATION_SUM)).longValue();
-responseTimeTrends.add((int)((durationSum - errorDurationSum) 
/ (callTimes - errorCallTimes)));
+long correctCallTimes = callTimes - errorCallTimes;
+if (correctCallTimes != 0L) {
+responseTimeTrends.add((int)((durationSum - 
errorDurationSum) / correctCallTimes));
+} else {
+responseTimeTrends.add(0);
+}
 } else {
 responseTimeTrends.add(0);
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking

[GitBox]

chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking
URL: 
https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374827519
 
 
   当当网 [http://www.dangdang.com/](url) 已在生产环境使用，并自研PHP探针，当前使用的版本号为3.2.6


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wendal commented on issue #443: Which companies are using SkyWalking

[GitBox]

wendal commented on issue #443: Which companies are using SkyWalking
URL: 
https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374826028
 
 
   广州文尔软件科技有限公司 https://www.site0.cn 当前使用的版本号 3.2.6


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

coveralls commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16089097/badge)](https://coveralls.io/builds/16089097)
   
   Coverage increased (+0.02%) to 19.215% when pulling 
**250c56b0a9d3b9830d44d5dddf11a28aac8ba632 on feature/tls** into 
**8106c3859494d2add4a849dd053c95de888f150e on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750
 
 
   FYI @hanahmily TLS has been established in core with optional setting. And 
you should take care of port setting, only `agent_gRPC/grpc` support TLS, so 
you must set `remote/grpc/port` different with this, when you open TLS.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750
 
 
   FYI @hanahmily TLS has been established in core with optional setting. And 
you should be care of port setting, only `agent_gRPC/grpc` support TLS, so you 
must set `remote/grpc/port` different with this, when you open TLS.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

coveralls commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16088920/badge)](https://coveralls.io/builds/16088920)
   
   Coverage increased (+0.02%) to 19.215% when pulling 
**ce93d1e931809e5bcc4ab7b499474794254f210c on feature/tls** into 
**8106c3859494d2add4a849dd053c95de888f150e on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae closed pull request #971: Upgrade netty version

[GitBox]

ascrutae closed pull request #971: Upgrade netty version
URL: https://github.com/apache/incubator-skywalking/pull/971
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/apm-protocol/apm-network/pom.xml b/apm-protocol/apm-network/pom.xml
index b203f97b0..1481c67e1 100644
--- a/apm-protocol/apm-network/pom.xml
+++ b/apm-protocol/apm-network/pom.xml
@@ -29,7 +29,7 @@
 
 
 UTF-8
-1.8.0
+1.10.0
 4.1.17.Final
 1.6
 
@@ -39,20 +39,6 @@
 io.grpc
 grpc-netty
 ${grpc.version}
-
-
-io.netty
-netty-codec-http2
-
-
-io.netty
-netty-transport-native-epoll
-
-
-io.netty
-netty-handler-proxy
-
-
 
 
 io.grpc
@@ -66,18 +52,8 @@
 
 
 io.netty
-netty-codec-http2
-${netty.version}
-
-
-io.netty
-netty-handler-proxy
-${netty.version}
-
-
-io.netty
-netty-transport-native-epoll
-${netty.version}
+netty-tcnative-boringssl-static
+2.0.7.Final
 
 
 
diff --git a/apm-sniffer/apm-agent-core/pom.xml 
b/apm-sniffer/apm-agent-core/pom.xml
index ddd9942d2..2dbb3d804 100644
--- a/apm-sniffer/apm-agent-core/pom.xml
+++ b/apm-sniffer/apm-agent-core/pom.xml
@@ -34,7 +34,7 @@
 
 UTF-8
 9.4.2.v20170220
-1.8.0
+1.10.0
 1.7.9
 
 org.apache.skywalking.apm.dependencies
@@ -219,6 +219,25 @@
 
 
 
+
+unpack
+package
+
+
+
+
+
+
+
+
+
+
+
+
+
+run
+
+
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #971: Upgrade netty version

[GitBox]

ascrutae opened a new pull request #971: Upgrade netty version
URL: https://github.com/apache/incubator-skywalking/pull/971
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #969: fix #939

[GitBox]

coveralls commented on issue #969: fix #939
URL: 
https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374694660
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16088325/badge)](https://coveralls.io/builds/16088325)
   
   Coverage remained the same at 19.191% when pulling 
**a1f012004ace0e61118feb8fb39147fdf34f7543 on cyberdak:patch-2** into 
**8106c3859494d2add4a849dd053c95de888f150e on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #967: Wengang ji branch

[GitBox]

wu-sheng commented on issue #967: Wengang ji branch
URL: 
https://github.com/apache/incubator-skywalking/pull/967#issuecomment-374807235
 
 
   I am going to close this pull request. Please start a new if you are ready. 
FYI @apache/skywalking-committers 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #967: Wengang ji branch

[GitBox]

wu-sheng closed pull request #967: Wengang ji branch
URL: https://github.com/apache/incubator-skywalking/pull/967
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceH2UIDAO.java
 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceH2UIDAO.java
index f520734fe..e34233748 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceH2UIDAO.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceH2UIDAO.java
@@ -18,10 +18,6 @@
 
 package org.apache.skywalking.apm.collector.storage.h2.dao.ui;
 
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.LinkedList;
-import java.util.List;
 import org.apache.skywalking.apm.collector.client.h2.H2Client;
 import org.apache.skywalking.apm.collector.client.h2.H2ClientException;
 import org.apache.skywalking.apm.collector.core.util.BooleanUtils;
@@ -36,6 +32,11 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.LinkedList;
+import java.util.List;
+
 /**
  * @author peng-yongsheng, clevertension
  */
@@ -53,7 +54,7 @@ public InstanceH2UIDAO(H2Client client) {
 private static final String GET_APPLICATIONS_SQL = "select {3}, count({0}) 
as cnt from {1} where {2} >= ? group by {3} limit 100";
 
 @Override
-public Long lastHeartBeatTime() {
+public Long lastHeartBeatTime() { 
 H2Client client = getClient();
 long fiveMinuteBefore = System.currentTimeMillis() - 5 * 60 * 1000;
 fiveMinuteBefore = 
TimeBucketUtils.INSTANCE.getSecondTimeBucket(fiveMinuteBefore);
diff --git 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceMetricH2UIDAO.java
 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceMetricH2UIDAO.java
index 410ccd366..d1f2c5e89 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceMetricH2UIDAO.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/InstanceMetricH2UIDAO.java
@@ -18,10 +18,6 @@
 
 package org.apache.skywalking.apm.collector.storage.h2.dao.ui;
 
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.LinkedList;
-import java.util.List;
 import org.apache.skywalking.apm.collector.client.h2.H2Client;
 import org.apache.skywalking.apm.collector.client.h2.H2ClientException;
 import org.apache.skywalking.apm.collector.core.util.Const;
@@ -37,13 +33,21 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.LinkedList;
+import java.util.List;
+
 /**
  * @author peng-yongsheng, clevertension
  */
 public class InstanceMetricH2UIDAO extends H2DAO implements 
IInstanceMetricUIDAO {
-
 private final Logger logger = 
LoggerFactory.getLogger(InstanceMetricH2UIDAO.class);
 private static final String GET_TPS_METRIC_SQL = "select * from {0} where 
{1} = ?";
+private static final String GET_SERVER_THROUGHPUT_SQL=
+"select {0}, sum({1}) as transaction_calls,sum({2}) as 
transaction_error_calls " +
+"from {3} where {4} >= ? and {4} <= ? " +
+"and {5}=? and {6}=? group by {0} limit ?";
 
 public InstanceMetricH2UIDAO(H2Client client) {
 super(client);
@@ -51,9 +55,33 @@ public InstanceMetricH2UIDAO(H2Client client) {
 
 @Override public List getServerThroughput(int 
applicationId, Step step, long startTimeBucket, long endTimeBucket,
 int secondBetween, int topN, MetricSource metricSource) {
-return null;
+H2Client client = getClient();
+String tableName = TimePyramidTableNameBuilder.build(step, 
InstanceMetricTable.TABLE);
+String sql = 
SqlBuilder.buildSql(GET_SERVER_THROUGHPUT_SQL,InstanceMetricTable.COLUMN_INSTANCE_ID,
+
InstanceMetricTable.COLUMN_TRANSACTION_CALLS,InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS,tableName,
+
InstanceMetricTable.COLUMN_TIME_BUCKET,InstanceMetricTable.COLUMN_APPLICATION_ID,InstanceMetricTable.COLUMN_SOURCE_VALUE);
+ 

[GitHub] coveralls commented on issue #969: fix #939

[GitBox]

coveralls commented on issue #969: fix #939
URL: 
https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374694660
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16079751/badge)](https://coveralls.io/builds/16079751)
   
   Coverage remained the same at 19.191% when pulling 
**bfa3eacec28cd85a2f7ff82eb1d858e17a30b17a on cyberdak:patch-2** into 
**b5de1a16a67347d559f2807d5b0d0ff3c79f18f1 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

coveralls commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16075020/badge)](https://coveralls.io/builds/16075020)
   
   Coverage increased (+0.02%) to 19.215% when pulling 
**adb93c28c9c0dfb250bea7af8259cf4ff6d49782 on feature/tls** into 
**8106c3859494d2add4a849dd053c95de888f150e on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

coveralls commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16074665/badge)](https://coveralls.io/builds/16074665)
   
   Coverage increased (+0.02%) to 19.215% when pulling 
**adb93c28c9c0dfb250bea7af8259cf4ff6d49782 on feature/tls** into 
**8106c3859494d2add4a849dd053c95de888f150e on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #970: add npm install error tips.

[GitBox]

wu-sheng closed pull request #970: add npm install error tips.
URL: https://github.com/apache/incubator-skywalking/pull/970
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/cn/How-to-build-CN.md b/docs/cn/How-to-build-CN.md
index 223e0bc4c..ed0a1d7e0 100644
--- a/docs/cn/How-to-build-CN.md
+++ b/docs/cn/How-to-build-CN.md
@@ -37,3 +37,15 @@
 * resin-3.0.9.jar
 * resin-4.0.41.jar
 * ojdbc14-10.2.0.4.0.jar
+
+## FAQ
+### npm install超时失败
+如果在编译apm-webapp时碰到下载包失败问题，可以将apm-webapp中pom.xml中npm源地址修改为淘宝的源，在中国的访问速度可以大大提高.
+
+```
+install --registry=https://registry.npmjs.org/
+```
+修改为
+```
+install --registry=https://registry.npm.taobao.org/
+```


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #970: add npm install error tips.

[GitBox]

coveralls commented on issue #970: add npm install error tips.
URL: 
https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577690
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16072684/badge)](https://coveralls.io/builds/16072684)
   
   Coverage remained the same at 19.191% when pulling 
**3f11ea42b3e3cccf76796a053a029a13875b1a05 on cyberdak:patch-3** into 
**b5de1a16a67347d559f2807d5b0d0ff3c79f18f1 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #970: add npm install error tips.

[GitBox]

wu-sheng commented on issue #970: add npm install error tips.
URL: 
https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577886
 
 
   FYI @hanahmily 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #970: add npm install error tips.

[GitBox]

coveralls commented on issue #970: add npm install error tips.
URL: 
https://github.com/apache/incubator-skywalking/pull/970#issuecomment-374577690
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16072230/badge)](https://coveralls.io/builds/16072230)
   
   Coverage remained the same at 19.191% when pulling 
**c6aab737e1c63803b80ab06834fa820257239731 on cyberdak:patch-3** into 
**b5de1a16a67347d559f2807d5b0d0ff3c79f18f1 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #969: fix #939

[GitBox]

wu-sheng commented on issue #969: fix #939
URL: 
https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374577237
 
 
   @cyberdak CI fails :) Please fix this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha (2nd round)

[Sheng Wu]

+1 binding.

I have checked the following things:

1. All artifacts in staging repository are published with .asc, .md5, *sha1 
files.
2. Source code and distribution package are in 
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha with 
.asc, .sha512.
3. LICENSE and NOTICE are in Source code and distribution package.
4. `shasum -c` checked.
5. Rebuild the dist from source codes.
6. `mvn apache-rat:check` passed.

On 2018/03/20 09:13:57, xin zhang  wrote: 
> +1 (binding)
> 
> I had checked the following items:
> [x] feature tested.
> [x] SHA and ASC  files are verified.
> [x] Source package build success.
> [x] LICENSE and NOTICE file in the source package and binary package.
> [x] Apache RAT checked
> 
> --
> Xin Zhang
> Apache SkyWalking PPMC member
> 
> On Tue, Mar 20, 2018 at 11:26 AM, 吴晟 Sheng Wu  
> wrote:
> 
> > Hi All,
> > This is a call for vote to release Apache SkyWalking (Incubating) version
> > 5.0.0-alpha.
> >
> >
> > Release notes:
> >
> >
> >  * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md
> >
> >
> > Release Candidate:
> >
> >
> >  * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> > 5.0.0-alpha/
> >
> >
> > Maven 2 staging repository:
> >
> >
> >  * https://repository.apache.org/content/repositories/
> > orgapacheskywalking-1005/org/apache/skywalking/apache-
> > skywalking-apm-incubating/5.0.0-alpha/
> >
> >
> > Release Tag :
> >
> >
> >  * v5.0.0-alpha
> >
> >
> > Release CommitID :
> >
> >
> >  * f52d99498f02402d2ce1a0b7b909cd7fcfb3526f
> >
> >
> > Keys to verify the Release Candidate :
> >
> >
> >  * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> > 5.0.0-alpha/KEYS
> >  * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777
> >
> >
> > corresponding to pen...@apache.org
> >
> >
> > Guide to build the release from source :
> >
> >
> >  * https://github.com/apache/incubator-skywalking/blob/
> > master/docs/en/How-to-build.md#build-from-apache-source-codes
> >
> >
> > Voting will start now (March 20th, 2018) and will remain open for at least
> > 72 hours, Request all PPMC members to give their vote.
> > [ ] +1 Release this package.
> > [ ] +0 No opinion.
> > [ ] -1 Do not release this package because
> >
> >
> >
> > Everyone, I recommend you to run check by following this list:
> > https://github.com/apache/incubator-skywalking/blob/
> > master/docs/en/How-to-release.md#vote-check
> >
> >
> > --
> > Sheng Wu
> > Apache SkyWalking original creator and PPMC member
> 

[GitHub] cyberdak opened a new pull request #970: add npm install error tips.

[GitBox]

cyberdak opened a new pull request #970: add npm install error tips.
URL: https://github.com/apache/incubator-skywalking/pull/970
 
 
   tell people use taobao's npm source.
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

cyberdak commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374560030
 
 
   @wu-sheng no,last time i want try skywalking to trace some performance issue 
, then i meet #773 issue.
   So i am looking forward #773's PR merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

wu-sheng commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374546532
 
 
   @cyberdak are you using skywalking in company now?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

cyberdak commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374544536
 
 
   PR submited.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cyberdak opened a new pull request #969: fix #939

[GitBox]

cyberdak opened a new pull request #969: fix #939
URL: https://github.com/apache/incubator-skywalking/pull/969
 
 
   fix #939
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
devide  / zero
   - How to fix?
   when denominator is 0 , return 0
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

wu-sheng commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374535834
 
 
   @cyberdak I think 0 is a good choice. Can you send a pull reuqest to fix?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha (2nd round)

[xin zhang]

+1 (binding)

I had checked the following items:
[x] feature tested.
[x] SHA and ASC  files are verified.
[x] Source package build success.
[x] LICENSE and NOTICE file in the source package and binary package.
[x] Apache RAT checked

--
Xin Zhang
Apache SkyWalking PPMC member

On Tue, Mar 20, 2018 at 11:26 AM, 吴晟 Sheng Wu  wrote:

> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version
> 5.0.0-alpha.
>
>
> Release notes:
>
>
>  * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md
>
>
> Release Candidate:
>
>
>  * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/
>
>
> Maven 2 staging repository:
>
>
>  * https://repository.apache.org/content/repositories/
> orgapacheskywalking-1005/org/apache/skywalking/apache-
> skywalking-apm-incubating/5.0.0-alpha/
>
>
> Release Tag :
>
>
>  * v5.0.0-alpha
>
>
> Release CommitID :
>
>
>  * f52d99498f02402d2ce1a0b7b909cd7fcfb3526f
>
>
> Keys to verify the Release Candidate :
>
>
>  * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/KEYS
>  * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777
>
>
> corresponding to pen...@apache.org
>
>
> Guide to build the release from source :
>
>
>  * https://github.com/apache/incubator-skywalking/blob/
> master/docs/en/How-to-build.md#build-from-apache-source-codes
>
>
> Voting will start now (March 20th, 2018) and will remain open for at least
> 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because
>
>
>
> Everyone, I recommend you to run check by following this list:
> https://github.com/apache/incubator-skywalking/blob/
> master/docs/en/How-to-release.md#vote-check
>
>
> --
> Sheng Wu
> Apache SkyWalking original creator and PPMC member

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

cyberdak commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819
 
 
   review the code , the question is here
   ```data
   
 {
   "_index" : "instance_metric_day",
   "_type" : "type",
   "_id" : "20180313_4_1",
   "_score" : 1.0,
   "_source" : {
 "transaction_duration_sum" : 101,
 "metric_id" : "4_1",
 "mq_transaction_duration_sum" : 0,
 "mq_transaction_average_duration" : 0,
 "business_transaction_calls" : 4,
 **"transaction_calls" : 4,** <-- all txs
 "business_transaction_error_calls" : 0,
 "business_transaction_duration_sum" : 0,
 "application_id" : 2,
 **"transaction_error_calls" : 4,** <-- error txs
 "business_transaction_error_duration_sum" : 0,
 "instance_id" : 4,
 "transaction_average_duration" : 25,
 "time_bucket" : 20180313,
 "business_transaction_average_duration" : 0,
 "mq_transaction_calls" : 0,
 "transaction_error_duration_sum" : 101,
 "mq_transaction_error_calls" : 0,
 "source_value" : 1,
 "mq_transaction_error_duration_sum" : 0
   }
 }
   ```
   
   ```java
   long callTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_CALLS)).longValue();
   long errorCallTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS)).longValue();
   long durationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_DURATION_SUM)).longValue();
   long errorDurationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_BUSINESS_TRANSACTION_ERROR_DURATION_SUM)).longValue();
   responseTimeTrends.add((int)((durationSum - errorDurationSum) / (callTimes - 
errorCallTimes)));
   ```
   if all call is error,that will cause this error.
   
   i think it should return 0 or errorCallDurationAvg.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

cyberdak commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819
 
 
   review the code , the question is here
   ```data
   
 {
   "_index" : "instance_metric_day",
   "_type" : "type",
   "_id" : "20180313_4_1",
   "_score" : 1.0,
   "_source" : {
 "transaction_duration_sum" : 101,
 "metric_id" : "4_1",
 "mq_transaction_duration_sum" : 0,
 "mq_transaction_average_duration" : 0,
 "business_transaction_calls" : 4,
 **"transaction_calls" : 4,**
 "business_transaction_error_calls" : 0,
 "business_transaction_duration_sum" : 0,
 "application_id" : 2,
 **"transaction_error_calls" : 4,**
 "business_transaction_error_duration_sum" : 0,
 "instance_id" : 4,
 "transaction_average_duration" : 25,
 "time_bucket" : 20180313,
 "business_transaction_average_duration" : 0,
 "mq_transaction_calls" : 0,
 "transaction_error_duration_sum" : 101,
 "mq_transaction_error_calls" : 0,
 "source_value" : 1,
 "mq_transaction_error_duration_sum" : 0
   }
 }
   ```
   
   ```java
   long callTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_CALLS)).longValue();
   long errorCallTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS)).longValue();
   long durationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_DURATION_SUM)).longValue();
   long errorDurationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_BUSINESS_TRANSACTION_ERROR_DURATION_SUM)).longValue();
   responseTimeTrends.add((int)((durationSum - errorDurationSum) / (callTimes - 
errorCallTimes)));
   ```
   if all call is error,that will cause this error.
   
   i think it should return 0 or errorCallDurationAvg.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

[GitBox]

wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.
URL: 
https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374519453
 
 
   FYI @hanahmily I think you are interested in this feature, too. Welcome to 
sub and join.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cyberdak commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

[GitBox]

cyberdak commented on issue #939: [collector] '/ by zero'  error in 5.0.0-alpha
URL: 
https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374518819
 
 
   review the code , the question is here
   ```java
   long callTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_CALLS)).longValue();
   long errorCallTimes = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS)).longValue();
   long durationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_DURATION_SUM)).longValue();
   long errorDurationSum = 
((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_BUSINESS_TRANSACTION_ERROR_DURATION_SUM)).longValue();
   responseTimeTrends.add((int)((durationSum - errorDurationSum) / (callTimes - 
errorCallTimes)));
   ```
   if all call is error,that will cause this error.
   
   i think it should return 0 or errorCallDurationAvg.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #966: Update How-to-release

[GitBox]

wu-sheng closed pull request #966: Update How-to-release
URL: https://github.com/apache/incubator-skywalking/pull/966
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #967: Wengang ji branch

[GitBox]

wu-sheng commented on issue #967: Wengang ji branch
URL: 
https://github.com/apache/incubator-skywalking/pull/967#issuecomment-374503033
 
 
   Please be advised:
   1. You need to pull request an entirety feature, not just a few DAO 
implementations.
   1. Your pr descriptions are meaningless, I am not sure what you are going to 
do.
   1. Your commit logs show your Git setting is not right.
   
   Please understand what does a pull request mean.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #966: Update How-to-release

[GitBox]

coveralls commented on issue #966: Update How-to-release
URL: 
https://github.com/apache/incubator-skywalking/pull/966#issuecomment-374502543
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16068407/badge)](https://coveralls.io/builds/16068407)
   
   Coverage remained the same at 19.191% when pulling 
**1d2b75b225b8c36c7242dedca44c7f2cb6d0d25b on wu-sheng-patch-1** into 
**4589f4e46c8e2c73f6499182ff557d5ecd1f6c36 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wengangJi opened a new pull request #967: Wengang ji branch

[GitBox]

wengangJi opened a new pull request #967: Wengang ji branch
URL: https://github.com/apache/incubator-skywalking/pull/967
 
 
   {
"query":"{ 
getServiceTPSTrend(serviceId: 2,duration:{start: \"201701\", end: 
\"201702\",step: MONTH})
   {trendList}
}"
   }
   {
   "data": {
   "getServiceTPSTrend": {
   "trendList": [
   0,
   0
   ]
   }
   }
   }
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services