haofeiL commented on issue #708:
skywalking???sun.net.www.protocol.http.HttpURLConnection
URL:
https://github.com/apache/incubator-skywalking/issues/708#issuecomment-354210979
?
```
public class HttpjdkInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine
ascrutae opened a new pull request #709: [Agent] Adjust the buired point of
okhttp plugin
URL: https://github.com/apache/incubator-skywalking/pull/709
This is an automated message from the Apache Git Service.
To respond to
wu-sheng commented on a change in pull request #709: [Agent] Adjust the buired
point of okhttp plugin
URL:
https://github.com/apache/incubator-skywalking/pull/709#discussion_r158893813
##
File path:
wu-sheng commented on a change in pull request #709: [Agent] Adjust the buired
point of okhttp plugin
URL:
https://github.com/apache/incubator-skywalking/pull/709#discussion_r158893806
##
File path:
coveralls commented on issue #709: [Agent] Adjust the buired point of okhttp
plugin
URL:
https://github.com/apache/incubator-skywalking/pull/709#issuecomment-354223506
[](https://coveralls.io/builds/14822352)
coveralls commented on issue #709: [Agent] Adjust the buired point of okhttp
plugin
URL:
https://github.com/apache/incubator-skywalking/pull/709#issuecomment-354236816
[](https://coveralls.io/builds/14823269)
wu-sheng closed pull request #709: [Agent] Adjust the buired point of okhttp
plugin
URL: https://github.com/apache/incubator-skywalking/pull/709
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
zone1511 commented on issue #721: Recommendation on storing/retrieving plugin
specific configuration
URL:
https://github.com/apache/incubator-skywalking/issues/721#issuecomment-355039338
As related to another thread, I would like to build a conditional sql
logging plugin which only log
zone1511 commented on issue #720: access AbstractTracerContext from
ContextManager
URL:
https://github.com/apache/incubator-skywalking/issues/720#issuecomment-355040095
yes, im interest to extend skywalking to add more analytic functions.
peng-yongsheng opened a new pull request #724: A big change in collector.
URL: https://github.com/apache/incubator-skywalking/pull/724
Changed the structures of the projects
1. Deleted the collector queue module, use Datacarrier only. Because of
the Disruptor consume the message
wu-sheng commented on issue #721: Recommendation on storing/retrieving plugin
specific configuration
URL:
https://github.com/apache/incubator-skywalking/issues/721#issuecomment-355174368
All recent jdbc-related plugins trace sql without any parameter value. If
you want to develop private
wu-sheng commented on issue #720: access AbstractTracerContext from
ContextManager
URL:
https://github.com/apache/incubator-skywalking/issues/720#issuecomment-355174851
The official core don't find any real scenario, which need this access way.
Your requirements look like a custom way,
wu-sheng commented on issue #720: access AbstractTracerContext from
ContextManager
URL:
https://github.com/apache/incubator-skywalking/issues/720#issuecomment-355174987
As I mentioned here :
https://github.com/apache/incubator-skywalking/issues/721#issuecomment-355174368
> The
coveralls commented on issue #723: Add warning log outputs, if too many spans
created in one segment.
URL:
https://github.com/apache/incubator-skywalking/pull/723#issuecomment-355185879
[](https://coveralls.io/builds/14893430)
Coverage decreased (-0.06%)
wu-sheng opened a new pull request #725: Add incoming attr for application node.
URL: https://github.com/apache/incubator-skywalking/pull/725
Incoming request node, means User or outside system access the cluster from
this. Recommend the UI generate a User node for each incoming node
coveralls commented on issue #725: Add incoming attr for application node.
URL:
https://github.com/apache/incubator-skywalking/pull/725#issuecomment-355209852
[](https://coveralls.io/builds/14894182)
Coverage
ascrutae opened a new pull request #726: [Agent] fix import incorrector class
in httpclient plugin
URL: https://github.com/apache/incubator-skywalking/pull/726
This is an automated message from the Apache Git Service.
To
coveralls commented on issue #726: [Agent] fix import incorrector class in
httpclient plugin
URL:
https://github.com/apache/incubator-skywalking/pull/726#issuecomment-355304948
[](https://coveralls.io/builds/14899964)
wu-sheng closed pull request #726: [Agent] fix import incorrector class in
httpclient plugin
URL: https://github.com/apache/incubator-skywalking/pull/726
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
wu-sheng opened a new pull request #727: Finish the proto TODO list
URL: https://github.com/apache/incubator-skywalking/pull/727
* Rename the batchRegister to single application code register
* Rename `register` to `registerInstance`
wu-sheng commented on issue #725: Add incoming attr for application node.
URL:
https://github.com/apache/incubator-skywalking/pull/725#issuecomment-355309390
> Why not use the concept of "EntryNode" just like "EntrySpan"
`EntryNode` is hard to explain for APM end user. Because for
wu-sheng commented on issue #725: Add incoming attr for application node.
URL:
https://github.com/apache/incubator-skywalking/pull/725#issuecomment-355309390
> Why not use the concept of "EntryNode" just like "EntrySpan"
`EntryNode` is hard to explain for APM end user. Because for
ascrutae opened a new pull request #828: [Agent] fix HierarchyMatch donot
support generic type
URL: https://github.com/apache/incubator-skywalking/pull/828
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New
ascrutae opened a new pull request #827: [Agent] fix the servicecomb-1.x-plugin
build failure in local workdir
URL: https://github.com/apache/incubator-skywalking/pull/827
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
coveralls commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open
to 3.4.6.Final)
URL:
https://github.com/apache/incubator-skywalking/pull/796#issuecomment-363673676
[](https://coveralls.io/builds/15686206)
coveralls commented on issue #827: [Agent] fix the servicecomb-1.x-plugin build
failure in local workdir
URL:
https://github.com/apache/incubator-skywalking/pull/827#issuecomment-368281436
[![Coverage
peng-yongsheng closed pull request #827: [Agent] fix the servicecomb-1.x-plugin
build failure in local workdir
URL: https://github.com/apache/incubator-skywalking/pull/827
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
coveralls commented on issue #832: Add [Agent] Jedis LETTUCE client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/832#issuecomment-368721697
[](https://coveralls.io/builds/15712425)
Coverage
coveralls commented on issue #835: [Agent] fix intercept class package name is
incorrect
URL:
https://github.com/apache/incubator-skywalking/pull/835#issuecomment-368767062
[](https://coveralls.io/builds/15712571)
ascrutae commented on issue #612: [Agent] Can skywalking support Hystrix
URL:
https://github.com/apache/incubator-skywalking/issues/612#issuecomment-368779939
Hystrix plugin has been merged. Closing this issue
This is an
coveralls commented on issue #832: Add [Agent] Jedis LETTUCE client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/832#issuecomment-368721697
[](https://coveralls.io/builds/15713313)
Coverage
wu-sheng closed pull request #835: [Agent] fix intercept class package name is
incorrect
URL: https://github.com/apache/incubator-skywalking/pull/835
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
coveralls commented on issue #834: add hystrix framework to support list
URL:
https://github.com/apache/incubator-skywalking/pull/834#issuecomment-368741941
[](https://coveralls.io/builds/15712586)
Coverage remained
wu-sheng closed pull request #834: add hystrix framework to support list
URL: https://github.com/apache/incubator-skywalking/pull/834
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
ascrutae commented on a change in pull request #832: Add [Agent] Jedis LETTUCE
client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/832#discussion_r170845594
##
File path:
ascrutae opened a new pull request #835: [Agent] fix intercept class package
name is incorrect
URL: https://github.com/apache/incubator-skywalking/pull/835
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New
coveralls commented on issue #829: [Agent] Support hystrix plugin
URL:
https://github.com/apache/incubator-skywalking/pull/829#issuecomment-368309589
[](https://coveralls.io/builds/15712420)
Coverage increased
coveralls commented on issue #832: Add [Agent] Jedis LETTUCE client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/832#issuecomment-368721697
[](https://coveralls.io/builds/15712789)
Coverage
ascrutae commented on issue #612: [Agent] Can skywalking support Hystrix
URL:
https://github.com/apache/incubator-skywalking/issues/612#issuecomment-368779939
Hystrix plugin has been merged. Close this issue
This is an
ascrutae commented on a change in pull request #832: Add [Agent] Jedis LETTUCE
client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/832#discussion_r170845594
##
File path:
wu-sheng commented on issue #1: Avoid class cast exception.
URL:
https://github.com/apache/incubator-skywalking-oal-tool/pull/1#issuecomment-414115632
Let's support string. And notice, change template needs to fix test case as
well.
wu-sheng closed pull request #1: Avoid class cast exception.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/1
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
peng-yongsheng opened a new pull request #1: Avoid class cast exception.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/1
This is an automated message from the Apache Git Service.
To respond to the
peng-yongsheng opened a new pull request #2: Build the primary key.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/2
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng closed pull request #2: Build the primary key.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/2
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
wu-sheng closed pull request #4: Fixed the dispatcher check style error.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/4
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
peng-yongsheng opened a new pull request #3: Add calculate method into
indicator.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/3
This is an automated message from the Apache Git Service.
To respond to
peng-yongsheng opened a new pull request #4: Fixed the dispatcher check style
error.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/4
This is an automated message from the Apache Git Service.
To respond
wu-sheng closed pull request #3: Add calculate method into indicator.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
peng-yongsheng opened a new pull request #6: Delete call type from service
relation.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/6
This is an automated message from the Apache Git Service.
To respond
wu-sheng closed pull request #6: Delete call type from service relation.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
wu-sheng closed pull request #5: Add sum indicator operator and fixed a service
relation columns facto…
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/5
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
wu-sheng commented on issue #772: [Agent] Support kafka framework
URL:
https://github.com/apache/incubator-skywalking/pull/772#issuecomment-360038297
@ascrutae Glad you have the supported versions and test cases. But I still
need your Segment sample data description, to make sure the
wu-sheng commented on issue #773: [collector]how to set es auth configure?
URL:
https://github.com/apache/incubator-skywalking/issues/773#issuecomment-360028894
@peng-yongsheng I think this is not supported yet, right? @cyberdak Do you
have interests to submit a pull request to add this
wu-sheng commented on issue #767: Reach for helps on .NET agent (Move from mail)
URL:
https://github.com/apache/incubator-skywalking/issues/767#issuecomment-360029447
@evbasso I think you will be interested in this:
* https://twitter.com/AsfSkyWalking/status/956038560934760453
*
wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser
URL:
https://github.com/apache/incubator-skywalking/issues/763#issuecomment-360036844
@ascrutae I don't think that means anything if you have removed `URLParser`.
The URL parser should be tested, but in
hanahmily commented on issue #775: Feature/graphql ui
URL:
https://github.com/apache/incubator-skywalking/pull/775#issuecomment-359989355
I will adapt the UI for the next two days. Once this is done, the pr could
be merged.
zone1511 opened a new issue #92: unable to build the project under feature/5.0.0
URL: https://github.com/apache/incubator-skywalking-ui/issues/92
two errors occurs
1. Dashboard.java:[31,2] incompatible types: graphql.schema.GraphQLSchema
cannot be converted to
wu-sheng commented on issue #748: Support for MicroProfile OpenTracing?
URL:
https://github.com/apache/incubator-skywalking/issues/748#issuecomment-357238080
> First, I am not very familiar with this project. Is it sort of agent-based
tracer right?
Yes, agent based. `@Trace`
coveralls commented on issue #765: [Agent] update supported list
URL:
https://github.com/apache/incubator-skywalking/pull/765#issuecomment-358300253
[](https://coveralls.io/builds/15086925)
Coverage remained the same
wu-sheng opened a new pull request #751: Update NOTICE.txt
URL: https://github.com/apache/incubator-skywalking/pull/751
Update year to 2018
This is an automated message from the Apache Git Service.
To respond to the message,
coveralls commented on issue #753: Create DISCLAIMER
URL:
https://github.com/apache/incubator-skywalking/pull/753#issuecomment-357488076
[](https://coveralls.io/builds/15040712)
Coverage remained the same at 22.129%
coveralls commented on issue #764: Add a missing field.
URL:
https://github.com/apache/incubator-skywalking/pull/764#issuecomment-358289957
[](https://coveralls.io/builds/15086267)
Coverage remained the same at
wu-sheng opened a new issue #90: Add NOTICE file to describe the related
licenses
URL: https://github.com/apache/incubator-skywalking-ui/issues/90
By following ASF rules, each release project should have a `NOTICE.txt`
file, including all related projects and their license. But be
coveralls commented on issue #751: Update NOTICE.txt
URL:
https://github.com/apache/incubator-skywalking/pull/751#issuecomment-357483404
[](https://coveralls.io/builds/15040308)
Coverage remained the same at 22.129%
wu-sheng closed pull request #751: Update NOTICE.txt
URL: https://github.com/apache/incubator-skywalking/pull/751
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
peng-yongsheng commented on issue #720: access AbstractTracerContext from
ContextManager
URL:
https://github.com/apache/incubator-skywalking/issues/720#issuecomment-359160460
-1 (binding)
>Do something in collector module to collect those sql is a good idea.
zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser
URL:
https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359153634
As the parser moved to individual database plugin . The original test
case in jdbc common is no longer valid. Should I
wu-sheng commented on issue #720: access AbstractTracerContext from
ContextManager
URL:
https://github.com/apache/incubator-skywalking/issues/720#issuecomment-359145329
@peng-yongsheng The vote is going to end so. Please take a vote.
wu-sheng commented on issue #763: Decouple JDBCURL parser logic from URLParser
URL:
https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359147348
@zone1511 Sorry for misleading you. You need to push the SPI init later,
maybe use a double-check lock in Interceptor can
wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser
question
URL:
https://github.com/apache/incubator-skywalking/pull/770#issuecomment-359147904
cc @zone1511
hanahmily commented on issue #92: unable to build the project under
feature/5.0.0
URL:
https://github.com/apache/incubator-skywalking-ui/issues/92#issuecomment-359643515
This branch is under development. Please use the latest release.
hanahmily closed issue #92: unable to build the project under feature/5.0.0
URL: https://github.com/apache/incubator-skywalking-ui/issues/92
This is an automated message from the Apache Git Service.
To respond to the
ascrutae commented on issue #772: [Agent] Support kafka framework
URL:
https://github.com/apache/incubator-skywalking/pull/772#issuecomment-359669107
Here is the report:
ascrutae commented on issue #763: Decouple JDBCURL parser logic from URLParser
URL:
https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359474143
Maybe you can also mock `URLParser` class under the test case. and then You
can get the mock `URLParser` instance by using
coveralls commented on issue #772: [Agent] Support kafka framework
URL:
https://github.com/apache/incubator-skywalking/pull/772#issuecomment-359405914
[](https://coveralls.io/builds/15160819)
Coverage decreased
zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser
URL:
https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359262821
@wu-sheng I just found that if the parser is moved to each db plugin, some
other class's test case will failed due to the
peng-yongsheng opened a new pull request #775: Feature/graphql ui
URL: https://github.com/apache/incubator-skywalking/pull/775
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve
tanjianhui1979 closed issue #776: ??Spring Cloud???
URL: https://github.com/apache/incubator-skywalking/issues/776
This is an automated message from the Apache Git Service.
To respond to the message, please log
tanjianhui1979 commented on issue #776: ??Spring Cloud???
URL:
https://github.com/apache/incubator-skywalking/issues/776#issuecomment-360108857
??
https://github.com/SkywalkingTest/spring-cloud-example
??https://github.com/SkywalkingTest
wdengw commented on issue #886: Got IllegalArgumentExceptions when calling
SpanBuilder.asChildOf()
URL:
https://github.com/apache/incubator-skywalking/issues/886#issuecomment-370829788
The fix does eliminated the exception. Traces are record and shown on UI.
But the traces are not
ascrutae commented on issue #855: Begin SkyWalking 5.0.0-alpha e2e integration
test.
URL:
https://github.com/apache/incubator-skywalking/issues/855#issuecomment-370845601
# Test Report @ 03/06
## Trace
* **[UI]** The trace graph can?t display in multiple global trace id
coveralls commented on issue #890: Update COC to Apache edition
URL:
https://github.com/apache/incubator-skywalking/pull/890#issuecomment-370968979
[](https://coveralls.io/builds/15824982)
Coverage remained the same
coveralls commented on issue #891: Get the MQ server address id from reference.
URL:
https://github.com/apache/incubator-skywalking/pull/891#issuecomment-370972293
[](https://coveralls.io/builds/15825227)
Coverage
wu-sheng closed pull request #893: Feature/readme
URL: https://github.com/apache/incubator-skywalking/pull/893
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request
coveralls commented on issue #890: Update COC to Apache edition
URL:
https://github.com/apache/incubator-skywalking/pull/890#issuecomment-370968979
[](https://coveralls.io/builds/15825596)
Coverage remained the same
wu-sheng closed pull request #798: Add CHANGELOG for our next release
URL: https://github.com/apache/incubator-skywalking/pull/798
This is an automated message from the Apache Git Service.
To respond to the message, please
coveralls commented on issue #889: Update doc for UI Deploying
URL:
https://github.com/apache/incubator-skywalking/pull/889#issuecomment-370963145
[](https://coveralls.io/builds/15824863)
Coverage remained the same
wu-sheng closed pull request #779: Proposal our ROADMAP.
URL: https://github.com/apache/incubator-skywalking/pull/779
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
wu-sheng opened a new issue #902: [UI] Optimize topology re-render when auto
refresh open.
URL: https://github.com/apache/incubator-skywalking/issues/902
In current version, 5.0.0 alpha, if user open Topology or application
dependency graph, and open refresh at the same time, the graph
wu-sheng opened a new issue #135: Don't refresh Trace page when auto refresh is
on
URL: https://github.com/apache/incubator-skywalking-ui/issues/135
Trace is too many, and people are not usually looking for the latest one,
except for preview and demo. And if refresh the list every time,
wu-sheng closed issue #902: [UI] Optimize topology re-render when auto refresh
open.
URL: https://github.com/apache/incubator-skywalking/issues/902
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng commented on issue #902: [UI] Optimize topology re-render when auto
refresh open.
URL:
https://github.com/apache/incubator-skywalking/issues/902#issuecomment-371336424
Moving this to UI repo.
This is an automated
wu-sheng opened a new issue #134: Add total distributed calls in Overview page
URL: https://github.com/apache/incubator-skywalking-ui/issues/134
For improving the end user experience, current overview is too static. I
recommend to add a new metric, also a new backend service.
The
hanahmily opened a new pull request #131: Fix mq trace request variables type
error
URL: https://github.com/apache/incubator-skywalking-ui/pull/131
Fix https://github.com/apache/incubator-skywalking/issues/855 trace UI issue.
wu-sheng closed pull request #132: Add Apache license comment
URL: https://github.com/apache/incubator-skywalking-ui/pull/132
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ascrutae opened a new pull request #895: Update deploy docs
URL: https://github.com/apache/incubator-skywalking/pull/895
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve
wu-sheng closed pull request #894: Update UI submodule
URL: https://github.com/apache/incubator-skywalking/pull/894
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
coveralls commented on issue #895: Update deploy docs
URL:
https://github.com/apache/incubator-skywalking/pull/895#issuecomment-371012015
[](https://coveralls.io/builds/15844488)
Coverage remained the same at 19.29%
701 - 800 of 1696 matches
Mail list logo
