Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Nicolas Peltier
Hi Bertrand! this looks cool and compact indeed! Not playing with semantics here, but don't you see any adherence with sling features? I know those were originally written for initiating an instance, however it's interesting in my opinion to have a "snapshot" of what an instance can do

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Justin Edelson
One thing I noticed in the example is the (apparent) use of the class name as the namespace. While there doesn't appear to be anything in the API to encourage or require this (if anything the opposite), I'd suggest updating the example to use something that wasn't an implementation detail so that

[GitHub] justinedelson opened a new pull request #1: don't use class names as example namespaces

2018-06-21 Thread GitBox
justinedelson opened a new pull request #1: don't use class names as example namespaces URL: https://github.com/apache/sling-org-apache-sling-capabilities/pull/1 This is an automated message from the Apache Git Service. To

[jira] [Updated] (SLING-7751) Commons Html - Underlying parser implementation uses system charset

2018-06-21 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7751: -- Summary: Commons Html - Underlying parser implementation uses system charset (was: Underlying

[jira] [Created] (SLING-7751) Underlying parser implementation uses system charset to create Reader

2018-06-21 Thread Jason E Bailey (JIRA)
Jason E Bailey created SLING-7751: - Summary: Underlying parser implementation uses system charset to create Reader Key: SLING-7751 URL: https://issues.apache.org/jira/browse/SLING-7751 Project: Sling

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Jörg Hoh
Hi Bertrand, 2018-06-20 15:38 GMT+02:00 Bertrand Delacretaz : > Hi, > > I've been working on a (very simple) module to create a "capabilities" > endpoint, where a Sling instance can let HTTP clients know about its > version levels, presence or absence of certain services etc. > > do you see

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Jörg Hoh
Hi Betrand, 2018-06-21 15:28 GMT+02:00 Bertrand Delacretaz : > > > I think we have discussed a few times how to restrict the execution of > certain servlets like this one, as currently any user who can create a > node with the sling/capabilities resource type can get access to that >

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Eric Norman
How do you intend to prevent unauthorizrd users from creating a readable resource with that resource type? Especially with the nt:unstructured data models that are so popular? Maybe I don't fully follow what the general use cases are where a http client would need this information. Is this

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-21 Thread Hasini Witharana
Below diagram contains the OIDC flow. ​ On Thu, Jun 21, 2018 at 7:19 AM, Hasini Witharana wrote: > Hi all, > > I am implementing an OpenID Connect(OIDC) handler for Apache Sling. In an > OIDC request there is a parameter called state. Below is the definition > given to state in OIDC

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Bertrand Delacretaz
Hi, On Wed, Jun 20, 2018 at 9:47 PM Eugen Stan wrote: > On 20.06.2018 19:02, Eric Norman wrote: > >... It seems to me that there a risk that this endpoint could leave the > >system > > vulnerable to an information disclosure attack. > > > I was thinking the same thing. I think this should be

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Bertrand Delacretaz
Hi Oliver, On Wed, Jun 20, 2018 at 7:48 PM Oliver Lietz wrote: > ...is there no way already to query all available OSGi Capabilities?... That's probably possible but I'm focusing on application-level capabilities here, which might not map directly to OSGi capabilities. For example, an external

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Bertrand Delacretaz
Hi Robert, On Wed, Jun 20, 2018 at 4:09 PM Robert Munteanu wrote: > ...My single note is that the CapabilitiesSource's javadoc says that "(the > capability) name must be unique in a given Sling instance.". I don't > see this enforced or at least checked + logged anywhere Good point! I have

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Bertrand Delacretaz
Hi Jason, On Wed, Jun 20, 2018 at 3:51 PM Jason Bailey wrote: > ...There is an existing VersionInfoServlet in the Default Get servlets > bundle. Would this > module eliminate the need for that service?... Probably - it's easy to provide the same information with the capabilities module. The

Re: New "capabilities" module, feedback welcome

2018-06-21 Thread Bertrand Delacretaz
Hi, On Wed, Jun 20, 2018 at 3:38 PM Bertrand Delacretaz wrote: > ...It's at https://github.com/apache/sling-whiteboard/tree/master/capabilities > and if no one is opposed I'll move it to its own module... As there were no objections (but a few good comments that I'll address next) I have now

[jira] [Commented] (SLING-7684) Add Badges to GitHub Repo Readmes

2018-06-21 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519355#comment-16519355 ] Bertrand Delacretaz commented on SLING-7684: What do you see as the source of truth for those

Re: Upcoming Scripting releases – contrib

2018-06-21 Thread Bertrand Delacretaz
Hi Jason, On Thu, Jun 21, 2018 at 2:53 PM Jason E Bailey wrote: > ...I've been thinking about this in relation to the downloads section. I > believe it would be helpful to > partition the downloads into sections that help describe their roles Agreed, and I think these partitions should be

Re: Upcoming Scripting releases – contrib

2018-06-21 Thread Jason E Bailey
I've been thinking about this in relation to the downloads section. I believe it would be helpful to partition the downloads into sections that help describe their roles. Some ideas being - Core - being modules that make Sling what it is and must be installed Integrations - Not core, but

Re: [RESULT][VOTE] Release Apache Slingstart Maven Plugin version 1.8.2

2018-06-21 Thread David Bosschaert
On Thu, 21 Jun 2018 at 11:14, Bertrand Delacretaz wrote: > On Tue, Jun 12, 2018 at 3:02 PM David Bosschaert > wrote: > > This vote is successful > > I have now copied the released files to > https://dist.apache.org/repos/dist/release/sling/ > > -Bertrand > Thanks Bertrand! David

Re: [RESULT][VOTE] Release Apache Slingstart Maven Plugin version 1.8.2

2018-06-21 Thread Bertrand Delacretaz
On Tue, Jun 12, 2018 at 3:02 PM David Bosschaert wrote: > This vote is successful I have now copied the released files to https://dist.apache.org/repos/dist/release/sling/ -Bertrand

Re: [RESULT][VOTE] Release Apache Sling Feature, Feature-IO, Feature-Analyser and Feature-ModelConverter 0.1.2

2018-06-21 Thread Bertrand Delacretaz
On Fri, Jun 8, 2018 at 4:29 PM wrote: > This vote has passed... I have now copied the released files to https://dist.apache.org/repos/dist/release/sling/ -Bertrand

[jira] [Resolved] (SLING-7730) Distribution package is lost if there is an installation error on receiver side

2018-06-21 Thread Simone Tripodi (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-7730. --- Resolution: Fixed Configuration added in

Re: Upcoming Scripting releases – contrib

2018-06-21 Thread Bertrand Delacretaz
Hi, On Wed, Jun 20, 2018 at 7:41 PM Oliver Lietz wrote: > ...Do we need a contrib status at all now activity is much more visible due to > GitHub?... I think we do - "contrib" is our way to say "this module is not considered core and might stop being maintained without notice". I think we