Re: [Done] Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Eric Norman
One other thing I noticed is that the html emitted by the new startup filter seems to have a "health report" html comment injected into the output with some details. Strict security folks will probably interpret returning those administrative details to the end users as an information disclosure

Re: [Done] Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Eric Norman
Hi Georg, I'm trying to digest what has been done here. It looks like this makes the solution that was done for https://issues.apache.org/jira/browse/SLING-7764 obsolete and breaks compatibility for any customization done via a fragment attached to the previous o.a.sling.starter.startup snapshot

Re: [Jenkins] Sling » sling-org-apache-sling-starter » master #38 is FIXED

2019-05-22 Thread Georg Henzler
Without making a change... locally it always ran fine as well. Let's see if this comes back. On 2019-05-23 01:08, Apache Jenkins Server wrote: Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/38/ for details. No further emails will be sent until the

[Jenkins] Sling » sling-org-apache-sling-starter » master #38 is FIXED

2019-05-22 Thread Apache Jenkins Server
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/38/ for details. No further emails will be sent until the status of the build is changed.

[Done] Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Georg Henzler
Hi all, I finished this, mostly with commit [1]. I moved some bundles into different start levels for better startup behaviour (that way I got could finish this without fixing SLING-8355 first). -Georg [1]

[jira] [Resolved] (SLING-8418) Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler resolved SLING-8418. -- Resolution: Fixed > Consolidate starter-startup and startupfilter/startupfilter-disabler to

[jira] [Commented] (SLING-8418) Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846260#comment-16846260 ] Georg Henzler commented on SLING-8418: -- Marked the following modules as obsolete (only leaving the

[jira] [Commented] (SLING-8418) Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter

2019-05-22 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846250#comment-16846250 ] Georg Henzler commented on SLING-8418: -- Fixed starter to use the

[Jenkins] Sling » sling-org-apache-sling-starter » master #37 is BROKEN

2019-05-22 Thread Apache Jenkins Server
s/jenkins-slave/workspace/-org-apache-sling-starter_master@tmp/withMavene0938a7e/maven-spy-20190522-215856-9855631247824003810303.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:verify (default) on project org.apache.sling.starter: There are test failures. [ER

Re: [VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Georg Henzler
+1 -Georg On 2019-05-22 21:32, Carsten Ziegeler wrote: +1 Radu Cotescu wrote Hi, We solved 3 issue(s) in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344588 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2083/ You can

Re: [VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Carsten Ziegeler
+1 Radu Cotescu wrote Hi, We solved 3 issue(s) in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344588 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2083/ You can use this UNIX script to download the release and verify the

Re: [VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Karl Pauls
+1 regards, Karl On Wed, May 22, 2019 at 6:32 PM Daniel Klco wrote: > > +1 > > On Wed, May 22, 2019 at 12:12 PM Radu Cotescu wrote: > > > +1 > > > > > On 22 May 2019, at 18:08, Radu Cotescu wrote: > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > >

Re: [VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Daniel Klco
+1 On Wed, May 22, 2019 at 12:12 PM Radu Cotescu wrote: > +1 > > > On 22 May 2019, at 18:08, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >

[jira] [Commented] (SLING-8425) NPE in SlingScriptEngineManager when Sling is run on GraalVM

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846023#comment-16846023 ] Radu Cotescu commented on SLING-8425: - (y) bq. I can confirm that the latest fixes work on GraalVM.

[jira] [Commented] (SLING-8425) NPE in SlingScriptEngineManager when Sling is run on GraalVM

2019-05-22 Thread Paul Bjorkstrand (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846018#comment-16846018 ] Paul Bjorkstrand commented on SLING-8425: - Thanks for the assist [~radu.cotescu]. I can confirm

Re: [VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Radu Cotescu
+1 > On 22 May 2019, at 18:08, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[VOTE] Release Apache Sling Scripting Core 2.0.58

2019-05-22 Thread Radu Cotescu
Hi, We solved 3 issue(s) in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344588 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2083/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-8432) Provide support for running the Pax tests on Java 9 and higher

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8432. - Resolution: Fixed Fixed in [commit

[jira] [Created] (SLING-8432) Provide support for running the Pax tests on Java 9 and higher

2019-05-22 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-8432: --- Summary: Provide support for running the Pax tests on Java 9 and higher Key: SLING-8432 URL: https://issues.apache.org/jira/browse/SLING-8432 Project: Sling

[jira] [Resolved] (SLING-8431) On Java 11 the platform provided script engine factories might be registered more than once

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8431. - Resolution: Fixed Fixed in [commit

[jira] [Updated] (SLING-8428) Add Mixin and nt:linkedFile Support to JCR_OAK

2019-05-22 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominique Jäggi updated SLING-8428: --- Attachment: SLING-8428-mixin-linkedfile-sling-mock-oak.patch

[jira] [Commented] (SLING-8428) Add Mixin and nt:linkedFile Support to JCR_OAK

2019-05-22 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845799#comment-16845799 ] Dominique Jäggi commented on SLING-8428: [~sseif...@pro-vision.de], found a couple of issues :) 

[jira] [Created] (SLING-8431) On Java 11 the platform provided script engine factories might be registered more than once

2019-05-22 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-8431: --- Summary: On Java 11 the platform provided script engine factories might be registered more than once Key: SLING-8431 URL: https://issues.apache.org/jira/browse/SLING-8431

[jira] [Resolved] (SLING-8425) NPE in SlingScriptEngineManager when Sling is run on GraalVM

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8425. - Resolution: Fixed > NPE in SlingScriptEngineManager when Sling is run on GraalVM >

[jira] [Updated] (SLING-8425) NPE in SlingScriptEngineManager when Sling is run on GraalVM

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-8425: Fix Version/s: Scripting Core 2.0.58 > NPE in SlingScriptEngineManager when Sling is run on

[jira] [Commented] (SLING-8425) NPE in SlingScriptEngineManager when Sling is run on GraalVM

2019-05-22 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845705#comment-16845705 ] Radu Cotescu commented on SLING-8425: - Fixed in [commit

[GitHub] [sling-org-apache-sling-scripting-core] raducotescu closed pull request #3: SLING-8425 - Fix NPE on GraalVM

2019-05-22 Thread GitBox
raducotescu closed pull request #3: SLING-8425 - Fix NPE on GraalVM URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/3 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-scripting-core] raducotescu commented on issue #3: SLING-8425 - Fix NPE on GraalVM

2019-05-22 Thread GitBox
raducotescu commented on issue #3: SLING-8425 - Fix NPE on GraalVM URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/3#issuecomment-494714926 @paul-bjorkstrand, thanks for your contribution and your patience! I've added your commits plus my tiny fix to `master`.