You can regard provider type as the implementor of the api of a package
whereas everything marked as consumer type is implemented by users of
that api.
So yes, if you make any changes to that package, add a new interface,
add a new method etc., you need to adjust the implementor.
For
Hi Konrad,
that check in the osgicheck maven plugin checks a single class whether
it contains both annotations - not a whole package
Regards
Carsten
Am 29.06.2021 um 21:27 schrieb Konrad Windszus:
Hi, sorry for the confusion here, I think I may be just wrong.
From the standard policies
+1
Carsten
Am 29.06.2021 um 22:50 schrieb Timothee Maret:
Hi,
This vote covers 2 bundles
1. Content Distribution Journal Messages 0.3.0
We solved 3 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12349663
There are no outstanding issues.
2. Content
Hi Robert
> Why are there version ranges used in the pom?
I was using Maven bracket notation for version ranges that I had actually
tested. But I see it’s not needed, and removed the bracket range on the
versions. Now it builds without downloading any SNAPSHOTS.
> checker-qual-2.11.1.jar
>
Hi,
This vote covers 2 bundles
1. Content Distribution Journal Messages 0.3.0
We solved 3 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12349663
There are no outstanding issues.
2. Content Distribution Core 0.4.6
We solved 13 issues in this release:
Hi Konrad,
Can you confirm that mixing your 3rd scenario (as below) with any of the
other 3 within the same bundle also results in the narrow version range for
that imported package?
@ProviderType 1.1.0 yes
[1.1, 1.2)
[
https://issues.apache.org/jira/browse/SLING-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-10569.
--
Resolution: Done
> Fix broken jacoco-it.exec
> -
>
>
On Tuesday, 29 June 2021 15:51:34 CEST Konrad Windszus wrote:
> Hi,
Hi Konrad,
> there are some useful checks in
> https://github.com/apache/felix-dev/tree/master/tools/osgicheck-maven-plugi
> n which could help improve the code quality of Sling Modules. What do you
> think about enabling these
Hi, sorry for the confusion here, I think I may be just wrong.
From the standard policies from Bnd I do no longer think mixing Consumer and
Provider in one package can lead to breaking users of the API more easily.
Let's quickly recall what the rules are:
Rules for Exported Versions
I haven't looked at this too closely, but do you think that there could be
some benefit to keeping them in separate packages if you expect the
consumer and provider apis to evolve at a different pace?
If I recall correctly, the bundles that import and use stuff from a package
that contains both
[
https://issues.apache.org/jira/browse/SLING-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-10573:
-
Summary: Separate Consumer- and ProviderTypes in packages to improve
package versioning (was:
[
https://issues.apache.org/jira/browse/SLING-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-10574:
-
Labels: sitemaps (was: )
> Reduce code smells and Sonar issues for Sling Sitemap
>
I don't think that not mixing consumer and provider interfaces is a best
practice.
The OSGi specs - which I think are usually following best practices -
are mixing them. For example event admin where the event admin interface
is in the same package as the event handler.
The markers actually
[
https://issues.apache.org/jira/browse/SLING-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph resolved SLING-10574.
--
Resolution: Fixed
> Reduce code smells and Sonar issues for Sling Sitemap
>
Hi Bertrand,
The OSGi semantic versioning whitepaper has a lot of info about this:
https://docs.osgi.org/whitepaper/semantic-versioning/
Best regards,
David
On Tue, 29 Jun 2021 at 15:49, Bertrand Delacretaz
wrote:
> Hi Konrad,
>
> On Tue, Jun 29, 2021 at 3:04 PM Konrad Windszus wrote:
> > -
[
https://issues.apache.org/jira/browse/SLING-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371452#comment-17371452
]
Henry Kuijpers commented on SLING-10136:
We want to use this feature to clean up old paths that
Hi Konrad,
On Tue, Jun 29, 2021 at 3:04 PM Konrad Windszus wrote:
> - Please don't mix Consumer and Provider interfaces in the same package
> (https://github.com/apache/sling-org-apache-sling-sitemap/tree/master/src/main/java/org/apache/sling/sitemap/generator
> and
>
[
https://issues.apache.org/jira/browse/SLING-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371449#comment-17371449
]
Konrad Windszus commented on SLING-10136:
-
For me this goes beyond the scope of repoinit.
Dirk Rudolph created SLING-10574:
Summary: Reduce code smells and Sonar issues for Sling Sitemap
Key: SLING-10574
URL: https://issues.apache.org/jira/browse/SLING-10574
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph resolved SLING-10557.
--
Fix Version/s: Sitemap 1.0.0
Resolution: Fixed
Thank you [~bellingard]
> Activate
[
https://issues.apache.org/jira/browse/SLING-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph resolved SLING-10573.
--
Resolution: Fixed
> Separate Consumer- and ProviderTypes in packages to package versioning
>
[
https://issues.apache.org/jira/browse/SLING-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-10573:
-
Issue Type: Improvement (was: New Feature)
> Separate Consumer- and ProviderTypes in packages
[
https://issues.apache.org/jira/browse/SLING-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph updated SLING-10573:
-
Description:
As [suggested by
Hi,
there are some useful checks in
https://github.com/apache/felix-dev/tree/master/tools/osgicheck-maven-plugin
which could help improve the code quality of Sling Modules. What do you think
about enabling these by default in the upcoming parent release?
The code seems pretty much unmaintained
Dirk Rudolph created SLING-10573:
Summary: Separate Consumer- and ProviderTypes in packages to
package versioning
Key: SLING-10573
URL: https://issues.apache.org/jira/browse/SLING-10573
Project:
bosschaert merged pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Thank you Konrad.
I agree with your points and due to the nature of the last 3 I hereby
cancel the release.
One question though, according to
https://sling.apache.org/documentation/development/release-management.html#wait-for-the-results
I should not reuse the version number. Is that the case
Hi Dirk,
I have some general remarks (mostly minor ones but one should be IMHO fixed
before release)
- Can you update https://sling.apache.org/repolist.html as the new Github repo
doesn't appear there yet.
- Please also use the most recent parent version (43 at the time of writing). A
lot of
[
https://issues.apache.org/jira/browse/SLING-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371319#comment-17371319
]
Fabrice Bellingard commented on SLING-10557:
[~diru] Done, project onboarded on SonarCloud
[
https://issues.apache.org/jira/browse/SLING-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371300#comment-17371300
]
Henry Kuijpers commented on SLING-10136:
Provided PR here [~bdelacretaz]
*
orm encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-122-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven62308a71/maven-spy-20210629-111725-73
henrykuijpers opened a new pull request #20:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
henrykuijpers opened a new pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/SLING-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371263#comment-17371263
]
Konrad Windszus commented on SLING-10571:
-
Well, JCRVLT-170 explicitly states:
bq. The
+1
David
On Tue, 29 Jun 2021 at 10:23, Carsten Ziegeler wrote:
> +1
>
> Carsten
>
> Am 29.06.2021 um 11:05 schrieb dav...@apache.org:
> > Hi all,
> >
> > I'd like to call the release on the following Feature Model related
> > components:
> >
> > Feature Model 1.2.26:
> >
On Tue, 2021-06-29 at 10:05 +0100, dav...@apache.org wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret reassigned SLING-10066:
--
Assignee: Timothee Maret (was: Timothée Maret)
> cleanup logging for content
+1
Carsten
Am 29.06.2021 um 10:24 schrieb Karl Pauls:
We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350326
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2486
You can use this UNIX script to download the
+1
Carsten
Am 29.06.2021 um 11:05 schrieb dav...@apache.org:
Hi all,
I'd like to call the release on the following Feature Model related
components:
Feature Model 1.2.26:
https://issues.apache.org/jira/projects/SLING/versions/12350343
Feature Model API Regions Extension 1.3.4:
+1
regards,
Karl
On Tue, Jun 29, 2021 at 11:05 AM wrote:
>
> Hi all,
>
> I'd like to call the release on the following Feature Model related
> components:
>
> Feature Model 1.2.26:
> https://issues.apache.org/jira/projects/SLING/versions/12350343
>
> Feature Model API Regions Extension 1.3.4:
+1
David
On Tue, 29 Jun 2021 at 09:52, Robert Munteanu wrote:
> On Tue, 2021-06-29 at 10:24 +0200, Karl Pauls wrote:
> > Please vote to approve these releases:
>
> +1
> Robert
>
Hi all,
I'd like to call the release on the following Feature Model related
components:
Feature Model 1.2.26:
https://issues.apache.org/jira/projects/SLING/versions/12350343
Feature Model API Regions Extension 1.3.4:
https://issues.apache.org/jira/projects/SLING/versions/12350347
[
https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10572.
Resolution: Fixed
> Update to latest dependencies
>
On Tue, 2021-06-29 at 10:24 +0200, Karl Pauls wrote:
> Please vote to approve these releases:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10572:
---
Affects Version/s: slingfeature-maven-plugin 1.5.8
> Update to latest
[
https://issues.apache.org/jira/browse/SLING-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-10572:
---
Fix Version/s: (was: slingfeature-maven-plugin 1.5.8)
We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350326
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2486
You can use this UNIX script to download the release and verify the signatures:
Angela Schreiber created SLING-10571:
Summary: Hardcoded application paths in
VaultPackageUtils.detectPackageType
Key: SLING-10571
URL: https://issues.apache.org/jira/browse/SLING-10571
Project:
A. J. David Bosschaert created SLING-10572:
--
Summary: Update to latest dependencies
Key: SLING-10572
URL: https://issues.apache.org/jira/browse/SLING-10572
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10494.
--
> Configuration API should have a way to allow empty configurations
>
[
https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10511.
--
> Remove the ApiRegionsExtensionScanner
> -
>
[
https://issues.apache.org/jira/browse/SLING-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10552.
--
> Update to latest dependencies
> -
>
>
[
https://issues.apache.org/jira/browse/SLING-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10530.
--
> Validation mode is not respected for internal configurations
>
[
https://issues.apache.org/jira/browse/SLING-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10501.
--
> The analyser scanner should pass the artifact url to the resource builder
>
[
https://issues.apache.org/jira/browse/SLING-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10512.
--
> Analysers should not fail if no scanner is found
>
[
https://issues.apache.org/jira/browse/SLING-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10458.
--
> ArtifactManager: Use NIO Files
> --
>
>
[
https://issues.apache.org/jira/browse/SLING-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10545.
--
> Make manifest for content packages optional
>
[
https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10451.
--
> ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp
>
[
https://issues.apache.org/jira/browse/SLING-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10513.
--
> Merging artifact extensions will not preserve the feature origin of the first
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert closed SLING-10186.
--
> Enhance cli parsing on sling-feature-launcher
>
[
https://issues.apache.org/jira/browse/SLING-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-10567.
Resolution: Fixed
> NPE when obtaining ArtifactManager
>
[
https://issues.apache.org/jira/browse/SLING-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-10566:
-
Summary: Keep track of feature origins per configuration property (was:
Keep track of
62 matches
Mail list logo
