[Proposal] Lift OSGi Feature Service impl from Sling Whiteboard into own repo

2021-08-05 Thread davidb
Hi all, At OSGi work has been going on for some time to create the Feature Service specification. This specification is inspired by the Sling Feature model and other similar technologies. The spec is aimed to be finished next month and a draft can already be seen here: https://osgi.github.io/osgi/

[jira] [Closed] (SLING-10695) Create analyser to check for paths in content packages

2021-08-05 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-10695. > Create analyser to check for paths in content packages > ---

[VOTE RESULT] Release Apache Sling Feature Analyser 1.3.30

2021-08-05 Thread Carsten Ziegeler
The vote passes with three binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] commented on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-893901010 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] removed a comment on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-893599723 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resour

Re: [VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Daniel Klco
+1 On Thu, Aug 5, 2021 at 10:11 AM Stefan Seifert wrote: > +1 >

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-893759854 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] removed a comment on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-893707246 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[GitHub] [sling-org-apache-sling-testing-clients] klcodanr commented on a change in pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
klcodanr commented on a change in pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#discussion_r683744467 ## File path: src/main/java/org/apache/sling/testing/clients/SlingClient.java ## @@ -580,6 +588,34 @@ public String getUUId(J

[GitHub] [sling-org-apache-sling-testing-clients] klcodanr commented on a change in pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
klcodanr commented on a change in pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#discussion_r683744278 ## File path: src/test/java/org/apache/sling/testing/clients/SlingClientImpersonationTest.java ## @@ -0,0 +1,106 @@ +/* + *

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] removed a comment on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-893706555 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-893706555 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-893707246 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] removed a comment on pull request #21: SLING-10649 - Adding support for impersonation

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/21#issuecomment-885001505 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[DISCUSS] Sling RepoInit Webconsole

2021-08-05 Thread Daniel Klco
Hi, While working on RepoInit scripts, I felt that there was a need for some means of easily testing RepoInit scripts without having to a) always execute them b) create an OSGi config and then look at logs. I've been working on a web console plugin for users to test and validate their RepoInit sc

[RESULT] [VOTE] Promote org.apache.sling.thumbnails to its own Sling Module

2021-08-05 Thread Daniel Klco
Hi, The vote has passed with the following result : +1 (binding): Bertrand Delacretaz, Robert Munteanu, Dan Klco +1 (non binding): Cris Rockwell I will initiate the request to create the repository and copy the current code over. On Thu, Aug 5, 2021 at 1:51 PM Daniel Klco wrote: > +1 > > On T

Re: [VOTE] Promote org.apache.sling.thumbnails to its own Sling Module

2021-08-05 Thread Daniel Klco
+1 On Thu, Aug 5, 2021 at 8:48 AM Cris Rockwell wrote: > +1 (non-binding) > > Cris R > > > On Jul 27, 2021, at 7:01 PM, Daniel Klco wrote: > > Hi, > > This is a vote to promote the org.apache.sling.thumbnails[1] to its own > Sling Module. This module contains everything needed to create thumbna

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof edited a comment on pull request #27: SLING-10229: DockerHub build - using hooks to build and push

2021-08-05 Thread GitBox
stbischof edited a comment on pull request #27: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-893661294 @rombert At the moment I started to do docker images using buildx and github actions to build images for: os: `ubuntu`, `apline`, `ce

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #27: SLING-10229: DockerHub build - using hooks to build and push

2021-08-05 Thread GitBox
stbischof commented on pull request #27: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-893661294 @rombert At the moment I started to do docker images using buildx and github actions to build images for: os: `ubuntu`, `apline`, `centos`

[jira] [Commented] (SLING-10700) Improve TopologyRequestValidator code

2021-08-05 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394200#comment-17394200 ] Stefan Egli commented on SLING-10700: - I don't know of a reason, then again I wasn't

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] removed a comment on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-893001449 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resour

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] commented on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-893599723 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[jira] [Resolved] (SLING-10680) Add support for versioning partials

2021-08-05 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-10680. -- Resolution: Fixed Implemented in [commit a3c54a4|https://github.com/apache/sling-org-apache-s

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu merged pull request #2: SLING-10680 - Add support for versioning partials

2021-08-05 Thread GitBox
raducotescu merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] removed a comment on pull request #2: SLING-10680 - Add support for versioning partials

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889181474 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resour

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] commented on pull request #2: SLING-10680 - Add support for versioning partials

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-893527721 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/c

[jira] [Resolved] (SLING-10704) Improve log output when repoinit is added

2021-08-05 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10704. -- Resolution: Fixed Improved log output in https://github.com/apache/sling-org-apache-sl

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

2021-08-05 Thread GitBox
raducotescu commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r683531294 ## File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java ## @@ -48,12 +47,24 @@

[jira] [Created] (SLING-10704) Improve log output when repoinit is added

2021-08-05 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-10704: Summary: Improve log output when repoinit is added Key: SLING-10704 URL: https://issues.apache.org/jira/browse/SLING-10704 Project: Sling Issue Type:

RE: [VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Stefan Seifert
+1

[jira] [Assigned] (SLING-10693) Fail for invalid requires or extends files

2021-08-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10693: --- Assignee: Konrad Windszus > Fail for invalid requires or extends files > --

[jira] [Resolved] (SLING-10689) Extends file must not always generate a mandatory Requires-Capability header

2021-08-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10689. - Resolution: Fixed > Extends file must not always generate a mandatory Requires-Capabilit

[jira] [Comment Edited] (SLING-10689) Extends file must not always generate a mandatory Requires-Capability header

2021-08-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394023#comment-17394023 ] Konrad Windszus edited comment on SLING-10689 at 8/5/21, 1:53 PM:

[jira] [Commented] (SLING-10689) Extends file must not always generate a mandatory Requires-Capability header

2021-08-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394023#comment-17394023 ] Konrad Windszus commented on SLING-10689: - In https://github.com/apache/sling-s

Re: [VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Carsten Ziegeler
+1 Carsten Am 05.08.2021 um 15:21 schrieb Radu Cotescu: Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350330 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2511/ You can use this UNIX script to downl

[jira] [Updated] (SLING-10689) Extends file must not always generate a mandatory Requires-Capability header

2021-08-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10689: Summary: Extends file must not always generate a mandatory Requires-Capability header (wa

[GitHub] [sling-scriptingbundle-maven-plugin] kwin merged pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-05 Thread GitBox
kwin merged pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-893473330 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] removed a comment on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-892792652 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality

Re: [VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Karl Pauls
+1 regards, Karl On Thu, Aug 5, 2021 at 3:22 PM Radu Cotescu wrote: > > +1 > > > On 5 Aug 2021, at 15:21, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > -- Karl Pauls karlpa

Re: [VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Radu Cotescu
+1 > On 5 Aug 2021, at 15:21, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[VOTE] Release Apache Sling Scripting Core 2.4.0

2021-08-05 Thread Radu Cotescu
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350330 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2511/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.ap

Re: [VOTE] Promote org.apache.sling.thumbnails to its own Sling Module

2021-08-05 Thread Cris Rockwell
+1 (non-binding) Cris R > On Jul 27, 2021, at 7:01 PM, Daniel Klco wrote: > > Hi, > > This is a vote to promote the org.apache.sling.thumbnails[1] to its own > Sling Module. This module contains everything needed to create thumbnails > of file resources in Sling based applications: > > - a s

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on pull request #27: SLING-10229: DockerHub build - using hooks to build and push

2021-08-05 Thread GitBox
rombert commented on pull request #27: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-893386844 @stbischof - thanks a lot for your efforts, this has been baking for quite some time... At this point do you need input from someone else from the Sl

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] removed a comment on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-889873719 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #97: Add failing unit test for mode attribute dropping

2021-08-05 Thread GitBox
karlpauls commented on pull request #97: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/97#issuecomment-892685612 Should be covered by #98 now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-discovery-base] artem-smotrakov commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

2021-08-05 Thread GitBox
artem-smotrakov commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892790372 > One question regarding your comment on the jira: > > > To be on the safer side, it may be better to set a random IV explicitly. >

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] commented on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-892807952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: Release Management doc question

2021-08-05 Thread Konrad Windszus
IMHO we should just refer to https://infra.apache.org/release-signing.html#keyserver and not try to duplicate that information. > On 5. Aug 2021, at 13:10, Robert Munteanu wrote: > > Hi, > > On Mon, 2021-07-19 at 12:48 -0700, Henry Sa

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-05 Thread GitBox
anchela merged pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-892632345 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/check

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] removed a comment on pull request #7: SLING-10698 use GMT timezone for tests

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/7#issuecomment-891429471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-891834147 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls closed pull request #97: Add failing unit test for mode attribute dropping

2021-08-05 Thread GitBox
karlpauls closed pull request #97: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [sling-scriptingbundle-maven-plugin] sonarcloud[bot] commented on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-892792652 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg

Re: Release Management doc question

2021-08-05 Thread Robert Munteanu
Hi, On Mon, 2021-07-19 at 12:48 -0700, Henry Saginor wrote: > Hi, > > Does anyone know if the following documentation is up to date? > https://sling.apache.org/documentation/development/release-management.html#appendix-a-create-and-add-your-key-to-peopleapacheorg-and-https--downloadsapacheorg-sli

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

2021-08-05 Thread GitBox
stefan-egli commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892747074 Thanks @artem-smotrakov for the PR. It looks good to me. One question regarding your comment on the jira: > To be on the safer side, i

Re: [VOTE] Promote org.apache.sling.thumbnails to its own Sling Module

2021-08-05 Thread Robert Munteanu
On Tue, 2021-07-27 at 19:01 -0400, Daniel Klco wrote: > Please cast your votes: +1 Robert signature.asc Description: This is a digitally signed message part