[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354339237 Ok, so what about a global "strict" flag (in addition to new instruction) set via OSGi configuration (for the default). For the new instruction I propose `create

[GitHub] [sling-org-apache-sling-jcr-repoinit] cziegeler commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

cziegeler commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354301334 I have worked with users over the past year a lot where exactly such a change from best effort to fail caused so much pain - and while it seems logical to fix

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354270703 > We must not repeat this bad experience. If developers cannot rely on the repo having the state as prescribed in repoinit there must be a lot of boilerplate

[GitHub] [sling-org-apache-sling-jcr-repoinit] cziegeler commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

cziegeler commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354261187 I think we are past the point of being able to make breaking changes. It is not a question of best effort or fail - it is a question of a breaking change that

[VOTE] Release Apache Sling App CMS version 1.1.4

Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12352558 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2707/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Updated] (SLING-11727) Do not rely on order of JSON attributes in test

[ https://issues.apache.org/jira/browse/SLING-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11727: Summary: Do not rely on order of JSON attributes in test (was: Test Failures on NonDex)

[jira] [Assigned] (SLING-11727) Test Failures on NonDex

[ https://issues.apache.org/jira/browse/SLING-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11727: --- Assignee: Konrad Windszus > Test Failures on NonDex > --- > >

[jira] [Updated] (SLING-11727) Test Failures on NonDex

[ https://issues.apache.org/jira/browse/SLING-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11727: Fix Version/s: Servlets Get 2.1.46 > Test Failures on NonDex > --- >

[jira] [Resolved] (SLING-11727) Test Failures on NonDex

[ https://issues.apache.org/jira/browse/SLING-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11727. - Resolution: Fixed Fixed in

[jira] [Updated] (SLING-11727) Test Failures on NonDex

[ https://issues.apache.org/jira/browse/SLING-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11727: Component/s: Servlets > Test Failures on NonDex > --- > >

[GitHub] [sling-org-apache-sling-servlets-get] kwin merged pull request #9: SLING-11727 Fixed Flaky Tests

kwin merged PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #9: SLING-11727 Fixed Flaky Tests

sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#issuecomment-1353638541 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-servlets-get] priyanka-28 commented on pull request #9: SLING-11727 Fixed Flaky Tests

priyanka-28 commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#issuecomment-1353619296 > @priyanka-28 See [#9 (comment)](https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#discussion_r1049404053) @kwin Thank you! Added the

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1353481190 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1353400370 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1353398344 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #42: SLING-11737: jcr-repoinit - fix test failures on Windows

sonarcloud[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/42#issuecomment-1353301549 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Created] (SLING-11737) jcr-repoinit: SetPropertiesTest failures

Julian Reschke created SLING-11737: -- Summary: jcr-repoinit: SetPropertiesTest failures Key: SLING-11737 URL: https://issues.apache.org/jira/browse/SLING-11737 Project: Sling Issue Type: Bug

[GitHub] [sling-org-apache-sling-jcr-repoinit] reschke commented on pull request #39: SLING-11621: Update JCR dependencies

reschke commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#issuecomment-1353215184 Dependencies should be complete and correct now. Sorry for the inconvenience. I still have test failures, but those iccur on master as well and are likely

[GitHub] [sling-org-apache-sling-jcr-repoinit] reschke commented on a diff in pull request #39: SLING-11621: Update JCR dependencies

reschke commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#discussion_r1049697677 ## pom.xml: ## @@ -36,8 +36,8 @@ -2.18.2 -1.22.1 +2.20.6 Review Comment: I don't think that comment was actionable.

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049653810 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049656818 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] anchela commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

anchela commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049655681 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049653810 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1353085674 @bdelacretaz I think your comment as the original inventor of repoinit would be helpful in this. The fundamental question really is: Best effort or fail? Currently

[GitHub] [sling-org-apache-sling-jcr-repoinit] anchela commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

anchela commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049651725 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #39: SLING-11621: Update JCR dependencies

kwin commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#discussion_r1049634987 ## pom.xml: ## @@ -36,8 +36,8 @@ -2.18.2 -1.22.1 +2.20.6 Review Comment: @reschke Please don't resolve without

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #39: SLING-11621: Update JCR dependencies

kwin commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#discussion_r1049634987 ## pom.xml: ## @@ -36,8 +36,8 @@ -2.18.2 -1.22.1 +2.20.6 Review Comment: @reschke Please don't resolve without

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #39: SLING-11621: Update JCR dependencies

kwin commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#issuecomment-1353056281 @reschke the build fails now due to a missing dependency (was probably transitively inherited before). -- This is an automated message from the Apache Git

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049628980 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049626773 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049627267 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #14: SLING-10281 revert SLING-9449

sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1353050400 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049626773 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049625048 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1353043016 > failures in repoinit will prevent the repository from starting altogether We are in a predicament because without it the repository may not start either

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #14: SLING-10281 revert SLING-9449

kwin commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1353038192 If there are no further concerns I am gonna merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [sling-org-apache-sling-jcr-repoinit] anchela commented on a diff in pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

anchela commented on code in PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#discussion_r1049613439 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodeVisitor.java: ## @@ -57,18 +59,33 @@ public void visitCreatePath(CreatePath cp) {

[jira] [Commented] (SLING-11621) Outdated JCR dependencies

[ https://issues.apache.org/jira/browse/SLING-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648046#comment-17648046 ] Julian Reschke commented on SLING-11621: Oversight, I guess. Now ready (and updated). >

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #39: SLING-11621: Update JCR dependencies

kwin commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/39#discussion_r1049608269 ## pom.xml: ## @@ -36,8 +36,8 @@ -2.18.2 -1.22.1 +2.20.6 Review Comment: AEM 6.5 (15) is still on 2.20.4, but if it is

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #41: SLING-11736 adjust types of existing nodes with "create path ..."

sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1353018654 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Assigned] (SLING-10463) Repoinit fails to create node if property already exists at the same path

[ https://issues.apache.org/jira/browse/SLING-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10463: --- Assignee: Konrad Windszus > Repoinit fails to create node if property already

[jira] [Updated] (SLING-10463) Repoinit fails to create node if property already exists at the same path

[ https://issues.apache.org/jira/browse/SLING-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10463: Fix Version/s: Repoinit JCR 1.1.44 > Repoinit fails to create node if property already

[jira] [Commented] (SLING-11621) Outdated JCR dependencies

[ https://issues.apache.org/jira/browse/SLING-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648036#comment-17648036 ] Konrad Windszus commented on SLING-11621: - [~reschke] Any reason why the PR is only a draft? I

[jira] [Updated] (SLING-11621) Outdated JCR dependencies

[ https://issues.apache.org/jira/browse/SLING-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11621: Fix Version/s: Repoinit JCR 1.1.44 > Outdated JCR dependencies >

[jira] [Updated] (SLING-11736) Create path should potentially adjust the primary type/mixin types of existing paths

[ https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11736: Fix Version/s: Repoinit JCR 1.1.44 > Create path should potentially adjust the primary

[jira] [Updated] (SLING-10281) Revert SLING-9449: set principal ACL should throw an Exception it it fails

[ https://issues.apache.org/jira/browse/SLING-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-10281: Fix Version/s: Repoinit JCR 1.1.44 > Revert SLING-9449: set principal ACL should throw an

[jira] [Assigned] (SLING-10281) Revert SLING-9449: set principal ACL should throw an Exception it it fails

[ https://issues.apache.org/jira/browse/SLING-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10281: --- Assignee: Konrad Windszus (was: Bertrand Delacretaz) > Revert SLING-9449: set

[jira] [Assigned] (SLING-11736) Create path should potentially adjust the primary type/mixin types of existing paths

[ https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11736: --- Assignee: Konrad Windszus > Create path should potentially adjust the primary

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #19: SLING-10463 - "create path" should fail if a property exists at the same path

kwin commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/19#issuecomment-1352991899 Superseded by #41. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin closed pull request #19: SLING-10463 - "create path" should fail if a property exists at the same path

kwin closed pull request #19: SLING-10463 - "create path" should fail if a property exists at the same path URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin opened a new pull request, #41: SLING-11736 adjust types of existing nodes with "create path ..."

kwin opened a new pull request, #41: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41 Also fixes SLING-10463 by bailing out in case same name property exists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: SLING-11709 - Set up Jira autolinks to all Sling Github projects

Sounds good to me. Could we at the same reestablish auto-linking of GitHub PRs with https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Jiranotificationoptions I would suggest just adding "jira_optionsL link", as the other options probably cause too

[GitHub] [sling-org-apache-sling-servlets-get] kwin commented on pull request #9: SLING-11727 Fixed Flaky Tests

kwin commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#issuecomment-1352905756 @priyanka-28 See https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#discussion_r1049404053 -- This is an automated message from the Apache Git

[jira] [Resolved] (SLING-11735) Separate node operations from ACL operations

[ https://issues.apache.org/jira/browse/SLING-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11735. - Fix Version/s: Repoinit JCR 1.1.44 Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin merged pull request #40: SLING-11735 separate node from ACL operations

kwin merged PR #40: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-servlets-get] priyanka-28 commented on pull request #9: SLING-11727 Fixed Flaky Tests

priyanka-28 commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#issuecomment-1352890716 > Looks good to me now, apart from the minor nits in the comments. @kwin Updated PR! -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (SLING-11736) Create path should potentially adjust the primary type/mixin types of existing paths

[ https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647995#comment-17647995 ] Bertrand Delacretaz commented on SLING-11736: - I won't be able to work on this right now but

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #9: SLING-11727 Fixed Flaky Tests

sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#issuecomment-1352803508 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

New repository for SLING-11729 (RepoInit FileVault Validator)

Hi, I proposed a FileVault validator for RepoInit in https://issues.apache.org/jira/browse/SLING-11729 . The initial source can be found in https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.repoinit.filevault.validator

[jira] [Commented] (SLING-11729) Add FileVault validator for repoinit files contained in serialized OSGi configs

[ https://issues.apache.org/jira/browse/SLING-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647960#comment-17647960 ] Konrad Windszus commented on SLING-11729: - It works as outlined above. I clarified that in the

[GitHub] [sling-org-apache-sling-servlets-get] kwin commented on a diff in pull request #9: SLING-11727 Fixed Flaky Tests

kwin commented on code in PR #9: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/9#discussion_r1049404053 ## src/test/java/org/apache/sling/servlets/get/impl/helpers/JsonRendererTest.java: ## @@ -182,7 +184,12 @@ public void testNumber() throws

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on a diff in pull request #23: SLING-8843 repoinit developer mode

kwin commented on code in PR #23: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/23#discussion_r1049384148 ## src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java: ## @@ -177,5 +192,10 @@ protected void

[GitHub] [sling-org-apache-sling-jcr-repoinit] kwin commented on pull request #19: SLING-10463 - "create path" should fail if a property exists at the same path

kwin commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/19#issuecomment-1352750820 @bdelacretaz What happened to this PR? To me it looks good and I would appreciate to get this merged after fixing the conflict... -- This is an automated message

[jira] [Resolved] (SLING-11732) Add method ModelFactory.createModelFromWrappedRequest(...)

[ https://issues.apache.org/jira/browse/SLING-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11732. - Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-models-impl] kwin merged pull request #41: SLING-11732 Add createModelFromWrappedRequest(...)

kwin merged PR #41: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-models-api] kwin merged pull request #10: SLING-11732 Add createModelFromWrappedRequest(...)

kwin merged PR #10: URL: https://github.com/apache/sling-org-apache-sling-models-api/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-feature-analyser] cziegeler merged pull request #43: SLING-11734 : ContentPackageScanner does not extract the right artifa…

cziegeler merged PR #43: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: