[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1546475553 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1546468438 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header

2023-05-12 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722287#comment-17722287 ] Dan Klco commented on SLING-11871: -- Correct [~cziegeler], this would only apply for modification

[jira] [Commented] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter

2023-05-12 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722288#comment-17722288 ] Dan Klco commented on SLING-9061: - Potential PR

[GitHub] [sling-org-apache-sling-security] sonarcloud[bot] commented on pull request #9: SLING-9061 - Adding support for evaluating the origin as well as the referrer and pluggable referrer configura

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-security/pull/9#issuecomment-1546300954 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #23: SLING-11874 auto-set created/lastModified prop values when appropriate

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/23#issuecomment-1546282585 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-jcr-mock] enapps-enorman opened a new pull request, #23: SLING-11874 auto-set created/lastModified prop values when appropriate

2023-05-12 Thread via GitHub
enapps-enorman opened a new pull request, #23: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/23 MockNode should auto-set system generated value if the specified property definition is known to expect it. This should happen in the addNode and the addMixin

[jira] [Created] (SLING-11874) MockNode should auto-set created/lastModified prop values when appropriate

2023-05-12 Thread Eric Norman (Jira)
Eric Norman created SLING-11874: --- Summary: MockNode should auto-set created/lastModified prop values when appropriate Key: SLING-11874 URL: https://issues.apache.org/jira/browse/SLING-11874 Project:

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #40: SLING-11067 extend URIProvider by method returning Optional

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-api/pull/40#issuecomment-1545977904 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1773#comment-1773 ] Konrad Windszus commented on SLING-11871: - Why not implementing a real validation instead of

[jira] [Resolved] (SLING-11865) Conversion fails when initial content document does not include namespace declaration

2023-05-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11865. - Fix Version/s: (was: Content-Package to Feature Model Converter 1.3.4)

[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header

2023-05-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722210#comment-17722210 ] Carsten Ziegeler commented on SLING-11871: -- I might be misreading the code in the filter, but

[jira] [Comment Edited] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header

2023-05-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722210#comment-17722210 ] Carsten Ziegeler edited comment on SLING-11871 at 5/12/23 3:28 PM: --- I

RE: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-12 Thread Stefan Seifert
robert detected a bigger number of builds failing with those new defaults (~90) - but after looking on the list of failures it seems to me that most of them affect modules not touched for some years, and likely on completely outdated sling-parent pom. only a few current ones have issues with

Re: SLING-11865 - Conversion fails when initial content document does not include namespace declaration

2023-05-12 Thread Julian Reschke
On 12.05.2023 15:48, Robert Munteanu wrote: On Mon, 2023-05-08 at 18:27 +0200, Konrad Windszus wrote: Another option would probably be to pass parameters to cp2fm for declaring additional namespaces. Then downstream consumers could declare additional ones like “cq” and those would have known

Re: SLING-11865 - Conversion fails when initial content document does not include namespace declaration

2023-05-12 Thread Robert Munteanu
On Mon, 2023-05-08 at 18:27 +0200, Konrad Windszus wrote: > Another option would probably be to pass parameters to cp2fm for > declaring additional namespaces. > Then downstream consumers could declare additional ones like “cq” and > those would have known URLs then which would be taken into

Re: [VOTE] Release Apache Sling API 2.27.2

2023-05-12 Thread Daniel Klco
+1 On Fri, May 12, 2023 at 6:14 AM Robert Munteanu wrote: > > On Fri, 2023-05-12 at 09:41 +0300, Jörg Hoh wrote: > > Please vote to approve this release: > > +1 > Robert

[jira] [Updated] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11843: Summary: Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows (was:

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722153#comment-17722153 ] Konrad Windszus commented on SLING-11843: - I raised this on the mailing list in

Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-12 Thread Konrad Windszus
Hi, Currently we still build by default all our modules with Java 8 on Linux only [1]. In SLING-11843 I proposed to change the default to Java 11 and 17 with Linux and Windows. The default build (i.e. the one which deploys the Snapshot) would be Java 11 on Linux. As there were some concerns

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722143#comment-17722143 ] Robert Munteanu commented on SLING-11843: - Sounds good to me. [~kwin], do you want to start the

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722140#comment-17722140 ] Stefan Seifert commented on SLING-11843: according to the log the build failed for *

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722132#comment-17722132 ] Robert Munteanu commented on SLING-11843: - [~sseifert] - I created a reactor pom, for

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722130#comment-17722130 ] Stefan Seifert commented on SLING-11843: yes, of course, let's start a discussion on the mailing

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #814 is BROKEN

2023-05-12 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/814/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 10254 lines...] [INFO] Running

[jira] [Comment Edited] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-05-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717502#comment-17717502 ] Robert Munteanu edited comment on SLING-11843 at 5/12/23 11:16 AM: ---

[GitHub] [sling-org-apache-sling-installer-factory-configuration] sonarcloud[bot] commented on pull request #10: SLING-11864 Move web console plugin

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/10#issuecomment-1545548018 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Commented] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722111#comment-17722111 ] Konrad Windszus commented on SLING-11864: - The new UI looks like this: !Screenshot 2023-05-12

[jira] [Updated] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11864: Attachment: Screenshot 2023-05-12 at 12.42.14.png > Configuration merge/default values

[GitHub] [sling-org-apache-sling-installer-factory-configuration] sonarcloud[bot] commented on pull request #10: SLING-11864 Move web console plugin

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/10#issuecomment-1545544337 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] sonarcloud[bot] commented on pull request #8: SLING-11873 sling-mock-oak: Improve oak-jcr dependency exclusions

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/8#issuecomment-1545531669 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Created] (SLING-11873) sling-mock-oak: Improve oak-jcr dependency exclusions

2023-05-12 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-11873: -- Summary: sling-mock-oak: Improve oak-jcr dependency exclusions Key: SLING-11873 URL: https://issues.apache.org/jira/browse/SLING-11873 Project: Sling

Re: [VOTE] Release Apache Sling API 2.27.2

2023-05-12 Thread Robert Munteanu
On Fri, 2023-05-12 at 09:41 +0300, Jörg Hoh wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: Starter ITs failing when updating to the latest Apache Felix HTTP 4.x

2023-05-12 Thread Robert Munteanu
Thanks for the context, Carsten. I've filed https://issues.apache.org/jira/browse/SLING-11872 so that the information is located in a single place, whenever someone has the time to look into it. I was hoping this would be more of a quick fix, but it looks like it needs a bit more attention.

[jira] [Updated] (SLING-11872) Some request attributes not set when running with Felix Jetty 4.2.x

2023-05-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11872: Description: When updating the Sling Starter

[jira] [Created] (SLING-11872) Some request attributes not set when running with Felix Jetty 4.2.x

2023-05-12 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-11872: --- Summary: Some request attributes not set when running with Felix Jetty 4.2.x Key: SLING-11872 URL: https://issues.apache.org/jira/browse/SLING-11872 Project:

[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #142: chore(deps): update apache felix http

2023-05-12 Thread via GitHub
rombert commented on PR #142: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/142#issuecomment-1545509744 This is blocked on SLING-11872 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

RE: [VOTE] Release Apache Sling API 2.27.2

2023-05-12 Thread Stefan Seifert
+1 stefan

[jira] [Commented] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722092#comment-17722092 ] Carsten Ziegeler commented on SLING-11864: -- I think that makes sense to also exclude them >

Re: Starter ITs failing when updating to the latest Apache Felix HTTP 4.x

2023-05-12 Thread Carsten Ziegeler
I think the solution here is to do the same in Sling Engine as Apache Felix is doing: instead of setting the attributes on the request, overwriting the getAttribute method. This avoids leakage of information as well. Regards Carsten On 04.05.2023 12:45, Carsten Ziegeler wrote: My best guess

[jira] [Commented] (SLING-11867) Empty mapping from ResourceMapper breaks authentication requirement updates

2023-05-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722071#comment-17722071 ] Carsten Ziegeler commented on SLING-11867: -- There are two options to fix this issue, one is to

[jira] [Commented] (SLING-11864) Configuration merge/default values not considered in OSGi Installer Configuration Printer Web Console

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722052#comment-17722052 ] Konrad Windszus commented on SLING-11864: - [~cziegeler] Should we also optionally filter

[GitHub] [sling-org-apache-sling-installer-console] sonarcloud[bot] commented on pull request #4: SLING-11864 Remove config serializer console

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-installer-console/pull/4#issuecomment-1545298693 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin commented on pull request #8: SLING-11866 add failing test case to show that not all default

2023-05-12 Thread via GitHub
kwin commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8#issuecomment-1545290389 Clarified meanwhile in https://issues.apache.org/jira/browse/SLING-10771. -- This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (SLING-11866) WebconsoleConfigurationHandler does not filter out default values coming from ConfigTaskCreator.getDefaultProperties

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11866. - Resolution: Invalid As clarified in SLING-10771 the merged configurations are

[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin closed pull request #8: SLING-11866 add failing test case to show that not all default

2023-05-12 Thread via GitHub
kwin closed pull request #8: SLING-11866 add failing test case to show that not all default URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #22: SLING-11870 Use org.apache.jackrabbit:oak-jcr as only oak dependency

2023-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/22#issuecomment-1545288312 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722040#comment-17722040 ] Carsten Ziegeler commented on SLING-10771: -- there is no right or wrong here. component property

[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert opened a new pull request, #22: SLING-11870 Use org.apache.jackrabbit:oak-jcr as only oak dependency

2023-05-12 Thread via GitHub
stefanseifert opened a new pull request, #22: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/22 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721045#comment-17721045 ] Konrad Windszus edited comment on SLING-10771 at 5/12/23 7:08 AM: -- bq.

[jira] [Comment Edited] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721045#comment-17721045 ] Konrad Windszus edited comment on SLING-10771 at 5/12/23 7:07 AM: -- bq.

[jira] [Comment Edited] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721045#comment-17721045 ] Konrad Windszus edited comment on SLING-10771 at 5/12/23 7:05 AM: -- bq.

[jira] [Comment Edited] (SLING-10771) Support handling of metatype info when merging configurations

2023-05-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721045#comment-17721045 ] Konrad Windszus edited comment on SLING-10771 at 5/12/23 7:02 AM: -- bq.

[jira] [Resolved] (SLING-11868) jcr-mock: MockAuthorizable must not use java.nio.file.Paths

2023-05-12 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11868. Resolution: Fixed

Re: [VOTE] Release Apache Sling API 2.27.2

2023-05-12 Thread Jörg Hoh
+1 Am Fr., 12. Mai 2023 um 09:41 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12352229 > > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2746/ > > You can use this UNIX

[VOTE] Release Apache Sling API 2.27.2

2023-05-12 Thread Jörg Hoh
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/projects/SLING/versions/12352229 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2746/ You can use this UNIX script to download the release and verify the