Re: [VOTE] Release Apache Sling Commons Permissions 1.0.0

2023-06-02 Thread Oliver Lietz
On Saturday, 11 March 2023 18:56:36 CEST Daniel Klco wrote: > Beyond the name, I am struggling to understand the value of this module. It > seems like a lot of extra effort and artifacts to have two additional > modules to perform what is essentially a Resource permissions check. > Especially

[GitHub] [sling-org-apache-sling-servlets-get] enapps-enorman commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-02 Thread via GitHub
enapps-enorman commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1574012608 > So the idea was to fetch all the content in one go. @YegorKozlov How would you feel about something like an ".infinity.json.zip" selector that

[jira] [Closed] (SLING-11890) Fix embed of org.apache.sling.scripting.core.impl.helper.ProtectedBindings

2023-06-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11890. -- > Fix embed of org.apache.sling.scripting.core.impl.helper.ProtectedBindings >

[RESULT] [VOTE] Release Apache Sling Models Implementation 1.6.4

2023-06-02 Thread Stefan Seifert
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Robert Munteanu, Daniel Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan

Re: [VOTE] Release Apache Sling Models Implementation 1.6.4

2023-06-02 Thread Daniel Klco
+1 On Fri, Jun 2, 2023 at 9:13 AM Stefan Seifert wrote: > one binding vote is missing... > > stefan > > > -Original Message- > > From: Stefan Seifert > > Sent: Tuesday, May 30, 2023 11:02 AM > > To: dev@sling.apache.org > > Subject: [VOTE] Release Apache Sling Models Implementation

Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.0

2023-06-02 Thread Daniel Klco
+1 On Fri, Jun 2, 2023 at 4:42 AM Jörg Hoh wrote: > +1 > > Am Do., 1. Juni 2023 um 11:59 Uhr schrieb Robert Munteanu < > romb...@apache.org>: > > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12352328 > > > > Staging repository:

RE: [VOTE] Release Apache Sling Models Implementation 1.6.4

2023-06-02 Thread Stefan Seifert
one binding vote is missing... stefan > -Original Message- > From: Stefan Seifert > Sent: Tuesday, May 30, 2023 11:02 AM > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Models Implementation 1.6.4 > > Hi, > > We solved 1 issues in this release: >

[jira] [Resolved] (SLING-11899) Run CI checks only for the master branch and PRs

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11899. - Resolution: Fixed > Run CI checks only for the master branch and PRs >

[jira] [Commented] (SLING-11899) Run CI checks only for the master branch and PRs

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728717#comment-17728717 ] Robert Munteanu commented on SLING-11899: - Configuration applied at

[jira] [Updated] (SLING-11899) Run CI checks only for the master branch and PRs

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11899: Attachment: applied-config.png > Run CI checks only for the master branch and PRs >

[jira] [Created] (SLING-11899) Run CI checks only for the master branch and PRs

2023-06-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-11899: --- Summary: Run CI checks only for the master branch and PRs Key: SLING-11899 URL: https://issues.apache.org/jira/browse/SLING-11899 Project: Sling Issue

Re: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-06-02 Thread Robert Munteanu
Hi, On Fri, 2023-05-12 at 14:24 +0200, Konrad Windszus wrote: > All other failing modules either need to be fixes accordingly or > deprecated. I created a wiki page [1] which tracks failures that are often seen when updating to a new Java version. Feel free to use it as a reference for known

[jira] [Resolved] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11897. - Resolution: Fixed > Default Get Servlet tests fail on Java 17 >

[GitHub] [sling-org-apache-sling-servlets-get] rombert merged pull request #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
rombert merged PR #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-servlets-get] rombert commented on pull request #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
rombert commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12#issuecomment-1573583261 > > tested it locally with java 17 on windows and got a build failure: > > ``` > > [ERROR] Failed to execute goal

[GitHub] [sling-org-apache-sling-servlets-get] rombert commented on pull request #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
rombert commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12#issuecomment-1573577704 > tested it locally with java 17 on windows and got a build failure: > > ``` > [ERROR] Failed to execute goal

[GitHub] [sling-org-apache-sling-servlets-get] stefanseifert commented on pull request #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
stefanseifert commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12#issuecomment-1573572822 tested it locally with java 17 on windows and got a build failure: {noformat} [ERROR] Failed to execute goal

[GitHub] [sling-org-apache-sling-servlets-get] rombert commented on pull request #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
rombert commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12#issuecomment-1573454403 CI failure is unrelated, but did not go away after a retry ``` ERROR: Issue with creating launcher for agent builds35. The agent is being disconnected

[jira] [Commented] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728649#comment-17728649 ] Robert Munteanu commented on SLING-11897: - I've attempted a fix at

[GitHub] [sling-org-apache-sling-servlets-get] YegorKozlov commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-02 Thread via GitHub
YegorKozlov commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1573452163 > What about changing the approach and you provide a link to the binary as part of the JSON instead of dumping its content within the JSON?

[GitHub] [sling-org-apache-sling-servlets-get] rombert opened a new pull request, #12: SLING-11897 - Default Get Servlet tests fail on Java 17

2023-06-02 Thread via GitHub
rombert opened a new pull request, #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/12 - update to a more recent version of sling-mock-oak - ensure that it is on the classpath before sling-mock.junit4, so that the Oak dependency is not overridden -- This is

[jira] [Assigned] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11897: --- Assignee: Robert Munteanu > Default Get Servlet tests fail on Java 17 >

Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.0

2023-06-02 Thread Jörg Hoh
+1 Am Do., 1. Juni 2023 um 11:59 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352328 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2755/

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-06-02 Thread via GitHub
cziegeler commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1214092907 ## src/main/java/org/apache/sling/resourceresolver/impl/VanityPathConfigurer.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-06-02 Thread via GitHub
cziegeler commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1214089833 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java: ## @@ -163,15 +163,27 @@

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-06-02 Thread via GitHub
cziegeler commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1214089318 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java: ## @@ -163,15 +163,27 @@

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #89: [SLING-11742] Provide alternative equitable terminology for properties

2023-06-02 Thread via GitHub
cziegeler commented on code in PR #89: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1214088620 ## src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java: ## @@ -163,15 +163,27 @@

[GitHub] [sling-org-apache-sling-servlets-get] joerghoh commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-02 Thread via GitHub
joerghoh commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1573328544 @YegorKozlov when you work with such a ``max_bytes_to_export`` setting, the operations in GET and POST are most likely not symmetric anymore; and if I

[jira] [Updated] (SLING-11113) resource resolver: bloom filter might be out of sync on startup

2023-06-02 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated SLING-3: --- Description: It appears that the bloom filter can be out of sync with the repo on startup.

[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable

2023-06-02 Thread via GitHub
krystiannowak commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805 ## src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java: ## @@ -71,16 +69,26 @@ public class RequestLogger { })

[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable

2023-06-02 Thread via GitHub
krystiannowak commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805 ## src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java: ## @@ -71,16 +69,26 @@ public class RequestLogger { })

[GitHub] [sling-org-apache-sling-engine] krystiannowak commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable

2023-06-02 Thread via GitHub
krystiannowak commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1214017805 ## src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java: ## @@ -71,16 +69,26 @@ public class RequestLogger { })

[GitHub] [sling-org-apache-sling-engine] kwin commented on a diff in pull request #36: SLING-11898 : Make patterns for access and request log configurable

2023-06-02 Thread via GitHub
kwin commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36#discussion_r1213968900 ## src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java: ## @@ -71,16 +69,26 @@ public class RequestLogger { }) int