Re: [PR] Adding fix for SLING-8974 [sling-org-apache-sling-servlets-post]

2023-11-23 Thread via GitHub
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26#issuecomment-1825122904 SonarCloud Quality Gate failed. [![Quality Gate

[PR] Adding fix for SLING-8974 [sling-org-apache-sling-servlets-post]

2023-11-23 Thread via GitHub
pat-lego opened a new pull request, #26: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26 Added unit test to validate NonExistingResource and Post Servlet Returns a 400 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Adding fix for SLING POST DELETE return 404 instead of 200 for non existent resource SLING-8974 [sling-org-apache-sling-servlets-post]

2023-11-23 Thread via GitHub
pat-lego closed pull request #25: Adding fix for SLING POST DELETE return 404 instead of 200 for non existent resource SLING-8974 URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/25 -- This is an automated message from the Apache Git Service. To respond to the

[PR] Adding fix for SLING POST DELETE return 404 instead of 200 for non existent resource SLING-8974 [sling-org-apache-sling-servlets-post]

2023-11-23 Thread via GitHub
pat-lego opened a new pull request, #25: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/25 Added unit test using Java reflection to test Operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SLING-5884) Deprecate JobManager methods which allow to manage the queue

2023-11-23 Thread Patrique Legault (Jira)
[ https://issues.apache.org/jira/browse/SLING-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789277#comment-17789277 ] Patrique Legault commented on SLING-5884: - Since Sling Jobs are used in various parts of the

Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]

2023-11-23 Thread via GitHub
henrykuijpers commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1403735663 ## src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java: ## @@ -16,27 +16,37 @@ * specific language governing

[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789221#comment-17789221 ] Konrad Windszus commented on SLING-12026: - In

Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]

2023-11-23 Thread via GitHub
kwin commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1403620085 ## src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java: ## @@ -16,27 +16,37 @@ * specific language governing permissions and

Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]

2023-11-23 Thread via GitHub
kwin commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1403619774 ## src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java: ## @@ -16,27 +16,37 @@ * specific language governing permissions and

[jira] [Resolved] (SLING-9173) Add KEYS file to https://dist.apache.org/repos/dist/release/sling

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9173. Resolution: Fixed > Add KEYS file to https://dist.apache.org/repos/dist/release/sling >

[jira] [Commented] (SLING-9173) Add KEYS file to https://dist.apache.org/repos/dist/release/sling

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789220#comment-17789220 ] Konrad Windszus commented on SLING-9173: Original issue is fixed, verification of signatures is

Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]

2023-11-23 Thread via GitHub
henrykuijpers commented on code in PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1403618842 ## src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java: ## @@ -16,27 +16,37 @@ * specific language governing

[jira] [Assigned] (SLING-10398) Embed classes with Bnd only

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10398: --- Assignee: (was: Konrad Windszus) > Embed classes with Bnd only >

Re: [PR] SLING-12076 Export JcrResourceChange with additional method [sling-org-apache-sling-jcr-resource]

2023-11-23 Thread via GitHub
kwin commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#issuecomment-1824741078 @cziegeler Any concerns with this, otherwise I will merge beginning of next week. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (SLING-12056) Add Java 21 as additional default build JDK

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12056. - Resolution: Fixed Fixed in

Re: [PR] SLING-12056 build by default with JDK21 as well [sling-tooling-jenkins]

2023-11-23 Thread via GitHub
kwin merged PR #20: URL: https://github.com/apache/sling-tooling-jenkins/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (SLING-11067) Extend URIProvider to not rely on exceptions if URIs can not be provided for a resource

2023-11-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11067. - Resolution: Won't Fix Ok, I closed the PR and this ticket. I don't have any numbers

Re: [PR] SLING-11067 extend URIProvider by method returning Optional [sling-org-apache-sling-api]

2023-11-23 Thread via GitHub
kwin commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-api/pull/40#issuecomment-1824736379 As we couldn't reach consensus that we should break all providers and without that version increase consumers could not depend on the new API. Therefore closing this for

Re: [PR] SLING-11067 extend URIProvider by method returning Optional [sling-org-apache-sling-api]

2023-11-23 Thread via GitHub
kwin closed pull request #40: SLING-11067 extend URIProvider by method returning Optional URL: https://github.com/apache/sling-org-apache-sling-api/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] chore(deps): update dependency org.apache.commons:commons-lang3 to v3.14.0 [sling-org-apache-sling-starter]

2023-11-23 Thread via GitHub
rombert merged PR #282: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(deps): update dependency org.apache.commons:commons-lang3 to v3.14.0 [sling-org-apache-sling-starter]

2023-11-23 Thread via GitHub
renovate-bot opened a new pull request, #282: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/282 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]

2023-11-23 Thread via GitHub
sonarcloud[bot] commented on PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#issuecomment-1824582472 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]

2023-11-23 Thread via GitHub
sonarcloud[bot] commented on PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#issuecomment-1824573689 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]

2023-11-23 Thread via GitHub
kwin commented on PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#issuecomment-1824555606 > Regarding the "easier to understand" part, I believe that the current implementation, as well as yours, suffer from an underspecification of the ordering of

Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]

2023-11-23 Thread via GitHub
kwin commented on code in PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#discussion_r1403263503 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1243,24 +1236,20 @@ private boolean loadAlias(final

Re: [PR] SLING-12160 Prevent ConcurrentModificationException in [sling-org-apache-sling-resourceresolver]

2023-11-23 Thread via GitHub
jsedding commented on code in PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#discussion_r1403193013 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1243,24 +1236,20 @@ private boolean