[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048668#comment-14048668 ] Antonio Sanso commented on SLING-3505: -- [~cziegeler] which NPE ? I fyou mean

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044794#comment-14044794 ] Andrei Dulvac commented on SLING-3505: -- OK, I debugged this and there is a null

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043456#comment-14043456 ] Antonio Sanso commented on SLING-3505: -- [~justinedelson] thx a lot so far!! Improve

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042018#comment-14042018 ] Justin Edelson commented on SLING-3505: --- [~asanso] your patch doesn't apply cleanly

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042149#comment-14042149 ] Justin Edelson commented on SLING-3505: --- [~asanso] This looks like it should work,

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042186#comment-14042186 ] Justin Edelson commented on SLING-3505: --- Actually, I take it back. Seeing a NPE

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042213#comment-14042213 ] Antonio Sanso commented on SLING-3505: -- bq. Why is there a TODO on line 498 of

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040465#comment-14040465 ] Antonio Sanso commented on SLING-3505: -- thanks a lot [~justinedelson] for reviewing

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040506#comment-14040506 ] Antonio Sanso commented on SLING-3505: -- [~justinedelson] an area were I would

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040734#comment-14040734 ] Antonio Sanso commented on SLING-3505: -- I have spotted a little issue with my

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036003#comment-14036003 ] Justin Edelson commented on SLING-3505: --- I did find one issue with the patch -

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036029#comment-14036029 ] Justin Edelson commented on SLING-3505: --- I reviewed the patch (obviously based on my

[jira] [Commented] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)

[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026515#comment-14026515 ] Antonio Sanso commented on SLING-3505: -- Little extra comment : I will add some unit