[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069500#comment-15069500
]
ASF GitHub Bot commented on SLING-4212:
---
Github user santiagozky closed the pull request at:
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290662#comment-14290662
]
santiago garcía pimentel commented on SLING-4212:
-
great. thank you
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289967#comment-14289967
]
santiago garcía pimentel commented on SLING-4212:
-
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289232#comment-14289232
]
santiago garcía pimentel commented on SLING-4212:
-
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288488#comment-14288488
]
Stefan Seifert commented on SLING-4212:
---
a simple solution would be: always try to
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282502#comment-14282502
]
santiago garcía pimentel commented on SLING-4212:
-
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246879#comment-14246879
]
Stefan Seifert commented on SLING-4212:
---
i my view this would be most consistent:
#
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242542#comment-14242542
]
santiago garcía pimentel commented on SLING-4212:
-
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239294#comment-14239294
]
Stefan Seifert commented on SLING-4212:
---
the API changes look or for me.
some notes
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237825#comment-14237825
]
santiago garcía pimentel commented on SLING-4212:
-
while changing this I
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237836#comment-14237836
]
santiago garcía pimentel commented on SLING-4212:
-
[~kwin],
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237844#comment-14237844
]
Konrad Windszus commented on SLING-4212:
[~santiagozky]
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235286#comment-14235286
]
Konrad Windszus commented on SLING-4212:
For me changing the annotations {{@Path}}
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235290#comment-14235290
]
Stefan Seifert commented on SLING-4212:
---
it has to be _binary_ backwards compatible,
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234789#comment-14234789
]
Stefan Seifert commented on SLING-4212:
---
the patch looks fine for me.
(two really
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232837#comment-14232837
]
santiago garcía pimentel commented on SLING-4212:
-
btw,
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232082#comment-14232082
]
Stefan Seifert commented on SLING-4212:
---
i had only a brief look at the patch - it
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229753#comment-14229753
]
ASF GitHub Bot commented on SLING-4212:
---
GitHub user santiagozky opened a pull
18 matches
Mail list logo