[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-12-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069500#comment-15069500 ] ASF GitHub Bot commented on SLING-4212: --- Github user santiagozky closed the pull request at:

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-01-24 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290662#comment-14290662 ] santiago garcía pimentel commented on SLING-4212: - great. thank you

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-01-23 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289967#comment-14289967 ] santiago garcía pimentel commented on SLING-4212: -

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-01-23 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289232#comment-14289232 ] santiago garcía pimentel commented on SLING-4212: -

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-01-22 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288488#comment-14288488 ] Stefan Seifert commented on SLING-4212: --- a simple solution would be: always try to

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2015-01-19 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282502#comment-14282502 ] santiago garcía pimentel commented on SLING-4212: -

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-15 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246879#comment-14246879 ] Stefan Seifert commented on SLING-4212: --- i my view this would be most consistent: #

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-11 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242542#comment-14242542 ] santiago garcía pimentel commented on SLING-4212: -

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-09 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239294#comment-14239294 ] Stefan Seifert commented on SLING-4212: --- the API changes look or for me. some notes

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-08 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237825#comment-14237825 ] santiago garcía pimentel commented on SLING-4212: - while changing this I

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-08 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237836#comment-14237836 ] santiago garcía pimentel commented on SLING-4212: - [~kwin],

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237844#comment-14237844 ] Konrad Windszus commented on SLING-4212: [~santiagozky]

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-05 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235286#comment-14235286 ] Konrad Windszus commented on SLING-4212: For me changing the annotations {{@Path}}

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-05 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235290#comment-14235290 ] Stefan Seifert commented on SLING-4212: --- it has to be _binary_ backwards compatible,

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-04 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234789#comment-14234789 ] Stefan Seifert commented on SLING-4212: --- the patch looks fine for me. (two really

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-03 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232837#comment-14232837 ] santiago garcía pimentel commented on SLING-4212: - btw,

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-02 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232082#comment-14232082 ] Stefan Seifert commented on SLING-4212: --- i had only a brief look at the patch - it

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229753#comment-14229753 ] ASF GitHub Bot commented on SLING-4212: --- GitHub user santiagozky opened a pull