See https://hudson.apache.org/hudson/job/sling-trunk-1.5/1174/changes
Changes:
[mduerig] typo
--
Started by an SCM change
Building remotely on ubuntu1
Updating http://svn.apache.org/repos/asf/sling/trunk
U
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/856/changes
Changes:
[mduerig] typo
--
Started by an SCM change
Building remotely on ubuntu1
Updating http://svn.apache.org/repos/asf/sling/trunk
U
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/679/changes
Changes:
[mduerig] typo
--
Started by an SCM change
Building remotely on ubuntu1
Updating http://svn.apache.org/repos/asf/sling/trunk/contrib
U
On Fri, Apr 1, 2011 at 12:42 AM, Eric Norman eric.d.nor...@gmail.com wrote:
Thanks for the review.
Maybe it is ok to just pass the ItemId to the AccessManagerPlugin2#canRead
method as a string?
That'd solve the export problem, but the question remains - what would
an implementor of
It's hard to predict what an implementor would do. The more I think about
it, maybe it would make more sense for us to just lookup the path for the
ItemId and not bother passing along the second argument. Then we wouldn't
need the AccessManagerPlugin2 interface at all.
Eric
On Fri, Apr 1, 2011
What I mean is that ItemId is an opaque object. The only thing you can
do with it *by itself* is to figure out whether or not the Id denotes
a Node. IIUC, to do anything useful, you need to use classes from
org.apache.jackrabbit.core.
However, I don't think this should block trunk from being
Right. That's the main reason why I was suggesting to expand the itemId back
to a path before passing it on to the AccessManagerPlugin implementation.
The item path is something the AccessManagerPlugin should know what to with.
Regards,
Eric
On Fri, Apr 1, 2011 at 8:36 AM, Justin Edelson
[
https://issues.apache.org/jira/browse/SLING-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-2044:
---
Fix Version/s: (was: Extensions Event 3.1.0)
(was: JCR ContentLoader
I added an updated patch set @ http://codereview.appspot.com/4345041/
It seems to work locally. Do you see anything wrong with that or see
anything that I missed?
http://codereview.appspot.com/4345041/Regards,
Eric
On Fri, Apr 1, 2011 at 12:54 PM, Eric Norman eric.d.nor...@gmail.comwrote:
