Re: [VOTE] Apache Sling Servlet Post 2.3.20

[Antonio Sanso]

+1
On May 23, 2017, at 3:05 PM, Karl Pauls  wrote:

> I would like to call a vote on the following release,
> 
> Apache Sling Servlet Post 2.3.20
> 
> We solved 1 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12340584
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1727/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1727 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

[jira] [Resolved] (SLING-6877) FSResource: Allow to adapt to Node from FileResource

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6877.
---
Resolution: Fixed

Completed: At revision: 1795980  (2.x)
Completed: At revision: 1795979  (1.x)

> FSResource: Allow to adapt to Node from FileResource
> 
>
> Key: SLING-6877
> URL: https://issues.apache.org/jira/browse/SLING-6877
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: File System Resource Provider 1.4.0, File System 
> Resource Provider 2.1.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: File System Resource Provider 1.4.2, File System 
> Resource Provider 2.1.2
>
>
> since SLING-6829 FileResource has precedence over FileContentResource. for 
> files and folders with node descriptor files adapting to a JCR node should 
> still be supported.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6877) FSResource: Allow to adapt to Node from FileResource

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6877:
-

 Summary: FSResource: Allow to adapt to Node from FileResource
 Key: SLING-6877
 URL: https://issues.apache.org/jira/browse/SLING-6877
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: File System Resource Provider 2.1.0, File System Resource 
Provider 1.4.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: File System Resource Provider 1.4.2, File System Resource 
Provider 2.1.2


since SLING-6829 FileResource has precedence over FileContentResource. for 
files and folders with node descriptor files adapting to a JCR node should 
still be supported.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6876) Improve tick handling by using the JsonTicksConverter from JCR Content Parser

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-6876.
---
Resolution: Fixed

Done in r1795978.

> Improve tick handling by using the JsonTicksConverter from JCR Content Parser
> -
>
> Key: SLING-6876
> URL: https://issues.apache.org/jira/browse/SLING-6876
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.4
>
>
> We should inline the JsonTicksConverter from the JCR Content Parser and use 
> it instead of the solution in SLING-6871 as it is even more permissive.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Sling JCR Contentloader 2.2.2

[Karl Pauls]

Good - lets get this release out and address it in the next one (I
created SLING-6876 to track this so we don't forget to include it).

regards,

Karl

On Wed, May 24, 2017 at 12:01 AM, Stefan Seifert  wrote:
> i peronally would rather include this fix as well, becaue without it 
> tick-escaped json creates strange results when the quoted string itself 
> contains ticks or quotes. either a "full" support for ticks or none at all.
>
> but i'm also fine with keeping this release and adding the fix to the next 
> one if no other objects.
>
> +1 on the formal release of 2.2.2
>
> stefan
>
>>-Original Message-
>>From: Karl Pauls [mailto:karlpa...@gmail.com]
>>Sent: Tuesday, May 23, 2017 11:50 PM
>>To: dev@sling.apache.org
>>Subject: Re: [VOTE] Apache Sling JCR Contentloader 2.2.2
>>
>>Hi Stefan,
>>
>>yeah, as I just replied to your comment as well, that is certainly a
>>nice improvement to support even more none standard json but I think
>>we can address this in a later release (either we wait until
>>SLING-6634 is done or we do an in between release where we inline your
>>JsonTicksConverter). From my POV this is a best effort kinda thing and
>>preferably people should use valid json to begin with.
>>
>>regards,
>>
>>Karl
>>
>>On Tue, May 23, 2017 at 11:10 PM, Stefan Seifert 
>>wrote:
>>> i think the logic for supporting tick-quoted json is incomplete, see
>>> https://issues.apache.org/jira/browse/SLING-
>>6871?focusedCommentId=16021869#comment-16021869
>>>
>>> stefan
>>>
-Original Message-
From: Karl Pauls [mailto:karlpa...@gmail.com]
Sent: Tuesday, May 23, 2017 5:42 PM
To: dev@sling.apache.org
Subject: [VOTE] Apache Sling JCR Contentloader 2.2.2

I would like to call a vote on the following release,

Apache Sling JCR Contentloader 2.2.2

We solved 1 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340508

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1728/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1728 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...
>>>
>>
>>
>>
>>--
>>Karl Pauls
>>karlpa...@gmail.com
>



-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Updated] (SLING-6876) Improve tick handling by using the JsonTicksConverter from JCR Content Parser

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-6876:
--
Description: We should inline the JsonTicksConverter from the JCR Content 
Parser and use it instead of the solution in SLING-6871 as it is even more 
permissive.

> Improve tick handling by using the JsonTicksConverter from JCR Content Parser
> -
>
> Key: SLING-6876
> URL: https://issues.apache.org/jira/browse/SLING-6876
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.4
>
>
> We should inline the JsonTicksConverter from the JCR Content Parser and use 
> it instead of the solution in SLING-6871 as it is even more permissive.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6876) Improve tick handling by using the JsonTicksConverter from JCR Content Parser

[Karl Pauls (JIRA)]

Karl Pauls created SLING-6876:
-

 Summary: Improve tick handling by using the JsonTicksConverter 
from JCR Content Parser
 Key: SLING-6876
 URL: https://issues.apache.org/jira/browse/SLING-6876
 Project: Sling
  Issue Type: Bug
  Components: JCR
Affects Versions: JCR ContentLoader 2.2.2
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: JCR ContentLoader 2.2.4






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Apache Sling Servlet Post 2.3.20

[Stefan Seifert]

+1

[jira] [Comment Edited] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021950#comment-16021950
 ] 

Stefan Seifert edited comment on SLING-6871 at 5/23/17 10:02 PM:
-

inlining the class is a good idea.
discussion about the 2.2.2 release on the dev list.


was (Author: sseif...@pro-vision.de):
embedding is a good idea.
discussion about the 2.2.2 release on the dev list.

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021950#comment-16021950
 ] 

Stefan Seifert commented on SLING-6871:
---

embedding is a good idea.
discussion about the 2.2.2 release on the dev list.

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Apache Sling JCR Contentloader 2.2.2

[Stefan Seifert]

i peronally would rather include this fix as well, becaue without it 
tick-escaped json creates strange results when the quoted string itself 
contains ticks or quotes. either a "full" support for ticks or none at all.

but i'm also fine with keeping this release and adding the fix to the next one 
if no other objects.

+1 on the formal release of 2.2.2

stefan

>-Original Message-
>From: Karl Pauls [mailto:karlpa...@gmail.com]
>Sent: Tuesday, May 23, 2017 11:50 PM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Apache Sling JCR Contentloader 2.2.2
>
>Hi Stefan,
>
>yeah, as I just replied to your comment as well, that is certainly a
>nice improvement to support even more none standard json but I think
>we can address this in a later release (either we wait until
>SLING-6634 is done or we do an in between release where we inline your
>JsonTicksConverter). From my POV this is a best effort kinda thing and
>preferably people should use valid json to begin with.
>
>regards,
>
>Karl
>
>On Tue, May 23, 2017 at 11:10 PM, Stefan Seifert 
>wrote:
>> i think the logic for supporting tick-quoted json is incomplete, see
>> https://issues.apache.org/jira/browse/SLING-
>6871?focusedCommentId=16021869#comment-16021869
>>
>> stefan
>>
>>>-Original Message-
>>>From: Karl Pauls [mailto:karlpa...@gmail.com]
>>>Sent: Tuesday, May 23, 2017 5:42 PM
>>>To: dev@sling.apache.org
>>>Subject: [VOTE] Apache Sling JCR Contentloader 2.2.2
>>>
>>>I would like to call a vote on the following release,
>>>
>>>Apache Sling JCR Contentloader 2.2.2
>>>
>>>We solved 1 issues in this release:
>>>https://issues.apache.org/jira/browse/SLING/fixforversion/12340508
>>>
>>>Staging repository:
>>>https://repository.apache.org/content/repositories/orgapachesling-1728/
>>>
>>>You can use this UNIX script to download the release and verify the
>>>signatures:
>>>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>>>
>>>Usage:
>>>sh check_staged_release.sh 1728 /tmp/sling-staging
>>>
>>>Please vote to approve this release:
>>>
>>>  [ ] +1 Approve the release
>>>  [ ]  0 Don't care
>>>  [ ] -1 Don't release, because ...
>>
>
>
>
>--
>Karl Pauls
>karlpa...@gmail.com

[jira] [Resolved] (SLING-6875) maven-sling-plugin: Support tick as well as double quote when validating JSON files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6875.
---
Resolution: Fixed

Completed: At revision: 1795976  


> maven-sling-plugin: Support tick as well as double quote when validating JSON 
> files
> ---
>
> Key: SLING-6875
> URL: https://issues.apache.org/jira/browse/SLING-6875
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Maven Sling Plugin 2.2.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Maven Sling Plugin 2.2.2
>
>
> apply SLING-6872 to validation goal in maven-sling-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Sling JCR Contentloader 2.2.2

[Karl Pauls]

Hi Stefan,

yeah, as I just replied to your comment as well, that is certainly a
nice improvement to support even more none standard json but I think
we can address this in a later release (either we wait until
SLING-6634 is done or we do an in between release where we inline your
JsonTicksConverter). From my POV this is a best effort kinda thing and
preferably people should use valid json to begin with.

regards,

Karl

On Tue, May 23, 2017 at 11:10 PM, Stefan Seifert  wrote:
> i think the logic for supporting tick-quoted json is incomplete, see
> https://issues.apache.org/jira/browse/SLING-6871?focusedCommentId=16021869#comment-16021869
>
> stefan
>
>>-Original Message-
>>From: Karl Pauls [mailto:karlpa...@gmail.com]
>>Sent: Tuesday, May 23, 2017 5:42 PM
>>To: dev@sling.apache.org
>>Subject: [VOTE] Apache Sling JCR Contentloader 2.2.2
>>
>>I would like to call a vote on the following release,
>>
>>Apache Sling JCR Contentloader 2.2.2
>>
>>We solved 1 issues in this release:
>>https://issues.apache.org/jira/browse/SLING/fixforversion/12340508
>>
>>Staging repository:
>>https://repository.apache.org/content/repositories/orgapachesling-1728/
>>
>>You can use this UNIX script to download the release and verify the
>>signatures:
>>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>>
>>Usage:
>>sh check_staged_release.sh 1728 /tmp/sling-staging
>>
>>Please vote to approve this release:
>>
>>  [ ] +1 Approve the release
>>  [ ]  0 Don't care
>>  [ ] -1 Don't release, because ...
>



-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Commented] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021922#comment-16021922
 ] 

Karl Pauls commented on SLING-6871:
---

Nice. Certainly would be another improvement in our quest to support even more 
none standard json :-). 

I guess if we think it is important we could just inline the JsonTicksConverter 
and use it until SLING-6634 is done. However, I personally don't think it is 
that urgent - wdyt?

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6874) sling-mock: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6874.
---
Resolution: Fixed

Completed: At revision: 1795969  (2.x)
Completed: At revision: 1795968  (1.x)

> sling-mock: Support tick as well as double quote when parsing JSON files
> 
>
> Key: SLING-6874
> URL: https://issues.apache.org/jira/browse/SLING-6874
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock 1.9.8, Testing Sling Mock 2.2.10
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>  Labels: mocks
> Fix For: Testing Sling Mock 2.2.12, Testing Sling Mock 1.9.10
>
>
> apply SLING-6872 to sling mocks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6873) FSResource: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6873.
---
Resolution: Fixed

Completed: At revision: 1795966  (2.x)
Completed: At revision: 1795965  (1.x)


> FSResource: Support tick as well as double quote when parsing JSON files
> 
>
> Key: SLING-6873
> URL: https://issues.apache.org/jira/browse/SLING-6873
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: File System Resource Provider 1.4.0, File System 
> Resource Provider 2.1.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: File System Resource Provider 1.4.2, File System 
> Resource Provider 2.1.2
>
>
> apply SLING-6872 to file system resource provider.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6875) maven-sling-plugin: Support tick as well as double quote when validating JSON files

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6875:
-

 Summary: maven-sling-plugin: Support tick as well as double quote 
when validating JSON files
 Key: SLING-6875
 URL: https://issues.apache.org/jira/browse/SLING-6875
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Affects Versions: Maven Sling Plugin 2.2.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Maven Sling Plugin 2.2.2


apply SLING-6872 to validation goal in maven-sling-plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6874) sling-mock: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6874:
-

 Summary: sling-mock: Support tick as well as double quote when 
parsing JSON files
 Key: SLING-6874
 URL: https://issues.apache.org/jira/browse/SLING-6874
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Affects Versions: Testing Sling Mock 2.2.10, Testing Sling Mock 1.9.8
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Testing Sling Mock 2.2.12, Testing Sling Mock 1.9.10


apply SLING-6872 to sling mocks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6873) FSResource: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6873:
-

 Summary: FSResource: Support tick as well as double quote when 
parsing JSON files
 Key: SLING-6873
 URL: https://issues.apache.org/jira/browse/SLING-6873
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: File System Resource Provider 2.1.0, File System Resource 
Provider 1.4.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: File System Resource Provider 1.4.2, File System Resource 
Provider 2.1.2


apply SLING-6872 to file system resource provider.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Apache Sling JCR Contentloader 2.2.2

[Stefan Seifert]

i think the logic for supporting tick-quoted json is incomplete, see
https://issues.apache.org/jira/browse/SLING-6871?focusedCommentId=16021869#comment-16021869

stefan

>-Original Message-
>From: Karl Pauls [mailto:karlpa...@gmail.com]
>Sent: Tuesday, May 23, 2017 5:42 PM
>To: dev@sling.apache.org
>Subject: [VOTE] Apache Sling JCR Contentloader 2.2.2
>
>I would like to call a vote on the following release,
>
>Apache Sling JCR Contentloader 2.2.2
>
>We solved 1 issues in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340508
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1728/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1728 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

[jira] [Comment Edited] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021869#comment-16021869
 ] 

Stefan Seifert edited comment on SLING-6871 at 5/23/17 9:10 PM:


in my pov the implementation of the ticks conversion is incomplete. it's not 
possible to put ' or " in strings quoted in ticks.
in context of SLING-6872 i've refactored your code and added additional unit 
tests to cover this as well:
https://github.com/apache/sling/blob/trunk/bundles/jcr/contentparser/src/main/java/org/apache/sling/jcr/contentparser/impl/JsonTicksConverter.java

(in SLING-6634 it was planned to migrate JCR content loader to use JCR content 
parser as well, but this is a non-trivial task - even for JSON - and would 
required a good deal of refactoring in JCR content loader; so we cannot just do 
it here to reuse the logic directly)


was (Author: sseif...@pro-vision.de):
in my pov the implementation of the ticks conversion is incomplete. it's not 
possible to put ' or " in strings quoted in ticks.
in context of SLING-6872 i've refactored your code and added additional unit 
tests to cover this as well.

(in SLING-6634 it was planned to migrate JCR content loader to use JCR content 
parser as well, but this is a non-trivial task - even for JSON - and would 
required a good deal of refactoring in JCR content loader; so we cannot just do 
it here to reuse the logic directly)

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021869#comment-16021869
 ] 

Stefan Seifert commented on SLING-6871:
---

in my pov the implementation of the ticks conversion is incomplete. it's not 
possible to put ' or " in strings quoted in ticks.
in context of SLING-6872 i've refactored your code and added additional unit 
tests to cover this as well.

(in SLING-6634 it was planned to migrate JCR content loader to use JCR content 
parser as well, but this is a non-trivial task - even for JSON - and would 
required a good deal of refactoring in JCR content loader; so we cannot just do 
it here to reuse the logic directly)

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6872) JCR Content Parser: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6872.
---
Resolution: Fixed

Completed: At revision: 1795961  

the implementation of the tick support is improved against SLING-6871:
* with tick-quoted names/strings ' and " are supported.
* ' has to be escaped when tick-quoted, but the escape symbol is removed when 
converted to  double quotes
* double quotes in tick-quoted strings may or may not be escaped, they are 
always escaped in the output

i've added a new field to the ParserOptions, a enumset of JsonParserFeatures. 
the two options COMMENTS and QUOTE_TICK are activated by default, but can be 
switched off when needed.

> JCR Content Parser: Support tick as well as double quote when parsing JSON 
> files
> 
>
> Key: SLING-6872
> URL: https://issues.apache.org/jira/browse/SLING-6872
> Project: Sling
>  Issue Type: New Feature
>  Components: JCR
>Affects Versions: JCR Content Parser 1.1.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: JCR Content Parser 1.2.0
>
>
> currently the content parser supports JSON files only in "strict format", 
> plus the support for comments in JSON files.
> we should also support ticks for quoting names and string values, as in 
> SLING-6871 for the content loader.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6872) JCR Content Parser: Support tick as well as double quote when parsing JSON files

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6872:
-

 Summary: JCR Content Parser: Support tick as well as double quote 
when parsing JSON files
 Key: SLING-6872
 URL: https://issues.apache.org/jira/browse/SLING-6872
 Project: Sling
  Issue Type: New Feature
  Components: JCR
Affects Versions: JCR Content Parser 1.1.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: JCR Content Parser 1.2.0


currently the content parser supports JSON files only in "strict format", plus 
the support for comments in JSON files.
we should also support ticks for quoting names and string values, as in 
SLING-6871 for the content loader.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (SLING-6685) Replace commons.json usage in org.apache.sling.xss

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-6685.
-

> Replace commons.json usage in org.apache.sling.xss
> --
>
> Key: SLING-6685
> URL: https://issues.apache.org/jira/browse/SLING-6685
> Project: Sling
>  Issue Type: Sub-task
>  Components: XSS Protection API
>Affects Versions: XSS Protection API 1.0.18
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>  Labels: patch-available
> Fix For: XSS Protection API 2.0.0
>
> Attachments: SLING-6685-2.patch, SLING-6685.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Sling JCR Contentloader 2.2.2

[Stefan Egli]

+1

Cheers,
Stefan

On 23/05/17 17:41, "Karl Pauls"  wrote:

>I would like to call a vote on the following release,
>
>Apache Sling JCR Contentloader 2.2.2
>
>We solved 1 issues in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340508
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1728/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1728 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

Re: [VOTE] Apache Sling Servlet Post 2.3.20

[Stefan Egli]

+1

Cheers,
Stefan

On 23/05/17 15:05, "Karl Pauls"  wrote:

>I would like to call a vote on the following release,
>
>Apache Sling Servlet Post 2.3.20
>
>We solved 1 issues in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12340584
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1727/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1727 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

[VOTE] Apache Sling JCR Contentloader 2.2.2

[Karl Pauls]

I would like to call a vote on the following release,

Apache Sling JCR Contentloader 2.2.2

We solved 1 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340508

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1728/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1728 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

[jira] [Commented] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021311#comment-16021311
 ] 

Karl Pauls commented on SLING-6871:
---

[~sseif...@pro-vision.de], unfortunately, no there isn't. I'm not sure about 
the places you mention but I think allowing it in here is important because it 
is used by the post servlet. It just seems too likely that people will use 
ticks when they send stuff by hand (already had one case on the mailing list) - 
even our own documentation did make that mistake.

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021307#comment-16021307
 ] 

Stefan Seifert commented on SLING-6871:
---

then we need to change maven-sling-plugin (json validation) and fsresource 
(json mounting) as well.
using ticks is not standard-conformant (we already allowed comments which is 
not conformant as well).
is there built-in support for ticks in johnzon which we can enable? (for 
comments, there is)

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-6871.
---
Resolution: Fixed

I commited support for this in r1795918. Basically, all it does is to 
preprocess the input string and replace ticks with double quotes.

> JsonReader should allow tick as well as double quotes on import.
> 
>
> Key: SLING-6871
> URL: https://issues.apache.org/jira/browse/SLING-6871
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.2.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: JCR ContentLoader 2.2.2
>
>
> I think we have to relax the json parsing at least for the contentloader 
> import case. It's just to likely that people will use ticks instead of double 
> quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6871) JsonReader should allow tick as well as double quotes on import.

[Karl Pauls (JIRA)]

Karl Pauls created SLING-6871:
-

 Summary: JsonReader should allow tick as well as double quotes on 
import.
 Key: SLING-6871
 URL: https://issues.apache.org/jira/browse/SLING-6871
 Project: Sling
  Issue Type: Bug
  Components: JCR
Affects Versions: JCR ContentLoader 2.2.0
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: JCR ContentLoader 2.2.2


I think we have to relax the json parsing at least for the contentloader import 
case. It's just to likely that people will use ticks instead of double quotes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Sling Servlet Post 2.3.20

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Apache Sling Servlet Post 2.3.20

[Karl Pauls]

I would like to call a vote on the following release,

Apache Sling Servlet Post 2.3.20

We solved 1 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340584

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1727/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1727 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

[jira] [Resolved] (SLING-6870) ImportOperation is created to late

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-6870.
---
Resolution: Fixed

Fix in r1795909 by creating it in the constructor instead.

> ImportOperation is created to late
> --
>
> Key: SLING-6870
> URL: https://issues.apache.org/jira/browse/SLING-6870
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.18
>Reporter: Karl Pauls
>Assignee: Karl Pauls
> Fix For: Servlets Post 2.3.20
>
>
> The latest jcr dependency removal makes it so that the ImportOperation is 
> created in the @activate. That is too late, because the dependencies get set 
> before the @activate which causes the ImportOperation to have missing 
> dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6870) ImportOperation is created to late

[Karl Pauls (JIRA)]

Karl Pauls created SLING-6870:
-

 Summary: ImportOperation is created to late
 Key: SLING-6870
 URL: https://issues.apache.org/jira/browse/SLING-6870
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Affects Versions: Servlets Post 2.3.18
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Servlets Post 2.3.20


The latest jcr dependency removal makes it so that the ImportOperation is 
created in the @activate. That is too late, because the dependencies get set 
before the @activate which causes the ImportOperation to have missing 
dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6868) Initial content should use more specific path or be migrated to bundle resources

[Andrei Dulvac (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020804#comment-16020804
 ] 

Andrei Dulvac commented on SLING-6868:
--

[~cziegeler], the two sightly resource types would work with the 
Sing-Bundle-Resources header, but I'm not sure the [OOTB 
types|https://github.com/apache/sling/blob/trunk/contrib/extensions/hapi/core/src/main/resources/SLING-INF/libs/sling/hapi/types.json]
 would. Am I missing something? Is there a way to create nodes with arbitrary 
primary types and properties?

> Initial content should use more specific path or be migrated to bundle 
> resources
> 
>
> Key: SLING-6868
> URL: https://issues.apache.org/jira/browse/SLING-6868
> Project: Sling
>  Issue Type: Bug
>  Components: HApi
>Affects Versions: HApi 1.0.0
>Reporter: Carsten Ziegeler
>Assignee: Andrei Dulvac
> Fix For: HApi 1.0.2, HApi 2.0.0
>
>
> Currently the initial content in the hapi bundle does not specify a path, 
> which means it is using "/".
> When applied at the wrong time, it potentially could wipe the whole 
> repository. In addition initial content should always be specified with the 
> most specific path (the tree the bundle is owning)
> So the path is something like /libs/sling/hapi
> or even
> /libs/sling/hapi/components



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6868) Initial content should use more specific path or be migrated to bundle resources

[Andrei Dulvac (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac reassigned SLING-6868:


Assignee: Andrei Dulvac

> Initial content should use more specific path or be migrated to bundle 
> resources
> 
>
> Key: SLING-6868
> URL: https://issues.apache.org/jira/browse/SLING-6868
> Project: Sling
>  Issue Type: Bug
>  Components: HApi
>Affects Versions: HApi 1.0.0
>Reporter: Carsten Ziegeler
>Assignee: Andrei Dulvac
> Fix For: HApi 1.0.2, HApi 2.0.0
>
>
> Currently the initial content in the hapi bundle does not specify a path, 
> which means it is using "/".
> When applied at the wrong time, it potentially could wipe the whole 
> repository. In addition initial content should always be specified with the 
> most specific path (the tree the bundle is owning)
> So the path is something like /libs/sling/hapi
> or even
> /libs/sling/hapi/components



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Release Apache Sling Launchpad Content 2.0.12

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: build fails - missing dependency - easy fix

[Robert Munteanu]

Hi,

On Sun, 2017-05-21 at 01:24 +0300, Ioan Eugen Stan wrote:
> Hello,
> 
> I've just built Sling locally and the build failed with a missing
> dependency. It's an easy fix. See bellow the git diff. I've included
> the
> SNAPSHOT version, but you could include the release of
> org.apache.sling.validation.api.


Thanks for the notice and the patch, I've changed the version to 1.0.0
in r1795882 .

Robert

> 
> p.s. Glad to hear Sling 9 is being released soon. I'm planning to use
> it
> in a project (I enjoy composum feature). I have some questions that I
> will post on the mailing list as I formulate them.
> 
> 
> Great job,
> 
> Ioan Eugen Stan
> 
> -
> 
> diff --git a/bundles/extensions/validation/examples/pom.xml
> b/bundles/extensions/validation/examples/pom.xml
> index f52ce72ff9..5117080d75 100644
> --- a/bundles/extensions/validation/examples/pom.xml
> +++ b/bundles/extensions/validation/examples/pom.xml
> @@ -68,7 +68,7 @@
>  
>  org.apache.sling
>  org.apache.sling.validation.api
> -1.0.0-SNAPSHOT
> +1.0.1-SNAPSHOT
>  provided
>  
>  
> 
> 
> 
> 
> [ERROR] Failed to execute goal on project
> org.apache.sling.validation.examples: Could not resolve dependencies
> for
> project
> org.apache.sling:org.apache.sling.validation.examples:bundle:1.0.0-
> SNAPSHOT:
> Failure to find
> org.apache.sling:org.apache.sling.validation.api:jar:1.0.0-SNAPSHOT
> in
> https://repository.apache.org/snapshots was cached in the local
> repository, resolution will not be reattempted until the update
> interval
> of apache.snapshots has elapsed or updates are forced -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with
> the
> -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug
> logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolution
> Exception
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with
> the
> command
> 
> 
> 
>